Re: [coreboot] [PATCH] The PC buzzer for TIM-5690.

2009-11-23 Thread Stefan Reinauer
On 11/23/09 10:58 AM, Uwe Hermann wrote: > On Mon, Nov 23, 2009 at 12:01:26PM +0800, Bao, Zheng wrote: > >> Should the spkr.c be in the folder sb600, or more public folders like >> pc80? >> > It looks generic to me, I'd put it into lib or src/arch/i386/lib as it > might be x86-specific. > >

Re: [coreboot] [PATCH] The PC buzzer for TIM-5690.

2009-11-23 Thread Stefan Reinauer
On 11/23/09 11:08 AM, Bao, Zheng wrote: > > Since you need to call it in early stage, it is not good to put in pc80. > I don't think this is a problem... There is other code in src/pc80 that runs in early stage, like mc4168rtc_early.c and usbdebug_direct_serial.c src/pc80 seems like a better plac

Re: [coreboot] [PATCH] The PC buzzer for TIM-5690.

2009-11-23 Thread Bao, Zheng
, 2009 11:26 AM To: coreboot Subject: [coreboot] [PATCH] The PC buzzer for TIM-5690. Hi, This information mean initially with control PC speaker through AMD SB600. Please reference appendent file. Thanks

Re: [coreboot] [PATCH] The PC buzzer for TIM-5690.

2009-11-23 Thread Uwe Hermann
On Mon, Nov 23, 2009 at 12:01:26PM +0800, Bao, Zheng wrote: > Should the spkr.c be in the folder sb600, or more public folders like > pc80? It looks generic to me, I'd put it into lib or src/arch/i386/lib as it might be x86-specific. I wrote a similar function for v3 a while ago, see attached fil

Re: [coreboot] [PATCH] The PC buzzer for TIM-5690.

2009-11-23 Thread Libra Li
half Of *Libra Li >> *Sent:* Monday, November 23, 2009 11:26 AM >> *To:* coreboot >> *Subject:* [coreboot] [PATCH] The PC buzzer for TIM-5690. >> >> >> >> Hi, >> >> This information mean initially with control PC speaker through A

Re: [coreboot] [PATCH] The PC buzzer for TIM-5690.

2009-11-22 Thread Libra Li
--- > > *From:* coreboot-boun...@coreboot.org [mailto: > coreboot-boun...@coreboot.org] *On Behalf Of *Libra Li > *Sent:* Monday, November 23, 2009 11:26 AM > *To:* coreboot > *Subject:* [coreboot] [PATCH] The PC buzzer for TIM-5690. > > > > Hi,

Re: [coreboot] [PATCH] The PC buzzer for TIM-5690.

2009-11-22 Thread Bao, Zheng
] [PATCH] The PC buzzer for TIM-5690. Hi, This information mean initially with control PC speaker through AMD SB600. Please reference appendent file. Thanks. Signed-off-by: Libra Li http://libra.li/> @technexion.com <http://technexion.com/> > -- coreboot mailing li

[coreboot] [PATCH] The PC buzzer for TIM-5690.

2009-11-22 Thread Libra Li
Hi, This information mean initially with control PC speaker through AMD SB600. Please reference appendent file. Thanks. Signed-off-by: Libra Li Index: src/mainboard/technexion/tim5690/cache_as_ram_auto.c === --- src/main