Re: [coreboot] [PATCH] Use existing, readable MTRR #defines instead of hardcoding numbers

2010-09-30 Thread Uwe Hermann
On Thu, Sep 30, 2010 at 02:15:17PM -0600, Myles Watson wrote: > I'm surprised that the #defines were commented out. > > Acked-by: Myles Watson Thanks, r5887. Uwe. -- http://hermann-uwe.de | http://sigrok.org http://randomprojects.org | http://unmaintained-free-software.org -- coreboot m

Re: [coreboot] [PATCH] Use existing, readable MTRR #defines instead of hardcoding numbers

2010-09-30 Thread Myles Watson
I'm surprised that the #defines were commented out. Acked-by: Myles Watson Thanks, Myles -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot

[coreboot] [PATCH] Use existing, readable MTRR #defines instead of hardcoding numbers

2010-09-30 Thread Uwe Hermann
See patch. Uwe. -- http://hermann-uwe.de | http://sigrok.org http://randomprojects.org | http://unmaintained-free-software.org Use existing, readable MTRR #defines instead of hardcoding numbers. Replace $0x200 with $MTRRphysBase_MSR(0) etc. Also, move some #ifdef stuff a little bit around (