Re: [coreboot] [PATCH] clarify << and -

2010-04-14 Thread Myles Watson
> > If we can't decide on the right fix we should leave the warning there as it > keeps the question open until someone can answer it. > I agree. Thanks, Myles -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot

Re: [coreboot] [PATCH] clarify << and -

2010-04-14 Thread Stefan Reinauer
On 4/14/10 9:35 PM, Myles Watson wrote: > > > On Wed, Apr 14, 2010 at 1:22 PM, Stefan Reinauer > mailto:ste...@coresystems.de>> wrote: > > On 4/14/10 6:44 PM, Myles Watson wrote: >> >> Index: src/northbridge/amd/gx2/chipsetinit.c >> ==

Re: [coreboot] [PATCH] clarify << and -

2010-04-14 Thread Carl-Daniel Hailfinger
On 14.04.2010 21:35, Myles Watson wrote: > On Wed, Apr 14, 2010 at 1:22 PM, Stefan Reinauer wrote: > > >> On 4/14/10 6:44 PM, Myles Watson wrote: >> >> >> Index: src/northbridge/amd/gx2/chipsetinit.c >> >>> === >>> --- src/no

Re: [coreboot] [PATCH] clarify << and -

2010-04-14 Thread Myles Watson
On Wed, Apr 14, 2010 at 1:22 PM, Stefan Reinauer wrote: > On 4/14/10 6:44 PM, Myles Watson wrote: > > > Index: src/northbridge/amd/gx2/chipsetinit.c >> === >> --- src/northbridge/amd/gx2/chipsetinit.c (revision 5425) >> +++ src/nort

Re: [coreboot] [PATCH] clarify << and -

2010-04-14 Thread Stefan Reinauer
On 4/14/10 6:44 PM, Myles Watson wrote: > > Index: src/northbridge/amd/gx2/chipsetinit.c > === > --- src/northbridge/amd/gx2/chipsetinit.c (revision 5425) > +++ src/northbridge/amd/gx2/chipsetinit.c (working copy) >

Re: [coreboot] [PATCH] clarify << and -

2010-04-14 Thread Myles Watson
> Index: src/northbridge/amd/gx2/chipsetinit.c > === > --- src/northbridge/amd/gx2/chipsetinit.c (revision 5425) > +++ src/northbridge/amd/gx2/chipsetinit.c (working copy) > @@ -275,7 +275,7 @@ > if ((msr.lo&0xff) == 0x11) > return; >

[coreboot] [PATCH] clarify << and -

2010-04-14 Thread Stefan Reinauer
Signed-off-by: Stefan Reinauer Index: src/northbridge/amd/gx2/chipsetinit.c === --- src/northbridge/amd/gx2/chipsetinit.c (revision 5425) +++ src/northbridge/amd/gx2/chipsetinit.c (working copy) @@ -275,7 +275,7 @@ if ((msr.lo&0xff)