Re: [coreboot] [PATCH] e7501 register pressure

2010-02-23 Thread Uwe Hermann
On Mon, Feb 22, 2010 at 04:30:20PM -0800, ron minnich wrote: > On Mon, Feb 22, 2010 at 4:03 PM, Stefan Reinauer > wrote: > > > Does anyone have the hardware? > > > > I doubt anyone does. The question here is, if no one can test it, are > we better off making a change we can not test, Yes. >

Re: [coreboot] [PATCH] e7501 register pressure

2010-02-22 Thread ron minnich
On Mon, Feb 22, 2010 at 4:03 PM, Stefan Reinauer wrote: > Does anyone have the hardware? > I doubt anyone does. The question here is, if no one can test it, are we better off making a change we can not test, or removing the support. If there is hardware so old that we can not test, i'm more comf

Re: [coreboot] [PATCH] e7501 register pressure

2010-02-22 Thread Stefan Reinauer
On 2/23/10 12:45 AM, ron minnich wrote: > There's a way to test this? > > Not for me... it's 2 boards out of 20+ But we did the same conversion for i945 and i830 before, so it's generally a good idea. The smarter thing would be to convert the board to CAR, but if I had to choose between those

Re: [coreboot] [PATCH] e7501 register pressure

2010-02-22 Thread ron minnich
There's a way to test this? ron -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot

[coreboot] [PATCH] e7501 register pressure

2010-02-22 Thread Stefan Reinauer
See patch wow this code could use an indent,... but I just exchanged all the ctrl->d0 by PCI_DEV(0, 0, 0) which took off a significant amount of register pressure while compiling with romcc. Enough to keep the code working with the unified assert.h I posted today. Signed-off-by: Stefan Reinauer