Hi,
I moved the SET_FIDVID family of configuration options to Kconfig,
adapting its use (CONFIG_ prefix), and tried to minimize the board
specific settings.
They get some defaults in src/cpu/amd/model_*xx/Kconfig, which are
derived from the various #ifndef ... #define ... #endif blocks I removed
Hi,
I updated the SET_FIDVID patch to match the current tree, and also
validated it against the pre-patch tree. To do this, I added to
src/cpu/amd/model_*xx/fidvid.c a bunch of
#if SET_FIDVID
#warning SET_FIDVID
#endif
style blocks to the pre-patch tree, for all SET_FIDVID* flags, and with
CONFIG_
On Sat, Nov 06, 2010 at 01:56:45PM +0100, Patrick Georgi wrote:
> Hi,
>
> I moved the SET_FIDVID family of configuration options to Kconfig,
> adapting its use (CONFIG_ prefix), and tried to minimize the board
> specific settings.
>
> They get some defaults in src/cpu/amd/model_*xx/Kconfig, which
Am 07.11.2010 02:28, schrieb xdrudis:
> So far so good. I'm not sure FIDVID can be an option for fam10 .
> BKDG require it but I don't know if any fam10 cpu can boot without it.
It is an option right now (just in romstage.c) - maybe we should drop
some of these options on Fam10 completely (and thei
On Sun, Nov 07, 2010 at 08:37:00AM +0100, Patrick Georgi wrote:
> Am 07.11.2010 02:28, schrieb xdrudis:
> It is an option right now (just in romstage.c) - maybe we should drop
> some of these options on Fam10 completely (and their uses as well), but
> for now all I want to do is move them to Kconfi
Am 13.11.2010 09:16, schrieb Patrick Georgi:
> Hi,
>
> I updated the SET_FIDVID patch to match the current tree, and also
> validated it against the pre-patch tree. To do this, I added to
> src/cpu/amd/model_*xx/fidvid.c a bunch of
> #if SET_FIDVID
> #warning SET_FIDVID
> #endif
> style blocks to
* Patrick Georgi [101116 17:29]:
> Am 13.11.2010 09:16, schrieb Patrick Georgi:
> > Hi,
> >
> > I updated the SET_FIDVID patch to match the current tree, and also
> > validated it against the pre-patch tree. To do this, I added to
> > src/cpu/amd/model_*xx/fidvid.c a bunch of
> > #if SET_FIDVID
>
On Tue, Nov 16, 2010 at 05:29:50PM +0100, Patrick Georgi wrote:
> > Move the SET_FIDVID* family of configuration options to Kconfig and
> > make their defaults more obvious.
> >
> > Signed-off-by: Patrick Georgi
> >
> ping?
Looks good, but please also include the new A8V-E Deluxe target in the
Am 16.11.2010 22:11, schrieb Uwe Hermann:
> Looks good, but please also include the new A8V-E Deluxe target in the
> patch before the commit.
Done
> Acked-by: Uwe Hermann
Thanks, r6077
Patrick
--
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot
9 matches
Mail list logo