Re: [coreboot] [PATCH]Move cpu includes to cpus

2010-04-12 Thread Joseph Smith
On 04/12/2010 11:42 AM, Stefan Reinauer wrote: Am 12.04.2010 17:18, schrieb Stefan Reinauer: These boards have the same CPU socket, thus should be able to use CAR: ./src/mainboard/dell/s1850/Kconfig: select CPU_INTEL_SOCKET_MPGA604 ./src/mainboard/intel/jarrell/Kconfig: select CPU_INTEL_SOCKE

Re: [coreboot] [PATCH]Move cpu includes to cpus

2010-04-12 Thread Joseph Smith
On 04/12/2010 10:16 AM, Patrick Georgi wrote: Hi, attached patch moves the CPU specific includes from src/arch/i386/Makefile.inc to the respective CPU directories. One exception is the tyan/s2735 rule, as this is a weird situation: Yes it is. I think it was just coverted over from v1 this way.

Re: [coreboot] [PATCH]Move cpu includes to cpus

2010-04-12 Thread Stefan Reinauer
> > Am 12.04.2010 17:18, schrieb Stefan Reinauer: > >> These boards have the same CPU socket, thus should be able to use CAR: >> >> ./src/mainboard/dell/s1850/Kconfig: select CPU_INTEL_SOCKET_MPGA604 >> ./src/mainboard/intel/jarrell/Kconfig: select CPU_INTEL_SOCKET_MPGA604 >> ./src/mainboard/int

Re: [coreboot] [PATCH]Move cpu includes to cpus

2010-04-12 Thread Patrick Georgi
Am 12.04.2010 17:18, schrieb Stefan Reinauer: > These boards have the same CPU socket, thus should be able to use CAR: > > ./src/mainboard/dell/s1850/Kconfig: select CPU_INTEL_SOCKET_MPGA604 > ./src/mainboard/intel/jarrell/Kconfig: select CPU_INTEL_SOCKET_MPGA604 > ./src/mainboard/intel/xe7501devk

Re: [coreboot] [PATCH]Move cpu includes to cpus

2010-04-12 Thread Stefan Reinauer
> > Hi, > > attached patch moves the CPU specific includes from > src/arch/i386/Makefile.inc to the respective CPU directories. > Very nice.. this will make using CAR easier, and the code flow easier to understand > One exception is the tyan/s2735 rule, as this is a weird situation: CAR > code f

[coreboot] [PATCH]Move cpu includes to cpus

2010-04-12 Thread Patrick Georgi
Hi, attached patch moves the CPU specific includes from src/arch/i386/Makefile.inc to the respective CPU directories. One exception is the tyan/s2735 rule, as this is a weird situation: CAR code for exactly one board. As soon as sibling boards are identified and CAR enabled, it would make sense to