Re: [coreboot] [PATCH]Use cbfs-files-y for normal file additions

2011-01-30 Thread Patrick Georgi
Am 29.01.2011 11:22, schrieb Peter Stuge: +cbfs-files-$(CONFIG_VGA_BIOS) += pci$(call strip_quotes,$(CONFIG_VGA_BIOS_ID)).rom +pci$(CONFIG_VGA_BIOS_ID)-file := $(call strip_quotes,$(CONFIG_VGA_BIOS_FILE)) +pci$(CONFIG_VGA_BIOS_ID)-type := optionrom These last two need .rom as well,

Re: [coreboot] [PATCH]Use cbfs-files-y for normal file additions

2011-01-29 Thread Peter Stuge
Georgi, Patrick wrote: Question is, if we should drop these Kconfig options entirely and let the user handle these entries in the board's Makefile.inc? Sometimes the files come from chipset though. Signed-off-by: Patrick Georgi patrick.geo...@secunet.com With the fix below: Acked-by: Peter

[coreboot] [PATCH]Use cbfs-files-y for normal file additions

2011-01-28 Thread Georgi, Patrick
Hi, we currently have special cases for VGABIOS, Intel MBI and splashscreens. Use cbfs-files-y instead, which provides a canonical way for adding raw files to CBFS. Question is, if we should drop these Kconfig options entirely and let the user handle these entries in the board's Makefile.inc?