autoboot_delay.diff (changes filo.c):
Fixes compile error if AUTOBOOT_DELAY=0.
fs_arch.diff (changes ext2fs.c, fat.c):
#if ARCH == 'i386'
results in a compile warning: "multi-character character constant" and
the condition ARCH=='i386' is mis-evaluated as FALSE, eventually choking
the assembler on a PPC instruction. Changed it to
#ifdef __i386
it8712_gpio.diff (changes superio.c (IT8712F)):
Added the missing I/O resources for IT8712F GPIOs. Our boards need those
e.g. to switch the com ports from RS232 to RS485.
Signed-off-by: Jens Rottmann <[EMAIL PROTECTED]>
---
Above are my remaining 3 fixes/improvements. Anyone please comment (or,
preferably, commit :-) Again, thanks to Marc, who kindly already took
care of the other 4. The patches are independent of each other.
Note about fs_arch.diff:
Complete build output was attached to my previous mail.
Note about it8712_gpio.diff:
The IT8712F manual makes it look like PNP_IO1 had a size/granularity of
1 byte, but that must be a mistake. The Simple-I/O resource has a size
of 5 bytes (1 for each GPIO set 1-5) and trying different addresses
reveals a granularity of 8.
Regards,
Jens Rottmann
Index: src/stream/fs/ext2fs.c
===================================================================
--- src/stream/fs/ext2fs.c (revision 3708)
+++ src/stream/fs/ext2fs.c (working copy)
@@ -239,7 +239,7 @@
* ffz = Find First Zero in word. Undefined if no zero exists,
* so code should check against ~0UL first..
*/
-#if ARCH == 'i386'
+#ifdef __i386
static __inline__ unsigned long
ffz (unsigned long word)
{
Index: src/stream/fs/fat.c
===================================================================
--- src/stream/fs/fat.c (revision 3708)
+++ src/stream/fs/fat.c (working copy)
@@ -54,7 +54,7 @@
#define FAT_CACHE_SIZE 2048
-#if ARCH == 'i386'
+#ifdef __i386
static __inline__ unsigned long
log2 (unsigned long word)
{
Index: src/superio/ite/it8712f/superio.c
===================================================================
--- src/superio/ite/it8712f/superio.c (revision 3708)
+++ src/superio/ite/it8712f/superio.c (working copy)
@@ -129,7 +129,7 @@
{&ops, IT8712F_EC, PNP_IO0 | PNP_IO1 | PNP_IRQ0, {0xff8, 0}, {0xff8,
4},},
{&ops, IT8712F_KBCK, PNP_IO0 | PNP_IO1 | PNP_IRQ0, {0xfff, 0}, {0xfff,
4},},
{&ops, IT8712F_KBCM, PNP_IRQ0,},
- {&ops, IT8712F_GPIO,},
+ {&ops, IT8712F_GPIO, PNP_IO0 | PNP_IO1 | PNP_IO2 | PNP_IRQ0, {0xfff,
0}, {0xff8, 0}, {0xff8, 0},},
{&ops, IT8712F_MIDI, PNP_IO0 | PNP_IRQ0, {0xff8, 0},},
{&ops, IT8712F_GAME, PNP_IO0, {0xfff, 0},},
{&ops, IT8712F_IR, PNP_IO0 | PNP_IRQ0, {0xff8, 0},},
Index: src/boot/filo.c
===================================================================
--- src/boot/filo.c (revision 3708)
+++ src/boot/filo.c (working copy)
@@ -18,7 +18,7 @@
#define autoboot(mem)
#endif
-#ifndef AUTOBOOT_DELAY
+#if !AUTOBOOT_DELAY
#define autoboot_delay() 0 /* success */
#endif
--
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot
