Re: [coreboot] [PATCH 3/6] Geode GX2 cleanup patch

2010-12-27 Thread Nils
Stefan wrote: >On 26.12.2010, at 06:19, Peter Stuge wrote: > >> Nils wrote: >>> -__asm__ __volatile__("hlt\n"); >>> +while(1) { >>> +__asm__ __volatile__("hlt\n"); >>> +} >> >> Why not call die() instead? Is it too early for that? >> >> > >Die() is now extra.

Re: [coreboot] [PATCH 3/6] Geode GX2 cleanup patch

2010-12-26 Thread Stefan Reinauer
On 26.12.2010, at 06:19, Peter Stuge wrote: > Nils wrote: >> -__asm__ __volatile__("hlt\n"); >> +while(1) { >> +__asm__ __volatile__("hlt\n"); >> +} > > Why not call die() instead? Is it too early for that? > > Die() is now extra. It should work early. -

Re: [coreboot] [PATCH 3/6] Geode GX2 cleanup patch

2010-12-25 Thread Peter Stuge
Nils wrote: > - __asm__ __volatile__("hlt\n"); > + while(1) { > + __asm__ __volatile__("hlt\n"); > + } Why not call die() instead? Is it too early for that? //Peter -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/m

[coreboot] [PATCH 3/6] Geode GX2 cleanup patch

2010-12-22 Thread Nils
Add a "while (1)" function around the hlt instruction to assure the processor can't wake up from an interrupt. Signed-off-by: Nils Jacobs This was suggested by Uwe Hermann. Thanks! I also included the same patch for Geode LX. Nils. Index: src/northbridge/amd/gx2/pll_reset.c