Re: [coreboot] [commit] r5976 - trunk/src/cpu/amd/car

2010-10-21 Thread Scott Duplichan
-Original Message- From: coreboot-boun...@coreboot.org [mailto:coreboot-boun...@coreboot.org] On Behalf Of Peter Stuge Sent: Thursday, October 21, 2010 03:50 AM To: coreboot@coreboot.org Subject: Re: [coreboot] [commit] r5976 - trunk/src/cpu/amd/car ]Scott Duplichan wrote: ]>

Re: [coreboot] [commit] r5976 - trunk/src/cpu/amd/car

2010-10-21 Thread Peter Stuge
Scott Duplichan wrote: > a straightforward and readable method of finding the base2 log at > either assembly time or at run time. bsf or maybe rather bsr could be used to do it pretty easily, but I like having the compile time "perparsing" as a sort of sanity check. I wouldn't want to get rid of t

Re: [coreboot] [commit] r5976 - trunk/src/cpu/amd/car

2010-10-20 Thread xdrudis
On Wed, Oct 20, 2010 at 02:20:12PM -0500, Scott Duplichan wrote: > But gas has no base 2 log function and could not figure out how to > write a macro that returns a constant. > Sorry, ignore my previous post . I misread and answered without thinking. It was about gas, not about log2. I'm surpri

Re: [coreboot] [commit] r5976 - trunk/src/cpu/amd/car

2010-10-20 Thread xdrudis
On Wed, Oct 20, 2010 at 02:20:12PM -0500, Scott Duplichan wrote: >movl $(log2(CONFIG_MMCONF_BUS_NUMBER) << 2), %eax I have no idea of gas, but log2(x) for integer x > 0 is the position of the leftmost 1 in the binary representation of x (position 0=rightmost). int log2(unsigned int x) {

Re: [coreboot] [commit] r5976 - trunk/src/cpu/amd/car

2010-10-20 Thread Scott Duplichan
-Original Message- From: coreboot-boun...@coreboot.org [mailto:coreboot-boun...@coreboot.org] On Behalf Of Warren Turkal Sent: Wednesday, October 20, 2010 03:20 AM To: coreboot@coreboot.org Subject: Re: [coreboot] [commit] r5976 - trunk/src/cpu/amd/car ]On Tue, Oct 19, 2010 at 2:08 PM

Re: [coreboot] [commit] r5976 - trunk/src/cpu/amd/car

2010-10-20 Thread Warren Turkal
On Tue, Oct 19, 2010 at 2:08 PM, repository service wrote: > +   #if (CONFIG_MMCONF_BASE_ADDRESS > 0x) > +   #error "MMCONF_BASE_ADDRESS too big" > +   #elif (CONFIG_MMCONF_BASE_ADDRESS & 0xF) > +   #error "MMCONF_BASE_ADDRESS not 1MB aligned" > +   #endif > +       movl    $0, %edx >

[coreboot] [commit] r5976 - trunk/src/cpu/amd/car

2010-10-19 Thread repository service
Author: sduplichan Date: Tue Oct 19 23:08:11 2010 New Revision: 5976 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5976 Log: For AMD family 10h processors, msr c0010058 is always programmed for 256 buses, even if fewer are configured. This patch lets msr c0010058 programming use the co