Re: [coreboot] [patch] Fixed the LZMA compression flag in Kbuild

On Sat, Aug 22, 2009 at 2:41 PM, Patrick Georgi wrote: > Am 22.08.2009 23:25, schrieb ron minnich: >> >> It needs to be 'y' for Kconfig but it will have to be fixed in all the >> old usages. This is not a big deal to fix. We should change it >> sounds good, sorry for my confusion ... forgot about

Re: [coreboot] [patch] Fixed the LZMA compression flag in Kbuild

Am 22.08.2009 23:25, schrieb ron minnich: It needs to be 'y' for Kconfig but it will have to be fixed in all the old usages. This is not a big deal to fix. We should change it See build/config.h: "y" is "1" there. Patrick -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot

Re: [coreboot] [patch] Fixed the LZMA compression flag in Kbuild

Here are all uses I could fine. Defaults to 0 in old config tool. Set to 1 if used in new config tool. If src/Kconfig it is: config COMPRESSED_PAYLOAD_LZMA bool default y So we have a problem. Here are the usages I could find. src/mainboard/intel/eagleheights/Options.lb:default C

Re: [coreboot] [patch] Fixed the LZMA compression flag in Kbuild

This is not quite complete. For example, src/boot/selfboot.c:#if CONFIG_COMPRESSED_PAYLOAD_LZMA==1 We're going to need to rationalize the uses of this variable across old and new config tools and code. I'll try to look more later or you can look too. This is not the only problem of this type we

[coreboot] [patch] Fixed the LZMA compression flag in Kbuild

Please check the attached trivial patch. It properly checks for the LZMA compression variable, and fixes a print message for the VGA ROM that would print a useless NULL string. Thanks, Cristi The patch is Signed-off by: Cristi Magherusan From f97e9d74d938a2503103407a0cba8899956ffe91 Mon Sep 17