Re: [coreboot] [patch] Kconfig support for M57SLI

2009-08-28 Thread Stefan Reinauer
On 8/28/09 7:44 PM, Uwe Hermann wrote: >> +config BOARD_GIGABYTE_M57SLI >> +bool "M57SLI" >> > Full names as per vendor website please, in this case: > > config BOARD_GIGABYTE_GA_M57SLI_S4 > bool "GA-M57SLI-S4" > > There are multiple occurences below, please fix them all. > Oh,

Re: [coreboot] [patch] Kconfig support for M57SLI

2009-08-28 Thread Uwe Hermann
On Wed, Aug 26, 2009 at 08:14:39PM +0200, Harald Gutmann wrote: > Index: src/mainboard/gigabyte/m57sli/Kconfig > === > --- src/mainboard/gigabyte/m57sli/Kconfig (revision 0) > +++ src/mainboard/gigabyte/m57sli/Kconfig (revision

Re: [coreboot] [patch] Kconfig support for M57SLI

2009-08-26 Thread Harald Gutmann
Hmm... Why do I so often forget that I should/want to attach something? Here it is. Note: The devicetree.cb just contains some cleanup and whitespace fixes. There have no "changes" been done on that file. On Wednesday 26 August 2009 20:09:32 Harald Gutmann wrote: > Here is my new version of the

[coreboot] [patch] Kconfig support for M57SLI

2009-08-26 Thread Harald Gutmann
Here is my new version of the Kconfig patch for M57SLI. It does build, but there are some warnings about CONFIG_* values not defined. Right now I have not tested the generated images, but I think I can do that tomorrow. When the images work, it will get the "Signed-off" tag. Thanks to Myles Wat