There are a couple of boards that don't compile for me with crossgcc.
Here's a representative error:
src/mainboard/asus/a8v-e_se/mptable.c:23:54: error:
src/include/../../../southbridge/via/vt8237r/vt8237r.h: Permission
denied
The problem is that the compiler is looking for the file
../../../sout
Myles Watson wrote:
> There are many ways to fix it, but I'm not sure which one is the
> correct (most future-proof) way.
..
> 3. Just use the path
I think this is *by far* the cleanest approach!
//Peter
--
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/c
On Mon, Jul 26, 2010 at 11:09 AM, Peter Stuge wrote:
> Myles Watson wrote:
>> There are many ways to fix it, but I'm not sure which one is the
>> correct (most future-proof) way.
> ..
>> 3. Just use the path
>
> I think this is *by far* the cleanest approach!
I agree that it looks the best. I'm
Myles Watson wrote:
> >> 3. Just use the path
> >
> > I think this is *by far* the cleanest approach!
>
> I agree that it looks the best. I'm worried that it introduces
> ambiguity.
>
> #include
>
> Could look in src/path/file.h or src/include/path/file.h and others
>
> Is that what we want?
Am 26.07.2010 20:01, schrieb Peter Stuge:
> I'm not sure that I feel good about .h files outside include/ being
> referenced from other parts of the code. They should probably be
> moved to include/ if they are needed in more than one place..
Mainboards need to include chipset specific information,
On Mon, Jul 26, 2010 at 12:57 PM, Patrick Georgi wrote:
> Am 26.07.2010 20:01, schrieb Peter Stuge:
>> I'm not sure that I feel good about .h files outside include/ being
>> referenced from other parts of the code. They should probably be
>> moved to include/ if they are needed in more than one pl
On Mon, Jul 26, 2010 at 12:01 PM, Peter Stuge wrote:
> Myles Watson wrote:
>> >> 3. Just use the path
>> >
>> > I think this is *by far* the cleanest approach!
>>
>> I agree that it looks the best. I'm worried that it introduces
>> ambiguity.
>>
>> #include
>>
>> Could look in src/path/file.h or
Patrick Georgi wrote:
> > .h files outside include/
> > They should probably be moved to include/
>
> Mainboards need to include chipset specific information, and I'd
> like to avoid moving all that into include/ if possible.
Why not do it?
Myles Watson wrote:
> I think that's a reasonable exce
On Mon, Jul 26, 2010 at 1:22 PM, Peter Stuge wrote:
> Patrick Georgi wrote:
>> > .h files outside include/
>> > They should probably be moved to include/
>>
>> Mainboards need to include chipset specific information, and I'd
>> like to avoid moving all that into include/ if possible.
>
> Why not d
On 7/26/10 9:28 PM, Myles Watson wrote:
> I was thinking of some of the ACPI code, that is not
> mainboard-dependent but chipset-dependent. That's been slowly moving
> to the chipset directories.
>
If we can get rid of exceptions by cleaning more code up in this way we
should certainly do it.
St
Myles wrote:
>Linux does it that way. It keeps all of the architecture-specific
>code and includes under arch/
>
>include_path.diff: fix the ones that are broken for me.
>include_path2.diff: fix the ones that look identical but work anyway.
>include_path3.diff: fix <../path/file.h> to be "../../..
>>include_path.diff: fix the ones that are broken for me.
>>include_path2.diff: fix the ones that look identical but work anyway.
>>include_path3.diff: fix <../path/file.h> to be "../../../path/file.h"
>>to make it obvious that they're not in src/include
>>
>>Abuild tested.
>>
>>Signed-off-by: Myle
12 matches
Mail list logo
