Re: [coreboot] IBM/Lenovo X60t: LED_: Excess arguments - needs 1, found 2

2014-08-26 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 26.08.2014 17:53, Charles Devereaux wrote: > My understanding is that the OS does the call that correctly, but that > coreboot ASL tables only expect one argument. Please provide a refrence when doing such bold claims. LED method is not specified in ACPI, so assuming that it takes any particular

Re: [coreboot] IBM/Lenovo X60t: LED_: Excess arguments - needs 1, found 2

2014-08-26 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 26.08.2014 08:50, Paul Menzel wrote: > Dear Charles, dear David, > > > Am Montag, den 25.08.2014, 11:21 -0600 schrieb David Hubbard: > >> I'm focusing in on this error message first: >> >> ACPI Warning: For \_SB_.PCI0.LPCB.EC__.LED_: Excess arguments - needs 1, >> found 2 >> >> Can you take a

Re: [coreboot] IBM/Lenovo X60t: LED_: Excess arguments - needs 1, found 2 (was: IBM x60t test - DSDT is in fact incomplete)

2014-08-26 Thread Charles Devereaux
Hello Not sure! Apparently, after doing echo "0 blink" >/proc/acpi/ibm/led, this is handled led_set_status in drivers/platform/x86/thinkpad_acpi.c : the first argument is the led, the second the status : acpi_evalf(led_handle, NULL, NULL, "vdd", led, led_led_arg1[ledstatus])) For the LED string,

Re: [coreboot] IBM/Lenovo X60t: LED_: Excess arguments - needs 1, found 2 (was: IBM x60t test - DSDT is in fact incomplete)

2014-08-25 Thread Paul Menzel
Dear Charles, dear David, Am Montag, den 25.08.2014, 11:21 -0600 schrieb David Hubbard: > I'm focusing in on this error message first: > > ACPI Warning: For \_SB_.PCI0.LPCB.EC__.LED_: Excess arguments - needs 1, > found 2 > > Can you take a look at the .asl files in your coreboot build? I beli