Re: [coreboot] Kconfig patches

2009-09-22 Thread Myles Watson
On Tue, Sep 22, 2009 at 11:36 AM, ron minnich wrote: > All are > Acked-by: Ronald G. Minnich > > I really like the tables cleanup too. > Thanks. > We do need to get some of those k8 options out of mainboards, but > that's a future fix. > I'm not sure where they should go. I guess we'd have to

Re: [coreboot] Kconfig patches

2009-09-22 Thread Myles Watson
> > Great work! > > Kconfig_bools.diff defines LOGICAL_CPUS as bool, shouldn't it be left as > int instead? It is used as either true or false. The way to tell how many logical CPUs there might be is dividing CONFIG_MAX_CPUS and CONFIG_MAX_PHYSICAL_CPUS. from src/northbridge/amd/amdk8/.svn/tex

Re: [coreboot] Kconfig patches

2009-09-22 Thread Cristi Magherusan
On Tue, 2009-09-22 at 10:36 -0700, ron minnich wrote: > All are > Acked-by: Ronald G. Minnich > > I really like the tables cleanup too. > > We do need to get some of those k8 options out of mainboards, but > that's a future fix. These patches are a big improvement. > > ron > Great work! Kcon

Re: [coreboot] Kconfig patches

2009-09-22 Thread ron minnich
All are Acked-by: Ronald G. Minnich I really like the tables cleanup too. We do need to get some of those k8 options out of mainboards, but that's a future fix. These patches are a big improvement. ron -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/co

[coreboot] Kconfig patches

2009-09-22 Thread Myles Watson
I'm still trying to update my Tyan boards so they don't get pruned. They're pretty close, there is still an issue with ACPI that I'm working on, but I'd like to start shrinking my patch stack. tables.diff: Add Kconfig dialogues for ACPI, MP_TABLE, ... Kconfig_bools.diff: Change some more ints to