Re: [coreboot] MinnowMax: Tentative patch for S3 suspend/resume support

2014-09-18 Thread Mohan
Also need to add a "Signed-off-by:" to my patch. Yes, and gerrit will force you to do that when you do the git push. Stop in #coreboot if you have questions or problems on your first commit. Once it is in gerrit. Regards, Marc Thanks for the information. I have managed to created a review

Re: [coreboot] MinnowMax: Tentative patch for S3 suspend/resume support

2014-09-12 Thread Marc Jones
Hi Mohan, Thanks for your patch. On Fri, Sep 12, 2014 at 12:50 AM, Mohan wrote: > On 09/11/14 18:16, Idwer Vollering wrote: >> >> 2014-09-11 9:34 GMT+02:00 Mohan : >>> >>> Hi, >>> >>> This is a tentative patch for S3 suspend/resume support in MinnowMax >>> Board. >> >> (..) > > ?? > > Th

Re: [coreboot] MinnowMax: Tentative patch for S3 suspend/resume support

2014-09-11 Thread Mohan
On 09/11/14 18:16, Idwer Vollering wrote: 2014-09-11 9:34 GMT+02:00 Mohan : Hi, This is a tentative patch for S3 suspend/resume support in MinnowMax Board. (..) ?? This patch is more of a requests for comments.. Comments, suggestion, corrections are welcome. I would like to get i

Re: [coreboot] MinnowMax: Tentative patch for S3 suspend/resume support

2014-09-11 Thread Idwer Vollering
2014-09-11 9:34 GMT+02:00 Mohan : > Hi, > > This is a tentative patch for S3 suspend/resume support in MinnowMax Board. (..) > Comments, suggestion, corrections are welcome. > I would like to get it added it, can anyone help me ? Certainly. Have you read this subpage, http://www.coreboot.org/Dev

[coreboot] MinnowMax: Tentative patch for S3 suspend/resume support

2014-09-11 Thread Mohan
Hi, This is a tentative patch for S3 suspend/resume support in MinnowMax Board. It is based on the "src/soc/intel/baytrail/romstage/romstage.c" implementation. Tested wakeup from Power Button and Magic packet using Debian Jessie RFS and grub2.elf as coreboot payload. S3 suspend/resume requir