Re: [coreboot] Moved 'pci_set_subsystem' to a weak function: Support for Siemens Mainboard

2011-02-02 Thread Joseph Kellermann
' to a weak function: Support for Siemens Mainboard Am Dienstag, den 25.01.2011, 13:24 +0100 schrieb Georgi, Patrick: I'm not quite sure if using weak functions to wrap the subsystem CONFIG_* values is actually the right approach, I'll work on a patch to discuss. Here it is. I tested it by providing

[coreboot] Moved 'pci_set_subsystem' to a weak function: Support for Siemens Mainboard

2011-01-25 Thread Joseph Kellermann
I've compiled support for the Siemens 'sitemp' Mainboard. The board is similar to the AMD dbm690t. I adapt the code from dbm690t according to customer requirement specification. Linux is booting with seabios/filo. Windows XP is booting with seabios. This board comes with two hardware variants so

Re: [coreboot] Moved 'pci_set_subsystem' to a weak function: Support for Siemens Mainboard

2011-01-25 Thread Georgi, Patrick
Am Dienstag, den 25.01.2011, 10:44 + schrieb Joseph Kellermann: Also I've found an issue: The default 'pci_set_subsystem' sets the subvendor/device id register# 0x2c. However, for a few devices in the RS690 the register is 0x4c respectively 0x50. Moved 'pci_set_subsystem' to a weak

Re: [coreboot] Moved 'pci_set_subsystem' to a weak function: Support for Siemens Mainboard

2011-01-25 Thread Joseph Kellermann
'pci_set_subsystem' to a weak function: Support for Siemens Mainboard Am Dienstag, den 25.01.2011, 10:44 + schrieb Joseph Kellermann: Also I've found an issue: The default 'pci_set_subsystem' sets the subvendor/device id register# 0x2c. However, for a few devices in the RS690 the register

Re: [coreboot] Moved 'pci_set_subsystem' to a weak function: Support for Siemens Mainboard

2011-01-25 Thread Georgi, Patrick
Am Dienstag, den 25.01.2011, 12:03 + schrieb Joseph Kellermann: Yes, I can do, but how can I implement these requirement: board comes with two hardware variants so I have to set up subvendor/device ids accordingly. that's, in 'mainboard.c' I check for 'PLX device present' and set up

Re: [coreboot] Moved 'pci_set_subsystem' to a weak function: Support for Siemens Mainboard

2011-01-25 Thread Georgi, Patrick
Am Dienstag, den 25.01.2011, 13:24 +0100 schrieb Georgi, Patrick: I'm not quite sure if using weak functions to wrap the subsystem CONFIG_* values is actually the right approach, I'll work on a patch to discuss. Here it is. I tested it by providing a mainboard_pci_subsystem_vendor_id for my

Re: [coreboot] Moved 'pci_set_subsystem' to a weak function: Support for Siemens Mainboard

2011-01-25 Thread Joseph Kellermann
Great, i will test it. Thanks, Joseph Von: Georgi, Patrick [patrick.geo...@secunet.com] Gesendet: Dienstag, 25. Januar 2011 13:54 Bis: Joseph Kellermann Cc: coreboot@coreboot.org Betreff: Re: [coreboot] Moved 'pci_set_subsystem' to a weak function: Support

Re: [coreboot] Moved 'pci_set_subsystem' to a weak function: Support for Siemens Mainboard

2011-01-25 Thread Joseph Kellermann
: [coreboot] Moved 'pci_set_subsystem' to a weak function: Support for Siemens Mainboard Am Dienstag, den 25.01.2011, 13:24 +0100 schrieb Georgi, Patrick: I'm not quite sure if using weak functions to wrap the subsystem CONFIG_* values is actually the right approach, I'll work on a patch to discuss