Re: [coreboot] PCI config

2009-10-22 Thread Stefan Reinauer
Myles Watson wrote: The attached patch fixes booting for arima/hdama. How should we really fix it? In v3 didn't we just scrap type 2 accesses all together? We can keep the type 2 support code, but the auto detection at run time makes absolutely no sense. I sent a patch for this some days

Re: [coreboot] PCI config

2009-10-22 Thread Stefan Reinauer
Myles Watson wrote: How should we really fix it? In v3 didn't we just scrap type 2 accesses all together? We can keep the type 2 support code, but the auto detection at run time makes absolutely no sense. I sent a patch for this some days ago, but I think Carl-Daniel didn't have

Re: [coreboot] PCI config

2009-10-22 Thread Myles Watson
Myles Watson wrote: How should we really fix it? In v3 didn't we just scrap type 2 accesses all together? We can keep the type 2 support code, but the auto detection at run time makes absolutely no sense. I sent a patch for this some days ago, but I think Carl-Daniel didn't have

Re: [coreboot] PCI config

2009-10-22 Thread Myles Watson
Myles Watson wrote: The attached patch fixes booting for arima/hdama. How should we really fix it? In v3 didn't we just scrap type 2 accesses all together? We can keep the type 2 support code, but the auto detection at run time makes absolutely no sense. The auto detection code is the

Re: [coreboot] PCI config

2009-10-22 Thread Myles Watson
On Thu, Oct 22, 2009 at 9:36 AM, Stefan Reinauer ste...@coresystems.dewrote: Myles Watson wrote: I thought enable was run at the very beginning, before scan, while init was run at the end. Yes. That seems like a hard conversion to make. Why? I thought that some of the PCI

Re: [coreboot] PCI config

2009-10-22 Thread Carl-Daniel Hailfinger
On 22.10.2009 09:57, Stefan Reinauer wrote: Myles Watson wrote: The attached patch fixes booting for arima/hdama. How should we really fix it? In v3 didn't we just scrap type 2 accesses all together? We can keep the type 2 support code, but the auto detection at run time makes

Re: [coreboot] PCI config

2009-10-22 Thread Myles Watson
On Thu, Oct 22, 2009 at 9:45 AM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2...@gmx.net wrote: On 22.10.2009 09:57, Stefan Reinauer wrote: Myles Watson wrote: The attached patch fixes booting for arima/hdama. How should we really fix it? In v3 didn't we just scrap type 2 accesses

[coreboot] PCI config

2009-10-21 Thread Myles Watson
The attached patch fixes booting for arima/hdama. How should we really fix it? In v3 didn't we just scrap type 2 accesses all together? Thanks, Myles Index: svn/src/arch/i386/lib/pci_ops_auto.c === ---