On Mon, Oct 13, 2008 at 3:26 PM, Peter Stuge <[EMAIL PROTECTED]> wrote:
> Corey Osgood wrote:
> > u8 smbus_read_byte(u16 dimm, u8 offset, u16 smbus_io_base)
> ..
> > dimm = (dimm << 1) | 1;
> ..
> > With it, my spd addresses are 0x50, 0x51, etc, without it, they'd
> > be 0xa1, 0xa3, etc. Which
Corey Osgood wrote:
> u8 smbus_read_byte(u16 dimm, u8 offset, u16 smbus_io_base)
..
> dimm = (dimm << 1) | 1;
..
> With it, my spd addresses are 0x50, 0x51, etc, without it, they'd
> be 0xa1, 0xa3, etc. Which would be preferred?
As others have said, the input to this function should be 0x50.
Hi,
0x50 is the actual address. 0xA0 is actual encoded address which starts from
bit1. bit0 indicates if it is R/W operation.
I would prefer to stick with 0x50.
Rudolf
--
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot
Corey Osgood wrote:
I'm working on vt8237 smbus in v3, and I had a quick question, mostly
for Rudolf Marek and Bari, but feel free to jump in with your 2 cents:
u8 smbus_read_byte(u16 dimm, u8 offset, u16 smbus_io_base)
{
u8 val;
printk(BIOS_SPEW, "SMBus Read from DIMM
On Mon, Oct 13, 2008 at 11:36 AM, Corey Osgood <[EMAIL PROTECTED]> wrote:
> I'm working on vt8237 smbus in v3, and I had a quick question, mostly for
> Rudolf Marek and Bari, but feel free to jump in with your 2 cents:
>
> u8 smbus_read_byte(u16 dimm, u8 offset, u16 smbus_io_base)
> {
> u8 val;
I'm working on vt8237 smbus in v3, and I had a quick question, mostly for
Rudolf Marek and Bari, but feel free to jump in with your 2 cents:
u8 smbus_read_byte(u16 dimm, u8 offset, u16 smbus_io_base)
{
u8 val;
printk(BIOS_SPEW, "SMBus Read from DIMM %1x at address 0x%4x\n",
6 matches
Mail list logo
