[coreboot] Re: Copy-first platform additions (was: Re: Re: Proposal to add teeth to our Gerrit guidelines)

2019-11-06 Thread Patrick Georgi via coreboot
On Wed, Nov 06, 2019 at 12:39:59PM +0100, Nico Huber wrote: > > Some of the mega patches are copies of a predecessor chip (with the > > minimum amount of changes to integrate it in the build), that are > > then modified to fit the new chip. > > Ack. I think that is a problem. If this procedure is

[coreboot] Re: Copy-first platform additions (was: Re: Re: Proposal to add teeth to our Gerrit guidelines)

2019-11-07 Thread Nico Huber
Hi again all, I took part in (half of) a leadership meeting last night, and I was impressed by two things that I didn't expect: 1. Few people seem to take the might of Git into account. We have a tool that can significantly increase the efficiency of development and can help to preempt bugs

[coreboot] Re: Copy-first platform additions (was: Re: Re: Proposal to add teeth to our Gerrit guidelines)

2019-11-07 Thread Patrick Georgi via coreboot
On Thu, Nov 07, 2019 at 12:05:44PM +0100, Nico Huber wrote: > 1. Few people seem to take the might of Git into account. We have a Git is rather limited in some respects: For example it has no notion of a copy (except by using interesting merge hacks: create a branch where you rename, merge the two

[coreboot] Re: Copy-first platform additions (was: Re: Re: Proposal to add teeth to our Gerrit guidelines)

2019-11-07 Thread Nico Huber
Hi Patrick, thank you for your response. I really appreciate that somebody helps to clear things up. On 07.11.19 15:58, Patrick Georgi wrote: > On Thu, Nov 07, 2019 at 12:05:44PM +0100, Nico Huber wrote: >> 1. Few people seem to take the might of Git into account. We have a > Git is rather limite

[coreboot] Re: Copy-first platform additions (was: Re: Re: Proposal to add teeth to our Gerrit guidelines)

2019-11-07 Thread Nico Huber
On 07.11.19 12:05, Nico Huber wrote: > 1. Few people seem to take the might of Git into account. We have a >tool that can significantly increase the efficiency of development >and can help to preempt bugs. But many people would accept a process >that breaks Git benefits. Especially with

[coreboot] Re: Copy-first platform additions (was: Re: Re: Proposal to add teeth to our Gerrit guidelines)

2019-11-08 Thread Julien Viard de Galbert
On Fri, Nov 08, 2019 at 12:45:39AM +0100, Nico Huber wrote: > On 07.11.19 12:05, Nico Huber wrote: > > 1. Few people seem to take the might of Git into account. We have a > >tool that can significantly increase the efficiency of development > >and can help to preempt bugs. But many people w

[coreboot] Re: Copy-first platform additions (was: Re: Re: Proposal to add teeth to our Gerrit guidelines)

2019-11-19 Thread Julius Werner
Looks like I'm too late to the party here, but I just read this and wanted to also come out in support of what Nico said. I think the endless copy&pasting that seems to have happened 5-10 years ago in coreboot left us with pretty awful maintainability consequences and we should (and I think we most

[coreboot] Re: Copy-first platform additions (was: Re: Re: Proposal to add teeth to our Gerrit guidelines)

2019-11-19 Thread David Hendricks
> I think most of this is changing and has changed already (like Patrick > said it happened gradually) -- these days most chipset code for both > x86 and Arm is in src/soc/vendor/common, and most new mainboards use > the variant system. Whenever I see a patch of someone copy&pasting a > lot of code