[coreboot] Re: FsptUpd.h: No such file or directory - compilation terminated - Error 1

2021-06-26 Thread James Feeney
On 6/24/21 8:18 AM, Matt DeVillier wrote: > I don't see the problem here TBH. There's no issue, security or > otherwise, with coreboot having fmap regions within the IFD BIOS > region that are not contiguous. Alignment requirements (eg, 64k) for > some regions practically guarantee this. > > ifdto

[coreboot] Re: FsptUpd.h: No such file or directory - compilation terminated - Error 1

2021-06-24 Thread Matt DeVillier
I don't see the problem here TBH. There's no issue, security or otherwise, with coreboot having fmap regions within the IFD BIOS region that are not contiguous. Alignment requirements (eg, 64k) for some regions practically guarantee this. ifdtool complained here because a manually generated flashm

[coreboot] Re: FsptUpd.h: No such file or directory - compilation terminated - Error 1

2021-06-24 Thread James Feeney
On 6/24/21 12:48 AM, James Feeney wrote: > On 6/23/21 8:59 PM, James Feeney wrote: >> On 6/23/21 6:51 PM, Matt DeVillier wrote: >>> On Wed, Jun 23, 2021 at 4:36 PM James Feeney wrote: On 6/23/21 1:40 PM, Matt DeVillier wrote: > I'm an idiot and made a stupid math error when I calcula

[coreboot] Re: FsptUpd.h: No such file or directory - compilation terminated - Error 1

2021-06-23 Thread James Feeney
On 6/23/21 8:59 PM, James Feeney wrote: > On 6/23/21 6:51 PM, Matt DeVillier wrote: >> On Wed, Jun 23, 2021 at 4:36 PM James Feeney wrote: >>> >>> On 6/23/21 1:40 PM, Matt DeVillier wrote: I'm an idiot and made a stupid math error when I calculated the size of the SI_BIOS region. 0xF7F00

[coreboot] Re: FsptUpd.h: No such file or directory - compilation terminated - Error 1

2021-06-23 Thread James Feeney
On 6/23/21 6:51 PM, Matt DeVillier wrote: > On Wed, Jun 23, 2021 at 4:36 PM James Feeney wrote: >> >> On 6/23/21 1:40 PM, Matt DeVillier wrote: >>> I'm an idiot and made a stupid math error when I calculated the size >>> of the SI_BIOS region. 0xF7F000 - 0x1000 is 0xF7E000, not 0xF6F000. >>> >>> h

[coreboot] Re: FsptUpd.h: No such file or directory - compilation terminated - Error 1

2021-06-23 Thread Matt DeVillier
On Wed, Jun 23, 2021 at 4:36 PM James Feeney wrote: > > On 6/23/21 1:40 PM, Matt DeVillier wrote: > > I'm an idiot and made a stupid math error when I calculated the size > > of the SI_BIOS region. 0xF7F000 - 0x1000 is 0xF7E000, not 0xF6F000. > > > > https://review.coreboot.org/c/coreboot/+/55815

[coreboot] Re: FsptUpd.h: No such file or directory - compilation terminated - Error 1

2021-06-23 Thread James Feeney
On 6/23/21 1:40 PM, Matt DeVillier wrote: > I'm an idiot and made a stupid math error when I calculated the size > of the SI_BIOS region. 0xF7F000 - 0x1000 is 0xF7E000, not 0xF6F000. > > https://review.coreboot.org/c/coreboot/+/55815 fixes it > Ha! I was a little suspicious of the suggestive pat

[coreboot] Re: FsptUpd.h: No such file or directory - compilation terminated - Error 1

2021-06-23 Thread Matt DeVillier
I'm an idiot and made a stupid math error when I calculated the size of the SI_BIOS region. 0xF7F000 - 0x1000 is 0xF7E000, not 0xF6F000. https://review.coreboot.org/c/coreboot/+/55815 fixes it On Wed, Jun 23, 2021 at 1:48 PM James Feeney wrote: > > On 6/22/21 11:13 PM, Matt DeVillier wrote: > >

[coreboot] Re: FsptUpd.h: No such file or directory - compilation terminated - Error 1

2021-06-23 Thread James Feeney
On 6/22/21 11:13 PM, Matt DeVillier wrote: > On Tue, Jun 22, 2021 at 10:59 PM James Feeney wrote: >> >> On 6/22/21 4:32 PM, Matt DeVillier wrote: >>> I'm not sure why you enabled so many things not selected in my >>> defconfig -- that's your issue. >> >> Ha! Quite! Bit of a learning curve, thoug

[coreboot] Re: FsptUpd.h: No such file or directory - compilation terminated - Error 1

2021-06-22 Thread Matt DeVillier
On Tue, Jun 22, 2021 at 10:59 PM James Feeney wrote: > > On 6/22/21 4:32 PM, Matt DeVillier wrote: > > I'm not sure why you enabled so many things not selected in my > > defconfig -- that's your issue. > > Ha! Quite! Bit of a learning curve, though... > > Ok, thanks for the clarifications - lots

[coreboot] Re: FsptUpd.h: No such file or directory - compilation terminated - Error 1

2021-06-22 Thread James Feeney
On 6/22/21 4:32 PM, Matt DeVillier wrote: > I'm not sure why you enabled so many things not selected in my > defconfig -- that's your issue. Ha! Quite! Bit of a learning curve, though... Ok, thanks for the clarifications - lots of things I do not need. > Use: > > CONFIG_VENDOR_GOOGLE=y > CONF

[coreboot] Re: FsptUpd.h: No such file or directory - compilation terminated - Error 1

2021-06-22 Thread Matt DeVillier
I'm not sure why you enabled so many things not selected in my defconfig -- that's your issue. Use: CONFIG_VENDOR_GOOGLE=y CONFIG_PAYLOAD_CONFIGFILE="../configubootJun14-2" # CONFIG_POST_DEVICE is not set CONFIG_BOARD_GOOGLE_CASTA=y CONFIG_INCLUDE_NHLT_BLOBS=y CONFIG_NEED_IFWI=y CONFIG_HAVE_IFD_BI

[coreboot] Re: FsptUpd.h: No such file or directory - compilation terminated - Error 1

2021-06-22 Thread James Feeney
defconfig below, but: $ grep -i fsp_car defconfig CONFIG_USE_APOLLOLAKE_FSP_CAR=y $ grep -i fsp_car .config CONFIG_USE_APOLLOLAKE_FSP_CAR=y CONFIG_FSP_CAR=y Hmm - I must have done that because it sounded "safe". Which of these choices is "correct"? src/soc/intel/apollolake/Kconfig choice

[coreboot] Re: FsptUpd.h: No such file or directory - compilation terminated - Error 1

2021-06-22 Thread Matt DeVillier
FSP-T isn't used for APL/GLK Chromebooks. Sounds like your .config is selecting something it shouldn't. run `make savedefconfig` then post the contents of the defconfig. Possible CONFIG_USE_APOLLOLAKE_FSP_CAR is selected when it shouldn't be. On Mon, Jun 21, 2021 at 9:17 PM James Feeney wrote: >