[coreboot] Re: libgfxinit quick starter guide

2020-03-15 Thread Nico Huber
Hi Michal, hi Matt, On 15.03.20 06:41, Matt B wrote: > You probably want to speak with Nico. He's a libgfxinit expert afaik. thanks for the heads up :) > On Wed, Mar 11, 2020 at 9:45 AM Michal Zygowski > wrote: > >> Particularly I would like to implement Braswell support for native >> graphics

[coreboot] Re: libgfxinit quick starter guide

2020-03-15 Thread Nico Huber
On 15.03.20 20:37, Nico Huber wrote: >> On Wed, Mar 11, 2020 at 9:45 AM Michal Zygowski >> wrote: >> I see the programming manuals from Intel >>> are in place: >>> https://01.org/linuxgraphics/documentation/hardware-specification-prms > > Alas, this is a pitfall for Braswell. The only part that ma

[coreboot] Re: libgfxinit quick starter guide

2020-03-16 Thread Michal Zygowski
Hi Nico, Thank you for your extensive answer. That helps a lot. Regarding the registers description, maybe EDS or other documents have better situation? I have Braswell EDS so i can check it, but if you have any documents that describe display registers for Braswell, let me know which ID it is so

[coreboot] Re: libgfxinit quick starter guide

2020-03-17 Thread Nico Huber
Hi, On 16.03.20 13:01, Michal Zygowski wrote: > Regarding the registers description, maybe EDS or other documents have > better situation? I have Braswell EDS so i can check it, but if you have > any documents that describe display registers for Braswell, let me know > which ID it is so I can get

[coreboot] Re: libgfxinit quick starter guide

2020-03-27 Thread Michal Zygowski
Another question about libgfxinit. Up till Skylake the libgfxinit worked great for me, however after enabling it on a Kaby Lake platform I noticed the colors are flipped. I.e. when using VGA ROM the bootsplash image is correctly displayed in RGB, but when using libgfxinit and hires FB the colors a

[coreboot] Re: libgfxinit quick starter guide

2020-03-27 Thread Nico Huber
Hi Michal, On 27.03.20 15:49, Michal Zygowski wrote: > Another question about libgfxinit. > > Up till Skylake the libgfxinit worked great for me, however after > enabling it on a Kaby Lake platform I noticed the colors are flipped. > I.e. when using VGA ROM the bootsplash image is correctly displa

[coreboot] Re: libgfxinit quick starter guide

2020-03-28 Thread Michal Zygowski
Thanks for pointers Nico. I used the same picture laoding code and the same image. The only thing that changed was the graphics initialization: VGA ROM vs libgfxinit. I have used SeaBIOS with the same bootsplash image. AFAIK it searches for a compatible (for given image resolution) VESA mode and

[coreboot] Re: libgfxinit quick starter guide

2020-03-28 Thread Nico Huber
On 28.03.20 11:43, Michal Zygowski wrote: > I used the same picture laoding code and the same image. The only thing > that changed was the graphics initialization: VGA ROM vs libgfxinit. If you want to change the encoding (I never tried this) PLANE_CTL bit 20 seems to do the trick. For older gener

[coreboot] Re: libgfxinit quick starter guide

2020-03-30 Thread Michal Zygowski
On 3/29/20 1:54 AM, Nico Huber wrote: > On 28.03.20 11:43, Michal Zygowski wrote: >> I used the same picture laoding code and the same image. The only thing >> that changed was the graphics initialization: VGA ROM vs libgfxinit. > If you want to change the encoding (I never tried this) PLANE_CTL b

[coreboot] Re: libgfxinit quick starter guide

2020-06-22 Thread Michal Zygowski
Hi Nico, I found some time to get back to the topic and actually I am clueless... What I have tried: 1. Use libgfxinit to initialize graphics in coreboot and display the bootsplash image in JPG and BMP formats. JPG has the mentioned issue with colors, while BMP doesn't. 2. Compared the libgfxini

[coreboot] Re: libgfxinit quick starter guide

2020-06-22 Thread Nico Huber
Hi Michal, On 22.06.20 10:29, Michal Zygowski wrote: > 3. Used VGA option rom to initialize graphics and display the bootsplash > in coreboot and SeaBIOS as well. What surprised me is that coreboot > displayed the bootsplash incorrectly (the same color issues as with > libgfxinit) while SeaBIOS di

[coreboot] Re: libgfxinit quick starter guide

2020-06-23 Thread Michal Zygowski
Hi Nico, On 22.06.2020 23:40, Nico Huber wrote: > Hi Michal, > > On 22.06.20 10:29, Michal Zygowski wrote: >> 3. Used VGA option rom to initialize graphics and display the bootsplash >> in coreboot and SeaBIOS as well. What surprised me is that coreboot >> displayed the bootsplash incorrectly (the

[coreboot] Re: libgfxinit quick starter guide

2020-06-23 Thread Nico Huber
On 23.06.20 16:51, Michal Zygowski wrote: >>> Now the only thing that comes to my mind are the VGA interrupts, because >>> SeaBIOS has more complete interrupt services than coreboot. Any comments >>> or suggestions on that? I think my next step would be to trace all INT >>> 10h and compare the diff

[coreboot] Re: libgfxinit quick starter guide

2020-06-24 Thread Michal Zygowski
Hi Nico, On 6/23/20 7:55 PM, Nico Huber wrote: > On 23.06.20 16:51, Michal Zygowski wrote: Now the only thing that comes to my mind are the VGA interrupts, because SeaBIOS has more complete interrupt services than coreboot. Any comments or suggestions on that? I think my next step w

[coreboot] Re: libgfxinit quick starter guide

2020-06-24 Thread Peter Stuge
Michal Zygowski wrote: > when VGA option rom is used, SeaBIOS finds the mode it fits the bootsplash > resolution and bpp. Additionaly the display area is adjusted to cover whole > screen, i.e. when using 1024x768 bootsplash on 1920x1080 screen the > bootsplash covers whole screen, Stretching the g

[coreboot] Re: libgfxinit quick starter guide

2020-06-24 Thread Nico Huber
On 24.06.20 15:25, Peter Stuge wrote: > Michal Zygowski wrote: >> when VGA option rom is used, SeaBIOS finds the mode it fits the bootsplash >> resolution and bpp. Additionaly the display area is adjusted to cover whole >> screen, i.e. when using 1024x768 bootsplash on 1920x1080 screen the >> boots

[coreboot] Re: libgfxinit quick starter guide

2020-06-25 Thread Michal Zygowski
Hi Nico, Peter, On 6/24/20 8:50 PM, Nico Huber wrote: > On 24.06.20 15:25, Peter Stuge wrote: >> Michal Zygowski wrote: >>> when VGA option rom is used, SeaBIOS finds the mode it fits the bootsplash >>> resolution and bpp. Additionaly the display area is adjusted to cover whole >>> screen, i.e. wh

[coreboot] Re: libgfxinit quick starter guide

2020-06-25 Thread Nico Huber
Hi Michal, On 25.06.20 10:56, Michal Zygowski wrote: > One will have different max > resolution display and everything will fall apart and look differently. > AFAIK libgfxinit reads out the display information (EDID right?) so it > is possible to calculate the scalers. that's one use case for bel