[coreboot] Re: ramstage/x86emu doesn't build

2019-05-02 Thread Nico Huber
On 02.05.19 08:10, Martin Kepplinger wrote: > On 25.04.19 12:23, Patrick Georgi via coreboot wrote: >> There was some recent cleanup on console.h includes that makes printk >> only visible where we thought it was needed. >> A change to add an include for console/console.h to resolve the issue >> he

[coreboot] Re: ramstage/x86emu doesn't build

2019-05-01 Thread Martin Kepplinger
On 25.04.19 12:23, Patrick Georgi via coreboot wrote: > There was some recent cleanup on console.h includes that makes printk > only visible where we thought it was needed. > A change to add an include for console/console.h to resolve the issue > here. Cc'ing Elyes since that's his effort. > > As

[coreboot] Re: ramstage/x86emu doesn't build

2019-04-25 Thread Patrick Georgi via coreboot
There was some recent cleanup on console.h includes that makes printk only visible where we thought it was needed. A change to add an include for console/console.h to resolve the issue here. Cc'ing Elyes since that's his effort. As you correctly noticed, x86emu isn't build-tested by default: If yo

[coreboot] Re: ramstage/x86emu doesn't build

2019-04-25 Thread Zeh, Werner
Looks like console.h was removed in https://review.coreboot.org/c/coreboot/+/32214 We had a few such "accidents" in the past few days. @Elyes: want to fix? Werner - Hi, Before I dig in without knowing the