Hi fellow coreboot developers, it was pointed out to me that I didn't do exactly what Chromium developers are used to (i.e. what util/scripts/cross-repo-cherrypick does) when picking patches to flashrom-stable.
The major difference is that I didn't prepend Signed-off-by tags with an `Original-`. My reasoning was that it applies to the work in a patch and not the exact commit. We also don't change these tags when clicking Submit in Gerrit which also triggers a cherry- pick. Prepending the `Original-` to all the tags that are automatically added by Gerrit makes perfect sense to me, OTOH. So here's the question: Is there a particular reason that `cross-repo-cherrypick` prepends the Signed-off-by or is that just done because it treats all tags the same? Cheers, Nico _______________________________________________ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-le...@coreboot.org
