Myles Watson wrote:
Maciej,
Thanks for the patch. I think most of it is ready to be committed.
Index: src/lib/clog2.c
===
--- src/lib/clog2.c (revision 4869)
+++ src/lib/clog2.c (working copy)
@@ -7,6 +7,8 @@
/* Assume
-Original Message-
From: Stefan Reinauer [mailto:ste...@coresystems.de]
Sent: Wednesday, October 28, 2009 4:25 AM
To: Myles Watson
Cc: 'Maciej Pijanka'; coreboot@coreboot.org
Subject: Re: [coreboot] small patch for prototypes and unused variables
Myles Watson wrote:
Maciej
Myles Watson wrote:
-Original Message-
From: Stefan Reinauer [mailto:ste...@coresystems.de]
Sent: Wednesday, October 28, 2009 4:25 AM
To: Myles Watson
Cc: 'Maciej Pijanka'; coreboot@coreboot.org
Subject: Re: [coreboot] small patch for prototypes and unused variables
Myles
Hello
as Uwe sugested, i checked abuild -a, and found one romcc prototype
problem, fixed patch in attachment.
best regards
Maciej
--
Maciej Pijanka, PLD-Linux Developer, Reg Linux user #133161
POE/Perl user
coreboot-4869-prototypes-updated.patch
Description: Binary data
--
coreboot mailing
Maciej,
Thanks for the patch. I think most of it is ready to be committed.
Index: src/lib/clog2.c
===
--- src/lib/clog2.c (revision 4869)
+++ src/lib/clog2.c (working copy)
@@ -7,6 +7,8 @@
/* Assume 8 bits per byte */
On 27/10/2009, Myles Watson myle...@gmail.com wrote:
Maciej,
Thanks for the patch. I think most of it is ready to be committed.
Index: src/lib/clog2.c
===
--- src/lib/clog2.c (revision 4869)
+++ src/lib/clog2.c (working
On Tue, Oct 27, 2009 at 7:32 AM, Maciej Pijanka maciej.pija...@gmail.comwrote:
On 27/10/2009, Myles Watson myle...@gmail.com wrote:
Maciej,
Thanks for the patch. I think most of it is ready to be committed.
Index: src/lib/clog2.c
On 27/10/2009, Myles Watson myle...@gmail.com wrote:
On Tue, Oct 27, 2009 at 7:32 AM, Maciej Pijanka
maciej.pija...@gmail.comwrote:
On 27/10/2009, Myles Watson myle...@gmail.com wrote:
Maciej,
Thanks for the patch. I think most of it is ready to be committed.
Index:
Acked-by: Myles Watson myle...@gmail.com
Thanks,
Myles
--
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot
On Tue, Oct 27, 2009 at 8:20 AM, Myles Watson myle...@gmail.com wrote:
Acked-by: Myles Watson myle...@gmail.com
Rev 4871.
Thanks,
Myles
--
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot
In v3 IIRC we decided on an include file, lib.h, which had these sorts
of nuisance prototypes.
ron
--
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot
On Tue, Oct 27, 2009 at 8:58 AM, ron minnich rminn...@gmail.com wrote:
In v3 IIRC we decided on an include file, lib.h, which had these sorts
of nuisance prototypes.
Something like that would be fine with me, but since we'd do it just to do
it, not to make the code cleaner, maybe it's just as
On Tue, Oct 27, 2009 at 8:17 AM, Myles Watson myle...@gmail.com wrote:
Something like that would be fine with me, but since we'd do it just to do
it, not to make the code cleaner, maybe it's just as good to put the
prototypes by the functions.
In the case of that function you need a proto
On Tue, Oct 27, 2009 at 10:10 AM, ron minnich rminn...@gmail.com wrote:
On Tue, Oct 27, 2009 at 8:17 AM, Myles Watson myle...@gmail.com wrote:
Something like that would be fine with me, but since we'd do it just to
do
it, not to make the code cleaner, maybe it's just as good to put the
Hello
see patch in attachment,
best regards
Maciej
--
Maciej Pijanka, PLD-Linux Developer, Reg Linux user #133161
POE/Perl user
coreboot-4869-prototypes.patch
Description: Binary data
--
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot
15 matches
Mail list logo
