Re: [coreutils] [PATCH] tests: silence 'make syntax-check'

On 09/08/10 21:59, Eric Blake wrote: * gl/tests/test-rand-isaac.c (main): Avoid warnings from syntax-check. --- Committing as obvious. The set_program_name hack is borrowed liberally from test-ino-map.c. gl/tests/test-rand-isaac.c |3 ++- 1 files changed, 2 insertions(+), 1

Re: [coreutils] ignore-value.h considered harmful

On 08/10/2010 09:56 PM, Paul Eggert wrote: Re that recent change to sort.c to insert a call to ignore_value. This ignore_value business is ugly, and runs against the spirit of the GNU coding standards: Don't make the program ugly to placate lint. Please don't insert any casts to

Re: [coreutils] [PATCH] sort: -R now uses less memory on long lines with internal NULs

On 05/08/10 00:12, Paul Eggert wrote: @@ -2038,41 +2027,117 @@ static int compare_random (char *restrict texta, size_t lena, char *restrict textb, size_t lenb) { - int diff; + uint32_t dig[2][MD5_DIGEST_SIZE / sizeof (uint32_t)]; I know this is just moved code but it