Re: [coreutils] [PATCH 2/2] stat: print timestamps to full resolution

2010-10-01 Thread Jim Meyering
Pádraig Brady wrote: On 01/10/10 00:32, Eric Blake wrote: * src/stat.c (epoch_time): New function. (print_stat): Use it for %[WXYZ]. * NEWS: Document this. * tests/touch/60-seconds: Adjust test to match. --- It bugs me that %x has more information than %X in 'stat --format', especially,

Re: [coreutils] [PATCH 1/2] stat: support printing birthtime

2010-10-01 Thread Jim Meyering
Eric Blake wrote: * src/stat.c (print_stat): New %w and %W formats. (do_stat): Include %w in verbose format. (usage): Document them. * doc/coreutils.texi (stat invocation): Likewise. * NEWS: Likewise. Suggested by Andre Osku Schmidt. --- I've tested that this works on cygwin. On Fedora

Re: [coreutils] [PATCH] maint: suppress a bogus used-uninitialized warning in tr.c

2010-10-01 Thread Pádraig Brady
On 01/10/10 10:24, Jim Meyering wrote: Without this, I'd get cc1: warnings being treated as errors tr.c: In function 'main': tr.c:1400: warning: 'char_to_repeat' may be used uninitialized in this function There must have been some limitation with my compiler gcc (GCC) 4.4.1

Re: [coreutils] [PATCH 1/2] stat: support printing birthtime

2010-10-01 Thread Eric Blake
On 10/01/2010 09:11 AM, Jim Meyering wrote: Eric Blake wrote: ... +# Whether birthtime is supported or not, it better not change even when +# [acm]time are modified. :) +touch a || fail=1 +btime=$(stat --format %W a) || fail=1 +atime=$(stat --format %X a) || fail=1 +mtime=$(stat --format %Y a)

[coreutils] [PATCH] maint: update sample test template

2010-10-01 Thread Eric Blake
* tests/sample-test: Recommend modern idiom. --- tests/sample-test |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/tests/sample-test b/tests/sample-test index 85a61cf..85b779f 100644 --- a/tests/sample-test +++ b/tests/sample-test @@ -16,12 +16,7 @@ # You should

Re: [coreutils] stat and SELinux context

2010-10-01 Thread Pádraig Brady
On 01/10/10 16:49, Eric Blake wrote: In working on the birthtime stat support, I noticed that we documented that -Z has been removed, on the grounds that you can get at it with --format=%C (although NEWS didn't mention the replacement). Would it make sense to patch the default stat output

Re: [coreutils] [PATCHv2] stat: print SELinux context when available

2010-10-01 Thread Jim Meyering
Eric Blake wrote: * src/stat.c (default_format): Include context when present. * NEWS: Update blurb explaining the replacement for -Z. --- Definitely nicer than the first attempt, but still controversial on whether we want to do this at all. I'm 70:30 for (I use Fedora's stat -Z regularly,

Re: [coreutils] [PATCH] stat: optimize and translate default format strings

2010-10-01 Thread Jim Meyering
Eric Blake wrote: * src/stat.c (main): Hoist default format computation out of loop. (do_statfs, do_stat): Move default format generation... (default_format): ...into new function. Allocate the result in pieces, rather than repeating mostly-similar chunks. Allow translation of verbose

Re: [coreutils] [PATCH] maint: update sample test template

2010-10-01 Thread Jim Meyering
Eric Blake wrote: * tests/sample-test: Recommend modern idiom. --- tests/sample-test |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/tests/sample-test b/tests/sample-test index 85a61cf..85b779f 100644 --- a/tests/sample-test +++ b/tests/sample-test @@

Re: [coreutils] [PATCH] stat: optimize and translate default format strings

2010-10-01 Thread Eric Blake
On 10/01/2010 02:44 PM, Jim Meyering wrote: Eric Blake wrote: * src/stat.c (main): Hoist default format computation out of loop. This one should be uncontroversial, but just to be safe: OK to push? Yes. Thank you for the factoring. Did you do any before/after testing, to be sure that

Re: [coreutils] [PATCH] maint: update sample test template

2010-10-01 Thread Eric Blake
On 10/01/2010 03:00 PM, Jim Meyering wrote: -if test $VERBOSE = yes; then - set -x - FIXME --version -fi The VERBOSE=yes - set -x part is handled in init.sh, so it's fine to remove that, but the other, --version-printing part... It's intended to identify the program(s) under test so that

Re: [coreutils] [PATCH] stat: optimize and translate default format strings

2010-10-01 Thread Jim Meyering
Eric Blake wrote: On 10/01/2010 02:44 PM, Jim Meyering wrote: Eric Blake wrote: * src/stat.c (main): Hoist default format computation out of loop. This one should be uncontroversial, but just to be safe: OK to push? Yes. Thank you for the factoring. Did you do any before/after testing, to

bug#7142: coreutils on Solaris 10(x86) 09/10

2010-10-01 Thread Clemens Brogi
Hi you cannot compile gnu-coreutils on the latest Solaris x86 10 (09/10), since the interface of futimens has changed. it is now: extern int futimens(int, const struct timespec[2]); System-Information uname -a: SunOS barsch 5.10 Generic_142910-17 i86pc i386 i86pc Solaris I don't know if this

bug#7142: coreutils on Solaris 10(x86) 09/10

2010-10-01 Thread Jim Meyering
Clemens Brogi wrote: you cannot compile gnu-coreutils on the latest Solaris x86 10 (09/10), since the interface of futimens has changed. it is now: extern int futimens(int, const struct timespec[2]); System-Information uname -a: SunOS barsch 5.10 Generic_142910-17 i86pc i386 i86pc Solaris

bug#7142: coreutils on Solaris 10(x86) 09/10

2010-10-01 Thread Eric Blake
On 10/01/2010 01:22 AM, Clemens Brogi wrote: Hi you cannot compile gnu-coreutils on the latest Solaris x86 10 (09/10), Which version of coreutils? For example, there was a known bug where in 2007, coreutils 6.9 used the name 'futimens' internally for a different purpose than what was later

bug#7099: mbsalign.c old c compiler complains about variables defined inside code

2010-10-01 Thread Pádraig Brady
On 24/09/10 22:38, Pádraig Brady wrote: On 24/09/10 21:15, Suhan Andrei wrote: Hi Just wanted to let you know there are some errors when using old compiler ( gcc -v Reading specs from /usr/lib/gcc-lib/i386-redhat-linux/egcs-2.91.66/specs gcc version egcs-2.91.66 19990314/Linux (egcs-1.1.2

bug#7142: coreutils on Solaris 10(x86) 09/10

2010-10-01 Thread Eric Blake
[Let's keep the list in the loop] On 10/01/2010 06:44 AM, Clemens Brogi wrote: Eric Blake wrote: On 10/01/2010 01:22 AM, Clemens Brogi wrote: Hi you cannot compile gnu-coreutils on the latest Solaris x86 10 (09/10), Hi sorry this was my fault. I used coreutils coming with the new Solaris

bug#7142: coreutils on Solaris 10(x86) 09/10

2010-10-01 Thread Jim Meyering
Clemens Brogi wrote: Jim Meyering wrote: Clemens Brogi wrote: you cannot compile gnu-coreutils on the latest Solaris x86 10 (09/10), since the interface of futimens has changed. it is now: extern int futimens(int, const struct timespec[2]); System-Information uname -a: SunOS barsch 5.10