[PATCH] maint: correct formatting style in a header

2011-03-28 Thread Jim Meyering
FYI, From fde07ff436ef19cc85a8bb626535cc18fdb9d588 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Mon, 28 Mar 2011 07:57:51 +0200 Subject: [PATCH] maint: correct formatting style in a header * src/find-mount-point.h: Move * to where it belongs. Move const, too. *

Re: [PATCH] copy: adjust fiemap handling of sparse files

2011-03-28 Thread Pádraig Brady
On 18/03/11 16:04, Pádraig Brady wrote: On 18/03/11 13:48, Chris Mason wrote: Excerpts from Pádraig Brady's message of 2011-03-18 09:19:44 -0400: On 18/03/11 12:04, Chris Mason wrote: Excerpts from Jim Meyering's message of 2011-03-18 07:52:43 -0400: Pádraig Brady wrote: So am I right in

bug#8370: RFC: cp --no-preserve=contents

2011-03-28 Thread Pádraig Brady
On 28/03/11 21:55, Eric Blake wrote: cp --attributes-only is great for preserving all metadata attributes without corrupting contents, but what if I want to preserve only some of the metadata (for example, copying SELinux context but _not_ timestamps or content)? It seems like

bug#8359: [PATCH] Unit tests: Properly detect whether SELinux is enabled or not.

2011-03-28 Thread Mathieu Bridon
The unit tests would run ls to see if the files had an SELinux context, and would assume SELinux is enabled if they did. This is not ideal, and can cause test failures in some environments: https://bugzilla.redhat.com/show_bug.cgi?id=573111#c26 The problem in the case of the above bug report

bug#8359: [PATCH] Unit tests: Properly detect whether SELinux is enabled or not.

2011-03-28 Thread Jim Meyering
Mathieu Bridon wrote: The unit tests would run ls to see if the files had an SELinux context, and would assume SELinux is enabled if they did. This is not ideal, and can cause test failures in some environments: https://bugzilla.redhat.com/show_bug.cgi?id=573111#c26 The problem in the

bug#8359: [PATCH] Unit tests: Properly detect whether SELinux is enabled or not.

2011-03-28 Thread Mathieu Bridon
On Mon, 2011-03-28 at 09:54 +0200, Jim Meyering wrote: Mathieu Bridon wrote: [... snip ...] A better way to test if SELinux is enabled is to search for the SELinux filesystem (see the above bug report). This is what this commit does. Thank you for the diagnosis and patch. However, I can't

bug#8359: [PATCH] Unit tests: Properly detect whether SELinux is enabled or not.

2011-03-28 Thread Jim Meyering
Mathieu Bridon wrote: On Mon, 2011-03-28 at 09:54 +0200, Jim Meyering wrote: Mathieu Bridon wrote: [... snip ...] A better way to test if SELinux is enabled is to search for the SELinux filesystem (see the above bug report). This is what this commit does. Thank you for the diagnosis and

bug#8370: RFC: cp --no-preserve=contents

2011-03-28 Thread Eric Blake
cp --attributes-only is great for preserving all metadata attributes without corrupting contents, but what if I want to preserve only some of the metadata (for example, copying SELinux context but _not_ timestamps or content)? It seems like --attributes-only would be a great synonym for