Pádraig Brady wrote:
> On 19/06/11 14:31, Jim Meyering wrote:
>> Do not search in "", the system default directory.
>
> s/directory/search path/
>
> Otherwise looks good.
Thanks. Pushed with that correction.
Stefano Lattarini wrote:
> Subject: [PATCH 2/2] tests: avoid extra forks in the testsuite
>
> * tests/shell-or-perl: Prefer the `read' builtin over `grep' to
> look at the shebang line of test scripts. Since `read' is a
> special builtin, it might abort the whole program upon failures,
> so add ex
Thank you!
That patch looks fine modulo two typos.
I'm folding in these corrections and have adjusted the
grammar in the commit log (included below).
diff --git a/tests/shell-or-perl b/tests/shell-or-perl
index ff92009..08604eb 100644
--- a/tests/shell-or-perl
+++ b/tests/shell-or-perl
@@ -1,7 +1,
On 19/06/11 14:31, Jim Meyering wrote:
> Do not search in "", the system default directory.
s/directory/search path/
Otherwise looks good.
thanks,
Pádraig.
Pádraig Brady wrote:
> On 19/06/11 11:52, Jim Meyering wrote:
>> I normally use automake built from the head of "master",
>> but not long ago, it started failing like this:
>>
>> src/Makefile.am:141: error: `pkglibdir' is not a legitimate directory \
>> for `PROGRAMS'
>>
>> That variable
On 19/06/11 11:52, Jim Meyering wrote:
> I normally use automake built from the head of "master",
> but not long ago, it started failing like this:
>
> src/Makefile.am:141: error: `pkglibdir' is not a legitimate directory \
> for `PROGRAMS'
>
> That variable determines where we install
I normally use automake built from the head of "master",
but not long ago, it started failing like this:
src/Makefile.am:141: error: `pkglibdir' is not a legitimate directory \
for `PROGRAMS'
That variable determines where we install libstdbuf.so.
One possibility is to change src/Makef
James Youngman wrote:
> On Fri, Jun 17, 2011 at 11:04 AM, Jim Meyering wrote:
>> +# This isn't terribly expensive, but it must not be run under heavy load.
>> +# Since the "very expensive" are already run only with -j1, adding this
>
> "very expensive" tests
>
>> +# test to the list ensures it st