Re: [PATCH] fts: introduce FTS_NOATIME

At least in the case of find it will be simple to expose this information in a useful way to the user: $ find --version find (GNU findutils) 4.4.2 Copyright (C) 2007 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software:

Re: -Werror=suggest-attribute=pure breakage

Pádraig Brady wrote: > $ gcc --version > gcc (GCC) 4.6.0 20110509 (Red Hat 4.6.0-7) > > $ make > test.c:95:1: error: function might be candidate for attribute 'pure' > if it is known to return normally [-Werror=suggest-attribute=pure] > > As far as I can see the advance() function is not pure > as

Re: [PATCH] fts: introduce FTS_NOATIME

Eric Blake wrote: > On 07/08/2011 12:03 PM, Paul Eggert wrote: >> On 07/08/11 10:27, Eric Blake wrote: >>> if O_NOATIME is 0, --noatime should be rejected as an outright >>> impossibility. >>> >>> if O_NOATIME is non-zero, --noatime should enable FTS_NOATIME, but only >>> as a best-effort (that is,

Re: [PATCH] fts: introduce FTS_NOATIME

On 07/08/2011 12:03 PM, Paul Eggert wrote: > On 07/08/11 10:27, Eric Blake wrote: >> if O_NOATIME is 0, --noatime should be rejected as an outright >> impossibility. >> >> if O_NOATIME is non-zero, --noatime should enable FTS_NOATIME, but only >> as a best-effort (that is, the option is silently ig

Re: [PATCH] fts: introduce FTS_NOATIME

On 07/08/11 10:27, Eric Blake wrote: > if O_NOATIME is 0, --noatime should be rejected as an outright > impossibility. > > if O_NOATIME is non-zero, --noatime should enable FTS_NOATIME, but only > as a best-effort (that is, the option is silently ignored where the > kernel is too old), If --noati

Re: [PATCH] fts: introduce FTS_NOATIME

On 07/08/2011 10:55 AM, Jim Meyering wrote: > Eric Blake wrote: >> This gives clients the option to try a non-invasive traversal, >> where merely visiting a directory does not update its timestamp, >> where such is supported by the kernel. >> >> Note that whiteout support and O_NOATIME support are

Re: Bug#294327: [PATCH] doc: note that cp -l creates _hard_ links

Benoît Knecht wrote: > Jim Meyering wrote: >> Benoît Knecht wrote: >> > This fact was already noted in the Texinfo manual, but not in the output >> > of --help. >> > >> > * src/cp.c (usage): As above, for --help. >> > Reported by Jari Aalto in http://bugs.debian.org/294327. >> >> Thank you. >> App

Re: man page "SEE ALSO": prohibit terminating "."

On 08/07/11 16:25, Jim Meyering wrote: > Subject: [PATCH] maint: add syntax-check rule to prohibit "."-terminated "SEE > ALSO" > > * cfg.mk (sc_prohibit_man_see_also_period): Prohibit a period at > the end of the first line after a "SEE ALSO" marker in man/*.x. good idea. cheers, Pádraig.

man page "SEE ALSO": prohibit terminating "."

Pádraig Brady wrote: ... > commit f2dabd68064a3324d08285e0d4f013d6d9cf6191 > Author: Benoît Knecht > Date: Fri Jul 8 14:52:41 2011 +0200 > > doc: don't terminate SEE ALSO sections with a period > > man-pages(7) explicitly says about SEE ALSO sections: "Do not terminate > this with a

[PATCH] doc: list all new file system types recognized by stat -f

FYI I applied this: diff --git a/NEWS b/NEWS index 62262bd..c382200 100644 --- a/NEWS +++ b/NEWS @@ -48,7 +48,7 @@ GNU coreutils NEWS-*- outline -*- cp and ls now support HP-UX 11.11's ACLs, thanks to improved support in gnulib. - stat -f now also recog

Re: [PATCH] doc: don't terminate SEE ALSO sections with a period

pushed. thanks, Pádraig.

[PATCH] doc: don't terminate SEE ALSO sections with a period

man-pages(7) explicitly says about SEE ALSO sections: "Do not terminate this with a period." This is also in line with all the other man pages in coreutils. * man/cat.x: Remove period at the end of the SEE ALSO section. * man/tac.x: Likewise. --- man/cat.x |2 +- man/tac.x |2 +- 2 files

Re: Bug#294327: [PATCH] doc: note that cp -l creates _hard_ links

Jim Meyering wrote: > Benoît Knecht wrote: > > This fact was already noted in the Texinfo manual, but not in the output > > of --help. > > > > * src/cp.c (usage): As above, for --help. > > Reported by Jari Aalto in http://bugs.debian.org/294327. > > Thank you. > Applied with the one-line summary e

Re: Bug#294327: [PATCH] doc: note that cp -l creates _hard_ links

Benoît Knecht wrote: > This fact was already noted in the Texinfo manual, but not in the output > of --help. > > * src/cp.c (usage): As above, for --help. > Reported by Jari Aalto in http://bugs.debian.org/294327. Thank you. Applied with the one-line summary edited to start with "doc:" rather than

-Werror=suggest-attribute=pure breakage

$ gcc --version gcc (GCC) 4.6.0 20110509 (Red Hat 4.6.0-7) $ make test.c:95:1: error: function might be candidate for attribute 'pure' if it is known to return normally [-Werror=suggest-attribute=pure] As far as I can see the advance() function is not pure as it updates the global variable 'pos'