Re: [PATCH] maint: avoid reading lots of data from /dev/urandom

2012-04-24 Thread Jim Meyering
Pádraig Brady wrote: > On Solaris 10 at least you need to use dd iflag=fullblock > to avoid short reads. Also it's relatively slow when > you just want non NUL data as opposed to pseudo random data. > > * cp/fiemap-empty: Convert /dev/zero rather than using /dev/urandom. > * dd/sparse: Likewise.

Re: [PATCH] maint: avoid reading lots of data from /dev/urandom

2012-04-24 Thread Pádraig Brady
On 04/24/2012 11:48 AM, Jim Meyering wrote: > Pádraig Brady wrote: >> On Solaris 10 at least you need to use dd iflag=fullblock >> to avoid short reads. Also it's relatively slow when >> you just want non NUL data as opposed to pseudo random data. >> >> * cp/fiemap-empty: Convert /dev/zero rather

Re: [PATCH] maint: avoid reading lots of data from /dev/urandom

2012-04-24 Thread Bernhard Voelker
On 04/24/2012 01:15 PM, Pádraig Brady wrote: >> With those changes, the affected files are then very compressible. >> > With some file system types/options, won't they occupy far fewer >> > blocks than before? > Good point. > The dd/sparse one could then fail the alloc check. > The fiemap-empty c

Re: [PATCH] maint: avoid reading lots of data from /dev/urandom

2012-04-24 Thread Pádraig Brady
On 04/24/2012 12:53 PM, Bernhard Voelker wrote: > > > On 04/24/2012 01:15 PM, Pádraig Brady wrote: >>> With those changes, the affected files are then very compressible. With some file system types/options, won't they occupy far fewer blocks than before? >> Good point. >> The dd/sparse

Re: Bug#582083: patch for grep --color to non-tty output

2012-04-24 Thread Eric Blake
[adding coreutils] On 04/24/2012 09:43 AM, Jim Meyering wrote: >>> Thanks for the report of the documentation bug and the patch, but the patch >>> (changing the meaning of --color from --color=auto to --color=always) >>> would break existing usage. >>> >>> Currently, people can use --color in an