Re: [PATCH 3/7] build: require Automake >= 1.11.6

On 08/30/2012 02:13 PM, Stefano Lattarini wrote: > Now that we use AM_TESTS_ENVIRONMENT, we should require at least > Automake >= 1.11.2; but since all the Automake version until 1.11.5 > are vulnerable to CVE-2012-3386: > > >

Re: [PATCH 3/7] build: require Automake >= 1.11.6

On 08/30/2012 07:13 PM, Jim Meyering wrote: > Stefano Lattarini wrote: >> Now that we use AM_TESTS_ENVIRONMENT, we should require at least >> Automake >= 1.11.2; but since all the Automake version until 1.11.5 >> are vulnerable to CVE-2012-3386: >> >>

[PATCH 3/7] build: don't use foo_LDADD if there's no foo program

For example, instead of factoring out the extra linker flags needed by 'cp', 'mv' ind 'install' into a '$(copy_LDADD)' variable, factor them out in a '$(copy_ldadd)' variable. Partly a minor cleanup, partly a preparation for future changes. * src/Makefile.am (copy_LDADD): Rename ... (copy_ldadd):

[PATCH 7/7] maint: get rid of obsolete script 'cvsu'

It was useful only back when coreutils used CVS as its version control system. * build-aux/cvsu: Delete. * Makefile.am (EXTRA_DIST): Remove it. Signed-off-by: Stefano Lattarini --- Makefile.am| 1 - build-aux/cvsu | 512 - 2 files ch

[PATCH 4/7] maint: remove unused variable in src/Makefile.am

* src/Makefile.am (editpl): This. Signed-off-by: Stefano Lattarini --- src/Makefile.am | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 63c2b11..235deaa 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -460,8 +460,6 @@ libstdbuf_so_LDADD = libstd

[PATCH 5/7] maint: more uses of $(ASSORT)

* src/Makefile.am (fs-kernel-magic, fs-magic): Here, instead of inlining its expansion "LC_ALL=C sort". Signed-off-by: Stefano Lattarini --- src/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 235deaa..e681ccf 100644 ---

[PATCH 1/7] build: move definition of 'all_programs' in cfg.mk

* Makefile.am: Move definition of target 'all_programs' from here ... * cfg.mk: ... to here, which is the only file where it is used. Signed-off-by: Stefano Lattarini --- Makefile.am | 4 cfg.mk | 6 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/Makefile.am b/Ma

[PATCH 0/7] Minor cleanup and refactoring.

Found these when trying to convert 'src/' to a non-recursive setup. I think they should be simple and uncontroversial enough to go into the repository ASAP. Thanks, Stefano -*-*-*- Stefano Lattarini (7): build: move definition of 'all_programs' in cfg.mk build: some refactorings in cfg.mk

physmem: a new program to report memory information

Hello, Related to the previous sort+memory envvar usage thread: http://thread.gmane.org/gmane.comp.gnu.coreutils.general/3028/focus=3090 . Attached is a suggestion for a tiny command-line program "physmem", that similarly to "nproc", exposes the gnulib functions "physmem_total()" and "physmem_

Re: [PATCH 4/7] tests: avoid use of '-T' in shebang line to enable perl taint mode

Stefano Lattarini wrote: > On 08/30/2012 04:21 PM, Jim Meyering wrote: >> Stefano Lattarini wrote: >>> * tests/rm/fail-eperm: Rename ... >>> * tests/rm/fail-eperm.xpl: ... like this >>> * tests/Makefile.am (TESTS): Adjust. >>> (TEST_EXTENSIONS): New, list '.xpl'. >>> (XPL_TEST_LOGS): New, run a per

Re: [PATCH 4/7] tests: avoid use of '-T' in shebang line to enable perl taint mode

On 08/30/2012 04:21 PM, Jim Meyering wrote: > Stefano Lattarini wrote: >> * tests/rm/fail-eperm: Rename ... >> * tests/rm/fail-eperm.xpl: ... like this >> * tests/Makefile.am (TESTS): Adjust. >> (TEST_EXTENSIONS): New, list '.xpl'. >> (XPL_TEST_LOGS): New, run a perl test in tainted mode. >> * test

Re: sort: new feature: use environment variable to set buffer size

Jim Meyering wrote, On 08/30/2012 05:02 AM: > Pádraig Brady wrote: >> Thanks for the detailed rationale, however >> ... >> >> So currently I'd be 70:30 against adding such a variable. > > Thanks for replying, Pádraig. Those are good points. > Another is that we have a strong aversion to adding >

Re: [PATCH 4/7] tests: avoid use of '-T' in shebang line to enable perl taint mode

Stefano Lattarini wrote: > * tests/rm/fail-eperm: Rename ... > * tests/rm/fail-eperm.xpl: ... like this > * tests/Makefile.am (TESTS): Adjust. > (TEST_EXTENSIONS): New, list '.xpl'. > (XPL_TEST_LOGS): New, run a perl test in tainted mode. > * tests/shell-or-perl: Simplify this script: we no longer

Re: [PATCH] build: enable the 'subdir-objects' Automake option globally

Stefano Lattarini wrote: > On 08/30/2012 04:06 PM, Jim Meyering wrote: >> >> Thanks. That looks fine. >> I adjusted log message wording to this (also removing S-o-b): >> > Thanks. One minor nit (against myself) ... > >> This is not strictly required now (it will be once we make more >> parts

Re: [PATCH] build: enable the 'subdir-objects' Automake option globally

On 08/30/2012 04:06 PM, Jim Meyering wrote: > > Thanks. That looks fine. > I adjusted log message wording to this (also removing S-o-b): > Thanks. One minor nit (against myself) ... > This is not strictly required now (it will be once we make more > parts of the coreutils build system non-re

Re: [PATCH] build: enable the 'subdir-objects' Automake option globally

Stefano Lattarini wrote: > This is not strictly required now (it will be once we make more > parts of the coreutils build system non-recursive), but enabling > it early help to ensure that we don't unwittingly introduce any > incompatibility or subtle breakage that might get to bite us later. > > *

Re: [PATCH] scripts: git commit message hook: prohibit use of "Signed-off-by

Stefano Lattarini wrote: > On 08/30/2012 03:36 PM, Jim Meyering wrote: >> Stefano Lattarini wrote: >>> Jim Meyering wrote: I noticed a lot of Signed-off-by: lines in Stefano's series. This makes our no-S-o-b policy more apparent: >> ... + $buf =~ /^ *Signed-off-by:/i +

Re: [PATCH] scripts: git commit message hook: prohibit use of "Signed-off-by

On 08/30/2012 03:36 PM, Jim Meyering wrote: > Stefano Lattarini wrote: >> Jim Meyering wrote: >>> >>> I noticed a lot of Signed-off-by: lines in Stefano's series. >>> This makes our no-S-o-b policy more apparent: > ... >>> + $buf =~ /^ *Signed-off-by:/i >>> +and return q(do not use "Signed-off

Re: [PATCH] scripts: git commit message hook: prohibit use of "Signed-off-by

Stefano Lattarini wrote: ... > Or better again, those "Signed-off-by:" > lines that refer to the author or the committer? As far as I've seen here, the only Signed-off-by lines have always matched the name of the committer. If we decide there is something to be gained by allowing "Signed-off-by:

Re: [PATCH 00/22] Towards a non-recursive build system for coreutils?

On 08/30/2012 03:23 PM, Jim Meyering wrote: > > Ok? > ACK. Thanks, Stefano

Re: [PATCH] scripts: git commit message hook: prohibit use of "Signed-off-by

Stefano Lattarini wrote: > Jim Meyering wrote: >> >> I noticed a lot of Signed-off-by: lines in Stefano's series. >> This makes our no-S-o-b policy more apparent: ... >> + $buf =~ /^ *Signed-off-by:/i >> +and return q(do not use "Signed-off-by:"); >> + >>return ''; >> } >> > Sigh, this wi

[PATCH] build: enable the 'subdir-objects' Automake option globally

This is not strictly required now (it will be once we make more parts of the coreutils build system non-recursive), but enabling it early help to ensure that we don't unwittingly introduce any incompatibility or subtle breakage that might get to bite us later. * configure.ac (AM_INIT_AUTOMAKE): Ad

Re: [PATCH 00/22] Towards a non-recursive build system for coreutils?

Stefano Lattarini wrote: > On 08/30/2012 02:16 PM, Jim Meyering wrote: >> >> I've merged those into the appropriate change sets, removed all >> Signed-off-by: lines and made a few minor wording changes. >> Please review the differences. If you're happy with the result, >> I'll push the lot. >> > I

Re: [PATCH 00/22] Towards a non-recursive build system for coreutils?

On 08/30/2012 02:16 PM, Jim Meyering wrote: > > I've merged those into the appropriate change sets, removed all > Signed-off-by: lines and made a few minor wording changes. > Please review the differences. If you're happy with the result, > I'll push the lot. > I have few nits against myself then

Re: [PATCH] scripts: git commit message hook: prohibit use of "Signed-off-by

Jim Meyering wrote: > > I noticed a lot of Signed-off-by: lines in Stefano's series. > This makes our no-S-o-b policy more apparent: > > >From 4f76f9b42ad71df40f1f714f2ecfb1e4b6cd7078 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Thu, 30 Aug 2012 13:07:10 +0200 > Subject: [PATCH] scripts:

[PATCH 3/7] build: require Automake >= 1.11.6

Now that we use AM_TESTS_ENVIRONMENT, we should require at least Automake >= 1.11.2; but since all the Automake version until 1.11.5 are vulnerable to CVE-2012-3386: it's even better to require 1.11.6. * configure.ac (AM_INIT_

[PATCH 0/7] Reorganization of the coreutils test harness

In part it is in preparation for the merging of tests/Makefile into the too-level makefile, but mostly it's a "while at it" refactoring (introducing, among other things, a more idiomatic usage of the Automake parallel test harness capabilities; see patch n.6). The series is built upon the "Towards

[PATCH 4/7] tests: avoid use of '-T' in shebang line to enable perl taint mode

* tests/rm/fail-eperm: Rename ... * tests/rm/fail-eperm.xpl: ... like this * tests/Makefile.am (TESTS): Adjust. (TEST_EXTENSIONS): New, list '.xpl'. (XPL_TEST_LOGS): New, run a perl test in tainted mode. * tests/shell-or-perl: Simplify this script: we no longer need to parse the shebang line and ad

[PATCH 2/7] tests: prefer AM_TESTS_ENVIRONMENT over TESTS_ENVIRONMENT

The latter should be reserved for user overrides. * tests/Makefile.am (TESTS_ENVIRONMENT): Rename ... (AM_TESTS_ENVIRONMENT): ... like this. --- tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index eed4e2e..9839030 10064

[PATCH 7/7] tests: get rid of the 'shell-or-perl' auxiliary script

It's now easier and faster to simply run the perl ans shell test scripts directly with the appropriate interpreter and options. * tests/shell-or-perl: Delete. * tests/Makefile.am (EXTRA_DIST): Remove it. (SH_LOG_COMPILER): Re-define to invoke the correct shell. (PL_LOG_COMPILER): Re-define to invo

[PATCH 5/7] tests: detect missing perl at configure runtime

* configure.ac (AM_CONDITIONAL): Se the conditional 'HAVE_PERL' to true if the configure-time checks (as run by gl_PERL) have been able to find a working perl. * tests/no-perl: New script, report a diagnostic about "missing perl" and exit with status 77. * tests/Makefile.am (EXTRA_DIST): Distribute

[PATCH 1/7] tests: merge tests/check.mk into tests/Makefile.am

The separation has become unnecessary after all the ancient 'tests/*/Makefile.am' makefiles have been merged into the "more-top-level" one 'tests/Makefile.am'. * tests/check.mk: Merge ... * tests/Makefile.am: ... in here. Some comments tweaking while at it. --- tests/Makefile.am | 97 +++

Re: [PATCH] tests: misc/sort-exit-early: do not run as root.

On 30 Aug 2012, Jim Meyering uttered the following: > A word of caution: > > There have been exploitable flaws (albeit rare) in these tests over > the years, and if you had regularly run all of them as root on a shared > system, it might have been easy to exploit. The root-only tests are > more c

[PATCH] scripts: git commit message hook: prohibit use of "Signed-off-by:"

I noticed a lot of Signed-off-by: lines in Stefano's series. This makes our no-S-o-b policy more apparent: >From 4f76f9b42ad71df40f1f714f2ecfb1e4b6cd7078 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 30 Aug 2012 13:07:10 +0200 Subject: [PATCH] scripts: git commit message hook: prohibit u

Re: [PATCH 00/22] Towards a non-recursive build system for coreutils?

On 08/30/2012 12:10 PM, Jim Meyering wrote: > Stefano Lattarini wrote: >> On 08/30/2012 01:14 AM, Jim Meyering wrote: >>> Thanks for all the work. >>> >>> Would you please mail to me (or to the list) the concatenation of those >>> patches > > Thanks again. I've begun looking at these changes, so

Re: [PATCH] tests: remove useless defn of REPLACE_GETCWD from TESTS_ENVIRONMENT

Stefano Lattarini wrote: > It's last use had been removed in commit v8.12-3-g3ed91fc of 2011-04-28, > "tests: remove useless test: misc/pwd-unreadable-parent". > > * tests/check.mk (TESTS_ENVIRONMENT): Adjust. > > Signed-off-by: Stefano Lattarini > --- > tests/check.mk | 1 - > 1 file changed, 1

Re: [PATCH 00/22] Towards a non-recursive build system for coreutils?

Stefano Lattarini wrote: > On 08/30/2012 01:14 AM, Jim Meyering wrote: >> Thanks for all the work. >> >> Would you please mail to me (or to the list) the concatenation of those >> patches Thanks again. I've begun looking at these changes, so here's some preliminary feedback. As expected, the bui

Re: [PATCH] tests: misc/sort-exit-early: do not run as root.

Nick Alcock wrote: > This test requires an unwritable input and an unreadable output, > so will fail if the testsuite is being run as root, and should > not be run in this case. > --- > tests/misc/sort-exit-early | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/misc/sort-exit-early

Re: sort: new feature: use environment variable to set buffer size

Pádraig Brady wrote: > Thanks for the detailed rationale, however > the existing env variables are significant to more utils than sort(1). > I.E. they're generally system level settings, rather than command level. > Also sort -S is very portable, even though not standardised. > solaris' sort(1) has

Re: [PATCH 00/22] Towards a non-recursive build system for coreutils?

An BTW, now that I notice ... >> >> Stefano Lattarini (22): >> build: don't abuse Automake internals (with its 'check-am' rule) >> maint: slightly improve .gitignore >> build: add extra *.texi files to coreutils_TEXINFOS, not EXTRA_DIST >> build: prefer '$(top_srcdir)/doc' over '$(srcdir)'

Re: [PATCH 00/22] Towards a non-recursive build system for coreutils?

Stefano Lattarini wrote: > On 08/30/2012 01:14 AM, Jim Meyering wrote: >> >> Thanks for all the work. >> >> Would you please mail to me (or to the list) the concatenation of those >> patches >> > Sorry to be dense, but: what does "concatenation" mean in this conext > exactly? The output of git for

Re: [PATCH 00/22] Towards a non-recursive build system for coreutils?

Hi Jim. On 08/30/2012 01:14 AM, Jim Meyering wrote: > > Thanks for all the work. > > Would you please mail to me (or to the list) the concatenation of those > patches > Sorry to be dense, but: what does "concatenation" mean in this conext exactly? > or point me to a repository from which I can p