Re: RFC: avoid chroot() call if not changing root dir

2014-05-16 Thread Pádraig Brady
On 05/14/2014 01:02 AM, Pádraig Brady wrote: > On 05/13/2014 11:45 PM, Bernhard Voelker wrote: >> On 05/13/2014 05:14 PM, Pádraig Brady wrote: >>> From 9c1bad82852cec8403ead49f12f53280c468a2cf Mon Sep 17 00:00:00 2001 >>> From: =?UTF-8?q?P=C3=A1draig=20Brady?= >>> Date: Tue, 13 May 2014 15:56:34 +

Re: RFC: avoid chroot() call if not changing root dir

2014-05-16 Thread Eric Blake
On 05/16/2014 08:08 AM, Pádraig Brady wrote: >>From 17a185c8e02a56fa09f91ce97151d4e071ecf236 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?P=C3=A1draig=20Brady?= > Date: Tue, 13 May 2014 15:56:34 +0100 > Subject: [PATCH] chroot: don't chdir() if not changing root > > This allows chroot to use used

sharing STDOUT in multiple sha256sum processes

2014-05-16 Thread Assaf Gordon
Hello, I'd like to ask your advice, to verify that my command is correct. I'm trying to calculate sha256 checksum on many files, in parallel. A contrived example would be: $ find /path/ -type f -print0 | xargs -0 -P5 -n1 stdbuf -oL sha256sum > 1.txt Which would run at most 5 processes of "sha2

Re: sharing STDOUT in multiple sha256sum processes

2014-05-16 Thread Pádraig Brady
On 05/16/2014 07:15 PM, Assaf Gordon wrote: > Hello, > > I'd like to ask your advice, to verify that my command is correct. > > I'm trying to calculate sha256 checksum on many files, in parallel. > > A contrived example would be: > $ find /path/ -type f -print0 | xargs -0 -P5 -n1 stdbuf -oL sha2

Re: RFC: dropping privs in chroot --user

2014-05-16 Thread Pádraig Brady
On 05/13/2014 04:04 PM, Pádraig Brady wrote: > Both setuidgid and runuser behave as I would expect > and drop the supplemental groups of the root user: > > # runuser padraig -c "id -G" > 500 10 489 491 > > # ~padraig/git/coreutils/src/setuidgid padraig id -G > 500 10 489 491 > > However

Re: RFC: avoid chroot() call if not changing root dir

2014-05-16 Thread Pádraig Brady
On 05/16/2014 03:43 PM, Eric Blake wrote: > On 05/16/2014 08:08 AM, Pádraig Brady wrote: > >> >From 17a185c8e02a56fa09f91ce97151d4e071ecf236 Mon Sep 17 00:00:00 2001 >> From: =?UTF-8?q?P=C3=A1draig=20Brady?= >> Date: Tue, 13 May 2014 15:56:34 +0100 >> Subject: [PATCH] chroot: don't chdir() if not

Re: RFC: avoid chroot() call if not changing root dir

2014-05-16 Thread Bernhard Voelker
On 05/16/2014 11:02 PM, Pádraig Brady wrote: > Pushed. Sorry, a bit late ... > + /* Only do chroot specific actions if actually changing root. > + The main difference here is that we don't change working dir. */ > + if (! STREQ (argv[optind], "/")) What about canonicalizing argv[optind] ?

Re: RFC: dropping privs in chroot --user

2014-05-16 Thread Bernhard Voelker
On 05/16/2014 10:59 PM, Pádraig Brady wrote: Thanks for the detailed tests. > [[ chroot --user=+5000 / id -G ]] > before: 0 1 2 3 4 6 10 > after: src/chroot: failed to get primary group While the logic behind may be okay, our users will probably be confused with the above change in behavior. I