Re: bug#7320: [PATCH] 'id' prints incorrectly groups for the session

2014-06-26 Thread Pádraig Brady
On 06/26/2014 05:42 PM, Jim Meyering wrote: > On Thu, Jun 26, 2014 at 3:23 AM, Pádraig Brady wrote: >> -g=$(id -u $NON_ROOT_USERNAME) || framework_failure_ >> +u=$(id -u $NON_ROOT_USERNAME) || framework_failure_ >> +g=u > > This will work better :-) >g=$u It's already pushed with that amendm

Re: [PATCH] 'id' prints incorrectly groups for the session

2014-06-26 Thread Jim Meyering
On Thu, Jun 26, 2014 at 3:23 AM, Pádraig Brady wrote: > -g=$(id -u $NON_ROOT_USERNAME) || framework_failure_ > +u=$(id -u $NON_ROOT_USERNAME) || framework_failure_ > +g=u This will work better :-) g=$u

Re: [PATCH] maint: use predetermined NON_ROOT_GROUP in tests

2014-06-26 Thread Pádraig Brady
On 06/26/2014 01:25 PM, Bernhard Voelker wrote: > On 06/26/2014 01:47 PM, Pádraig Brady wrote: >> * tests/misc/chroot-credentials.sh: Avoid gid lookup. > > Good catch! > >> * tests/misc/truncate-owned-by-other.sh: Likewise. >> * tests/touch/now-owned-by-other.sh: Likewise. >> * tests/id/setgid.sh

Re: [PATCH] maint: use predetermined NON_ROOT_GROUP in tests

2014-06-26 Thread Bernhard Voelker
On 06/26/2014 01:47 PM, Pádraig Brady wrote: * tests/misc/chroot-credentials.sh: Avoid gid lookup. Good catch! * tests/misc/truncate-owned-by-other.sh: Likewise. * tests/touch/now-owned-by-other.sh: Likewise. * tests/id/setgid.sh: Use previously looked up gid as a more accurate base for the s

[PATCH] maint: use predetermined NON_ROOT_GROUP in tests

2014-06-26 Thread Pádraig Brady
* tests/misc/chroot-credentials.sh: Avoid gid lookup. * tests/misc/truncate-owned-by-other.sh: Likewise. * tests/touch/now-owned-by-other.sh: Likewise. * tests/id/setgid.sh: Use previously looked up gid as a more accurate base for the subseuqent adjustment, and move the uid lookup within chroot, ra

Re: [PATCH] 'id' prints incorrectly groups for the session

2014-06-26 Thread Petr Stodůlka
On 26.6.2014 03:53, Pádraig Brady wrote: On 06/25/2014 01:17 PM, Petr Stodůlka wrote: Hi, command 'id' prints wrong groups for the session. This is similar to reported bug #7320 [0], which was patched earlier for 'groups' and 'id -G', however just 'id' still prints wrong groups. I propose thi

[PATCH] maint: mention when the du cycle warning bug was introduced

2014-06-26 Thread Pádraig Brady
* NEWS: Mention bug introduced in v8.1 (with commit v8.0-88-g8ba5d1a). --- NEWS |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index e5ea77c..4e90b79 100644 --- a/NEWS +++ b/NEWS @@ -53,6 +53,7 @@ GNU coreutils NEWS-*- outl

Re: [PATCH] 'id' prints incorrectly groups for the session

2014-06-26 Thread Pádraig Brady
On 06/26/2014 06:44 AM, Bernhard Voelker wrote: > On 06/26/2014 03:53 AM, Pádraig Brady wrote: >> diff --git a/tests/id/setgid.sh b/tests/id/setgid.sh >> index aa43ea3..a81b42c 100755 >> --- a/tests/id/setgid.sh >> +++ b/tests/id/setgid.sh >> @@ -1,5 +1,5 @@ >> #!/bin/sh >> -# Verify that id -G pr