On 11/22/20 10:59 AM, Bernhard Voelker wrote:
selinux.c:257 has a superfluous semicolon after a jump label,
and a strange indentation:
The semicolon is required by the C standard, which does not allow a label before
a declaration. Emacs indented it that way.
On 11/22/20 6:27 AM, Bernhard Voelker wrote:
This is caught by a syntax-check rule as well.
Fixed with the attached patch - as well as 2 other sc failures.
Thanks for fixing that. The tabs got introduced because I edited mv.c with an
unusual Emacs configuration, which I'll try to remember to n
On 11/22/20 7:08 PM, Pádraig Brady wrote:
> Non leaky version attached.
Thanks. Looks good to me - on system without active SELinux:
tested once with and once --without-selinux.
Minor nit (from Paul's commit):
selinux.c:257 has a superfluous semicolon after a jump label,
and a strange indentatio
On 22/11/2020 17:56, Pádraig Brady wrote:
On 22/11/2020 14:27, Bernhard Voelker wrote:
On 11/22/20 1:28 PM, Kamil Dudka wrote:
The coreutils patch introduced tab-indented lines into src/mv.c, which
otherwise does not use tabs for indentation.
This is caught by a syntax-check rule as well.
Fix
On 22/11/2020 14:27, Bernhard Voelker wrote:
On 11/22/20 1:28 PM, Kamil Dudka wrote:
The coreutils patch introduced tab-indented lines into src/mv.c, which
otherwise does not use tabs for indentation.
This is caught by a syntax-check rule as well.
Fixed with the attached patch - as well as 2 o
On 11/22/20 1:28 PM, Kamil Dudka wrote:
> The coreutils patch introduced tab-indented lines into src/mv.c, which
> otherwise does not use tabs for indentation.
This is caught by a syntax-check rule as well.
Fixed with the attached patch - as well as 2 other sc failures.
> I can see 3 tests failin
On Sunday, November 22, 2020 3:45:22 AM CET Paul Eggert wrote:
> Yes, it's looking like great minds think alike.
>
> The coreutils patch I had prepared is fancier than yours, though, as it
> caches the result of selabel_open and this should yield better performance.
>
> I don't use SELinux either
