Re: [PATCH] wc: Add AVX2 optimization when counting only lines

2021-04-21 Thread Assaf Gordon
Hello, On 2021-03-29 7:21 a.m., Pádraig Brady wrote: On 28/03/2021 18:29, Kristoffer Brånemyr via GNU coreutils General I wanted to practice some more using vector intrinsics, so I made a small AVX2 optimization for wc -l. Depending on line length it is about 2-5x faster than previous version

Re: [PATCH] tests: fix FP in ls/stat-free-color.sh

2021-04-21 Thread Pádraig Brady
On 20/04/2021 23:15, Bernhard Voelker wrote: This FP was seen on latest openSUSE - logfile attached. The patch fixes it. Okay to push? Jim also noticed that on Fedora 34. Oh so it's stating stdout. Could you change the "1" in your commit summary to STDOUT_FILENO as that makes the system behav

Re: [PATCH] ls: add --files0-from=FILE option

2021-04-21 Thread Carl Edquist via GNU coreutils General Discussion
On Tue, 20 Apr 2021, p...@draigbrady.com wrote: > One can also implement this functionality with the DSU pattern like: > > nlargest=10 > find . -printf '%s\t%p\0' | > sort -z -k1,1n | tail -z -n"$nlargest" | cut -z -f2 | > xargs -r0 ls -lUd --color=auto -- > > Arguably that's more scalable

Re: [PATCH] ls: add --files0-from=FILE option

2021-04-21 Thread Carl Edquist via GNU coreutils General Discussion
Hi Berny, On Wed, 21 Apr 2021, Bernhard Voelker wrote: shouldn't it use the 'argv-iter' gnulib module (like du.c and wc.c) instead of directly using the underlying ... +#include "readtokens0.h" I considered this, too! :) I think the short answer is that du and wc don't actually need to k