Re: RFC: ls: case insentive file extension colors

2018-06-17 Thread Jim Meyering
On Sun, Jun 17, 2018 at 3:18 PM, Pádraig Brady wrote: > On 17/06/18 07:23, Bernhard Voelker wrote: >> On 06/17/2018 05:51 AM, Pádraig Brady wrote: >>> Subject: [PATCH] ls: ignore case when coloring file extensions >> >> Nice one. >> This sounds like this would deserve a NEW entry as well. > > Full

bug#29921: O(n^2) performance of rm -r

2018-01-01 Thread Jim Meyering
On Mon, Jan 1, 2018 at 2:50 PM, Paul Eggert wrote: > Jim Meyering wrote: > >> $ i=10; while :; do mkdir x; (cd x && seq $i|xargs touch); env >> time -f "%e $i" env rm -rf x; case $i in 8*) break;; esac; i=$[i*2]; >> done >> 0.48 10 >>

bug#29921: O(n^2) performance of rm -r

2018-01-01 Thread Jim Meyering
On Mon, Jan 1, 2018 at 8:40 AM, Pádraig Brady wrote: > tag 29921 notabug > close 29921 > stop > > On 31/12/17 21:07, Niklas Hambüchen wrote: >> Hello, >> >> in commit >> >> rm -r: avoid O(n^2) performance for a directory with very many entries >> http://git.savannah.gnu.org/cgit/coreutils.git/

Re: new snapshot available: coreutils-8.28.61-70c84

2017-12-21 Thread Jim Meyering
On Thu, Dec 21, 2017 at 7:54 AM, Pádraig Brady wrote: > Some initial test results. All tests pass on: > > x86_64 Fedora25 (+ASAN) > ARMv7l ArchLinux > sparcSolaris10 > aarch64 Centos7 On Fedora 27 x86_64, with gcc.git and UBSAN, I see many of these: + src/pr.c:2562:9: runtime error: poi

latest gcc.git vs latest coreutils.git

2017-12-19 Thread Jim Meyering
I built the very latest gcc from git: gcc version 8.0.0 20171219 (experimental) (GCC) Then used it to build latest coreutils.git configured with --enable-gcc-warnings. That shows that a few of gcc's new warnings trigger in latest coreutils and gnulib. I haven't looked at these enough yet to s

Re: [PATCH] build: avoid build failure without sys/mtio.h

2017-12-09 Thread Jim Meyering
On Sat, Dec 9, 2017 at 8:18 PM, Pádraig Brady wrote: > * m4/jm-macros.m4: Check for the header. > * src/dd.c: Avoid the workaround where the header > is not available (on non glibc systems). > --- > m4/jm-macros.m4 | 1 + > src/dd.c| 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-)

Re: improving support issues with "tail -f / unrecognized file systems"

2017-12-04 Thread Jim Meyering
On Sun, Dec 3, 2017 at 5:08 PM, Assaf Gordon wrote: > On Sat, Dec 2, 2017 at 8:31 AM, Jim Meyering wrote: >> However, given the work you've already done, I suspect it would be >> worthwhile to follow through. > > OK, > Attached an updated version (also in > http

Re: improving support issues with "tail -f / unrecognized file systems"

2017-12-02 Thread Jim Meyering
On Thu, Nov 30, 2017 at 9:07 PM, Assaf Gordon wrote: > Hmm, > > On 2017-11-30 09:37 PM, Assaf Gordon wrote: >> >> http://files.housegordon.org/tmp/cu-fs.html > > > I missed the 2015 commit which completely removed the warning > from tail.c ( v8.24-43-ge6b3af6 ), rendering the entire thing irreleva

Re: Unexpected info in tail cmd

2017-12-01 Thread Jim Meyering
On Thu, Nov 30, 2017 at 9:09 AM, Bernhard Voelker wrote: > On 11/30/2017 12:28 PM, Abhishek Kandoi wrote: >> tail: unrecognized file system type 0x794c7630 for 'somefile.log'. please >> report this to bug-coreut...@gnu.org. reverting to polling > > Thanks, this is already fixed in coreutils >= 8.2

Re: fix spurious gnulib test-faccessat failure

2017-11-28 Thread Jim Meyering
On Tue, Nov 28, 2017 at 7:58 AM, Jim Meyering wrote: > FYI, I've just pushed the following to gnulib. > I noticed this new parallel test failure when coreutils started > using the very latest from gnulib. > > test-faccessat.c: correct BASE definition to avoid p

fix spurious gnulib test-faccessat failure

2017-11-28 Thread Jim Meyering
FYI, I've just pushed the following to gnulib. I noticed this new parallel test failure when coreutils started using the very latest from gnulib. test-faccessat.c: correct BASE definition to avoid parallel test failure * tests/test-faccessat.c (BASE): Define using this file's name, not

Re: switch to HTTPS: URLs in Coreutils source and doc

2017-11-12 Thread Jim Meyering
On Sun, Nov 12, 2017 at 7:34 AM, Bernhard Voelker wrote: > On 11/06/2017 03:38 PM, Jim Meyering wrote: >> >> diff --git a/bootstrap b/bootstrap >> index 85b85c530..03057c378 100755 >> --- a/bootstrap >> +++ b/bootstrap >> @@ -792,7 +792,7 @@ symlink_to_

Re: Redirecting Issues from Github

2017-11-10 Thread Jim Meyering
On Thu, Nov 9, 2017 at 2:17 PM, Assaf Gordon wrote: > On 2017-11-09 02:58 PM, Eric Blake wrote: >> >> Overall, the proposed templates look sane. > > Thanks, > > Attached a patch (with your suggestions). > Text on Github was also updated. Looks fine. Thanks again.

Re: Redirecting Issues from Github

2017-11-08 Thread Jim Meyering
On Tue, Nov 7, 2017 at 11:51 PM, Assaf Gordon wrote: > Hello all, > > Recently there were several "issues" opened on coreutils' github > repository ( https://github.com/coreutils/coreutils/issues ). > > Sometimes it's quicker to just answer there, > but often it's best to move the discussion to th

Re: switch to HTTPS: URLs in Coreutils source and doc

2017-11-07 Thread Jim Meyering
On Mon, Nov 6, 2017 at 6:38 AM, Jim Meyering wrote: > On Sun, Nov 5, 2017 at 4:39 PM, Pádraig Brady wrote: >> On 19/09/17 22:48, Pádraig Brady wrote: >>> On 19/09/17 01:31, Paul Eggert wrote: >>>> I installed the attached patches to switch Coreutils to prefer HTTPS

Re: switch to HTTPS: URLs in Coreutils source and doc

2017-11-06 Thread Jim Meyering
tml/bug-coreutils/2006-09/msg00326.html https://lists.gnu.org/archive/html/bug-coreutils/2009-11/msg00213.html Attached patches make the comment changes and adjust the log-checking commit hook to require the abbreviated form. From b3d4a7fe35d88f2b70eafaec8b98a58172d74ad0 Mon Sep 17 00:00:00 2001

Re: [PATCH] build: ls.c: apply _GL_ATTRIBUTE_PURE to more functions

2017-10-29 Thread Jim Meyering
On Sun, Oct 29, 2017 at 2:25 PM, Pádraig Brady wrote: > On 27/10/17 21:37, Jim Meyering wrote: >> I noticed a new warning/error when building with git-latest gcc, >> and propose to fix it with this: >> >>>From f89c20bdf7ccc033cbc22662e932fae7761754fc Mon Sep 17 00:00

[PATCH] build: ls.c: apply _GL_ATTRIBUTE_PURE to more functions

2017-10-27 Thread Jim Meyering
I noticed a new warning/error when building with git-latest gcc, and propose to fix it with this: >From f89c20bdf7ccc033cbc22662e932fae7761754fc Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 27 Oct 2017 21:14:37 -0700 Subject: [PATCH] build: ls.c: apply _GL_ATTRIBUTE_PURE to m

Re: FYI, shorter lists.gnu.org URLs, finally

2017-10-26 Thread Jim Meyering
On Thu, Oct 26, 2017 at 6:31 PM, Paul Eggert wrote: > On 10/26/2017 05:30 PM, Jim Meyering wrote: >> >> Now, instead of >> http://lists.gnu.org/archive/html/bug-coreutils/2017-10/threads.html >> you can write the shorter >> http://lists.gnu.org/r/bug-coreutils/201

FYI, shorter lists.gnu.org URLs, finally

2017-10-26 Thread Jim Meyering
Now, instead of http://lists.gnu.org/archive/html/bug-coreutils/2017-10/threads.html you can write the shorter http://lists.gnu.org/r/bug-coreutils/2017-10/threads.html This applies to all mailing lists hosted on lists.gnu.org. Sometimes it matters, especially when a URL is longer than the maximu

Re: Bug#762092: sha...sum man pages refer to nonexistent 'sha...sum invocation' info pages

2017-10-19 Thread Jim Meyering
On Thu, Sep 18, 2014 at 7:13 AM, Pádraig Brady wrote: > On 09/18/2014 12:54 PM, Rebecca Palmer wrote: >> Package: coreutils >> Version: 8.23-2 >> Severity: minor >> Control: tags -1 patch >> >> The man page of sha512sum states that more documentation can be found at >> info coreutils 'sha512sum i

Re: New utility suggestion: chdir(1)

2017-08-28 Thread Jim Meyering
On Mon, Aug 28, 2017 at 8:55 PM, Pádraig Brady wrote: > I'll push the attached shortly. > This supports -C and also requires specifying a command > when specifying -C, as otherwise you get confusing > output and no error with `env --chdir command` which would > just print the environment with the

Re: [PATCH] ls: consistently quote symlink targets

2017-08-24 Thread Jim Meyering
On Thu, Aug 24, 2017 at 12:28 AM, Pádraig Brady wrote: > * src/ls.c (gobble_file): Disable the optimization to avoid quoting > if the symlink target itself needs quoting. This was introduced > with the quoting alignment adjustments in v8.25-106-g01971c0 > * tests/ls/symlink-quote.sh: Add a test.

Re: 2 patches: build with warnings enabled and latest gcc

2017-08-12 Thread Jim Meyering
On Sat, Aug 12, 2017 at 2:16 PM, Jim Meyering wrote: > I tried to build coreutils with warnings enabled and using the latest > gcc (built from head of gcc.git) and was irritated to see it fail with > a few of the new warnings evoking apparent false positives, like these: ... >

2 patches: build with warnings enabled and latest gcc

2017-08-12 Thread Jim Meyering
upgraded gnulib to latest in the first patch below, but the warning/error issues persisted, so I disabled the offenders via the second patch. Now, "make distcheck" nearly completes. I'll push these soon if no one objects. >From 0b7fababf893803505e0382f71dc755951c98cc8 Mon Sep 17 0

[PATCH] chroot: fix typo in preceding change: didn't compile

2017-08-11 Thread Jim Meyering
I've just made this correction: * src/chroot.c (usage): Add backslashes. --- src/chroot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/chroot.c b/src/chroot.c index b8b72586d..830e619f7 100644 --- a/src/chroot.c +++ b/src/chroot.c @@ -207,7 +207,7 @@ Run COMMAND with ro

[PATCH] doc: correct technicality in chroot's --help output

2017-08-10 Thread Jim Meyering
I noticed a nit in chroot's --help output. I.e., what if the expansion of $SHELL contains white space or shell metacharacters? You can argue they'd get what they deserve :-) But still... we care about robustness, even if it's only in --help output's implied advice. * src/chroot.c (usage): Use corr

Re: [PATCH 2/2] shred: use explicit_bzero

2017-07-23 Thread Jim Meyering
On Sun, Jul 23, 2017 at 10:30 AM, Pádraig Brady wrote: > On 20/07/17 14:03, Paul Eggert wrote: >> * NEWS: Document this. >> * bootstrap.conf (gnulib_modules): Add explicit_bzero. >> * gl/lib/randint.c (randint_free): >> * gl/lib/randread.c (randread_free): >> * src/blake2/blake2-impl.h (secure_zer

Re: groups bug fix, groups test fix and NEWS tweak

2017-07-10 Thread Jim Meyering
On Mon, Jul 10, 2017 at 8:17 AM, Bernhard Voelker wrote: > On 07/08/2017 06:42 PM, Jim Meyering wrote: >> Here are three proposed patches: >> >> groups: do not exit early > > Nice catch! > > FWIW the bug seems to have been introduced when replacing the > old

groups bug fix, groups test fix and NEWS tweak

2017-07-08 Thread Jim Meyering
Here are three proposed patches: groups: do not exit early tests: groups-dash.sh: avoid false failure doc: tweak wording >From df2c30dca6bb9c07be9b6e5b12ff6d1634e6c417 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 2 Jun 2017 21:50:04 -0700 Subject: [PATCH 1/3] doc: tweak word

Re: [PATCH] maint: avoid spurious "make distcheck" failure

2017-06-20 Thread Jim Meyering
On Tue, Jun 20, 2017 at 3:44 PM, Bernhard Voelker wrote: > On 06/20/2017 10:49 PM, Jim Meyering wrote: >> From a05ba352d39a6e6a0c58d57f4b7acbb1e4f11f8b Mon Sep 17 00:00:00 2001 >> From: Jim Meyering >> Date: Tue, 20 Jun 2017 07:53:17 -0700 >> Subject: [PATCH]

[PATCH] maint: avoid spurious "make distcheck" failure

2017-06-20 Thread Jim Meyering
I've been annoyed by this subtle bug more than a few times over the years, so have finally diagnosed it. Here's one way to fix it: >From a05ba352d39a6e6a0c58d57f4b7acbb1e4f11f8b Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 20 Jun 2017 07:53:17 -0700 Subject: [PATCH]

Re: cp and --backup error

2017-06-16 Thread Jim Meyering
On Fri, Jun 16, 2017 at 3:11 AM, slash mais wrote: > The command: > cp -r -P --preserve=all --strip-trailing-slashes --backup=numbered > "/source-dir/source-file" "/source-dir/" > returns: > cp: ‘/source-dir/source-file’ and ‘/source-dir/source-file’ are the > same file > > This r

[PATCH] maint: update to work with GCC7's -Werror=implicit-fallthrough=

2017-06-10 Thread Jim Meyering
This (with today's gnulib/lib/savewd.c change) addresses all of coreutils' build errors due to -Werror=implicit-fallthrough= >From 68f9e301d1737158f8ec5455c019826431bdba93 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 10 Jun 2017 10:02:31 -0700 Subject: [PATCH] maint: u

Re: [PATCH] tests: fix issues with recently added tail test

2017-06-07 Thread Jim Meyering
On Wed, Jun 7, 2017 at 12:22 AM, Pádraig Brady wrote: > * tests/tail-2/inotify-dir-recreate.sh: Skip when > inotify is not usable. Also remove a bash specific &> construct. +1 Thanks!

Re: [PATCH] tail: with --pid, ensure all inotify events are processed

2017-06-07 Thread Jim Meyering
On Wed, Jun 7, 2017 at 12:23 AM, Pádraig Brady wrote: > + tail -f with --pid no longer ignores some inotify events. > + [bug introduced with inotify support added in coreutils-7.5] Nice patch. Might be worth clarifying that tail -f --pid=PID no longer ignores events delivered just prior to

Re: "Failed to preserve ownership" exit(1) bug in mv?

2017-06-03 Thread Jim Meyering
On Fri, Jun 2, 2017 at 9:56 PM, Pádraig Brady wrote: > That indeed looks like a bug that has been present since the initial > implementation! > The attached should fix it up. > > thanks! Thanks, indeed! It's not often we see bugs in tools like these that date back a quarter of a century or more.

Re: [PATCH] date,touch: test and document large TZ security issue

2017-04-27 Thread Jim Meyering
On Thu, Apr 27, 2017 at 1:21 PM, Pádraig Brady wrote: > Add a test for CVE-2017-7476 which was fixed in gnulib at: > http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=94e01571 > > * tests/misc/date-tz.sh: Add a new test which overwrites enough > of the heap to trigger a segfault, even with

Re: Please, use --check=crc32 or switch to a safe format

2017-04-09 Thread Jim Meyering
On Sun, Apr 9, 2017 at 1:18 PM, Matias Fonzo wrote: > On Wed, 5 Apr 2017 16:16:53 -0300 > Matias Fonzo wrote: > >> On Wed, 5 Apr 2017 10:31:50 -0500 >> Eric Blake wrote: >> >> > On 04/05/2017 09:42 AM, Antonio Diaz Diaz wrote: >> > >> > > Is there any chance to fix the problem once and for all b

Re: [PATCH] doc: indicate sha1 has the same limitations as md5

2017-02-28 Thread Jim Meyering
On Tue, Feb 28, 2017 at 8:29 PM, Pádraig Brady wrote: > +The SHA-1 algorithm should not be used any more for security related > purposes. > +Instead, better use an SHA\-2 algorithm, implemented in the programs Thanks. I appreciate the use of that macro to avoid duplication. Re the above two line

Re: [PATCH] doc: only distribute 5 years of ChangeLogs

2017-02-02 Thread Jim Meyering
On Tue, Jan 31, 2017 at 10:28 PM, Pádraig Brady wrote: > * Makefile.am (gen-ChangeLog): Adjust to taking all > logs from a particular version (8.15 in this case). > Also mention where to get older entries. > * build-aux/git-log-fix: Remove now unused entries. > * ChangeLog-200[5-8]: Delete. > * ol

Re: [PATCH 2/2] tests: fix tail test race causing false failure

2017-01-31 Thread Jim Meyering
Nice work, eliminating another test race condition. On Tue, Jan 31, 2017 at 9:41 PM, Pádraig Brady wrote: > +grep -F 'become accessible' out || # usual case > +grep -F 'has appeared' out || { fail=1; cat out; } # with slow rmdir I would find that more readable with a

Re: [PATCH] build: Properly expand cu_install_program viariable when cross-compiling

2017-01-25 Thread Jim Meyering
On Wed, Jan 25, 2017 at 8:56 AM, Eric Blake wrote: > I made those tweaks and pushed. Thank you.

Re: Notes on testing coreutils

2017-01-23 Thread Jim Meyering
On Mon, Jan 23, 2017 at 9:04 AM, Pádraig Brady wrote: > FYI I summarized some notes on testing coreutils at > https://news.ycombinator.com/item?id=13463620 Very nice write-up. Going through it now. One nit: "LDP_RELOAD"

Re: strengthening ARRAY_CARDINALITY

2017-01-20 Thread Jim Meyering
On Fri, Jan 20, 2017 at 5:57 AM, Eric Blake wrote: > On 01/19/2017 09:43 PM, Mike Frysinger wrote: > > gnulib module + extra checks + name change to ARRAY_SIZE sound good! > For a convenience feature, ARRAY_CARDINALITY is not a convenient name. yeah, "cardinality" sounds more

Re: strengthening ARRAY_CARDINALITY

2017-01-19 Thread Jim Meyering
On Thu, Jan 19, 2017 at 5:06 PM, Mike Frysinger wrote: > On 19 Jan 2017 22:20, Pádraig Brady wrote: >> On 19/01/17 21:52, Eric Blake wrote: >> > On the qemu list, it was pointed out that code that uses >> > ARRAY_CARDINALITY() might still compile even after it has been >> > refactored to use a poi

[PATCH] maint: update README-hacking now that vc-dwim accepts --init

2017-01-14 Thread Jim Meyering
I've released vc-dwim-1.8: https://savannah.gnu.org/forum/forum.php?forum_id=8776 And that renders part of README-release obsolete, so I propose to modernize it with this: >From 6bb0b403363316b8958f4686141561ee20d088ad Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 14 Jan 20

Re: [PATCH] maint: tweak xz options to compress the release tarball even more

2017-01-13 Thread Jim Meyering
On Wed, Jan 11, 2017 at 6:31 PM, Antonio Diaz Diaz wrote: > Jim Meyering wrote: >> >> -export XZ_OPT = -8e >> +export XZ_OPT = --lzma2=preset=9e,dict=48MiB,pb=0 > > > Isn't this going to impact the use of pristine-tar? > https://packages.debian.org/sid/p

[PATCH] maint: tweak xz options to compress the release tarball even more

2017-01-11 Thread Jim Meyering
Recent discussion reminded me of this languishing patch. The only reason to be wary is that it increases the decompression-time memory requirement to 48MiB (from 32MiB). At least one very-small-system user complained back when I compressed some release tarball using -9: their system did not have s

Re: [PATCH] maint: RFC: add lzip tarballs

2017-01-11 Thread Jim Meyering
On Wed, Jan 11, 2017 at 3:21 PM, Eric Blake wrote: > Coreutils picked 'dist-xz' back in 2008 (see commit b52a8860), > and automake didn't support 'dist-lzip' until 2011 (but forgot > to mention it in NEWS). Our choice of .xz has thus been mostly > one of inertia. > > But these days, there are str

Re: wc -c /proc /sys handling

2016-12-22 Thread Jim Meyering
On Thu, Dec 22, 2016 at 7:25 AM, Pádraig Brady wrote: > On 21/03/16 18:42, Jim Meyering wrote: >> On Mon, Mar 21, 2016 at 8:57 AM, Pádraig Brady wrote: >>> I was wondering if we should not penalize all normal files, >>> to handle the /proc and /sys approximate st_size

Re: [PATCH] tail: fix determination of remoteness without inotify

2016-11-23 Thread Jim Meyering
On Wed, Nov 23, 2016 at 11:18 AM, Pádraig Brady wrote: > In recent commit v8.25-93-g7fc7206 we used the f-remote flag > which wasn't set in all cases. This was detected with > ASAN giving this error when reading f->remote; > runtime error: load of value 190, > which is not a valid value for t

Re: [PATCH] build: avoid racy failure of "make -jN install"

2016-11-23 Thread Jim Meyering
On Wed, Nov 23, 2016 at 3:18 AM, Eric Blake wrote: > On 11/23/2016 04:54 AM, Pádraig Brady wrote: >> On 23/11/16 05:36, Jim Meyering wrote: >>> diff --git a/src/local.mk b/src/local.mk >>> index 9e36ad9..37f625c 100644 >>> --- a/src/local.mk >>> ++

[PATCH] build: avoid racy failure of "make -jN install"

2016-11-22 Thread Jim Meyering
man page installation could cause "make install" failure. Here's a fix: From f7d169431ab70ee50713891b5d7b7e2c301c65bc Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 22 Nov 2016 21:33:58 -0800 Subject: [PATCH] build: avoid racy failure of "make -jN install" Insta

Re: maint: avoid "make distcheck" failure due to excess .deps directories

2016-11-22 Thread Jim Meyering
On Tue, Nov 22, 2016 at 4:43 AM, Pádraig Brady wrote: > On 22/11/16 05:28, Jim Meyering wrote: >> * Makefile.am (my-distcheck): Remove all .deps directories before >> recursive diff search for left-behind files. Otherwise, with >> automake master (v1.15-165-g5fac9a3), "

maint: avoid "make distcheck" failure due to excess .deps directories

2016-11-21 Thread Jim Meyering
uot;make distcheck" pass: From 5bf01120f0a76a37b0c0ea54880e1aba9747d382 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 14 Sep 2016 14:16:40 -0700 Subject: [PATCH] maint: avoid "make distcheck" failure due to excess .deps directories * Makefile.am (my-distcheck): Remove all .deps directories befor

Re: [PATCH] tests: fix false failure on OS X

2016-11-15 Thread Jim Meyering
Typo in log message: s/definfed/defined/. Otherwise looks fine. Thanks!

Re: [PATCH] tests: use "returns_" rather than explicit comparison with "$?"

2016-11-13 Thread Jim Meyering
On Sun, Nov 13, 2016 at 11:05 AM, Jim Meyering wrote: > On Sun, Nov 13, 2016 at 9:24 AM, Bernhard Voelker > wrote: >> On 11/13/2016 03:38 AM, Jim Meyering wrote: >>> I noticed many tests that compare directly with "$?". However, we now >>> have the "

Re: [PATCH] tests: use "returns_" rather than explicit comparison with "$?"

2016-11-13 Thread Jim Meyering
On Sun, Nov 13, 2016 at 9:24 AM, Bernhard Voelker wrote: > On 11/13/2016 03:38 AM, Jim Meyering wrote: >> I noticed many tests that compare directly with "$?". However, we now >> have the "returns_" function (from init.sh) that can be used to make >> the

Re: using ASCII names to avoid overhead

2016-11-13 Thread Jim Meyering
On Sun, Nov 13, 2016 at 7:14 AM, Pádraig Brady wrote: > On 13/11/16 14:14, Pádraig Brady wrote: >> On 13/11/16 12:42, Torbjörn Granlund wrote: >>> Pádraig Brady writes: >>> >>> I was just looking at the overhead of proper_name_utf8() vs proper_name() >>> in coreutils, and noticed that using t

[PATCH] tests: use "returns_" rather than explicit comparison with "$?"

2016-11-12 Thread Jim Meyering
ers "$?". Here's an example of what most of these changes look like: -ls -l --time-style=XX > out 2> err -test $? = 2 || fail=1 +returns_ 2 ls -l --time-style=XX > out 2> err || fail=1 From 2371c4d84f577a8720b2ba244453cb94619a099f Mon Sep 17 00:00:00 2001 From: Jim

Re: [PATCH] tail: only retry file open if --retry specifed

2016-11-10 Thread Jim Meyering
On Wed, Nov 9, 2016 at 11:40 AM, Pádraig Brady wrote: > * src/tail.c (tail_file): On failure to open a file, > set ignore=true when --retry is not specified. > * tests/tail-2/assert-2.sh: Adjust to the new behavior. > * tests/tail-2/retry.sh: Add a test case. > * NEWS: Document the fix. > --- > N

Re: [PATCH] tail: ensure -f --retry 'missing' handles truncation

2016-11-09 Thread Jim Meyering
On Wed, Nov 9, 2016 at 9:57 AM, Pádraig Brady wrote: > * src/tail.c (tail_forever): The BLOCKING optimization is only > enabled for non regular files (which can't be truncated), so ensure > we don't enable that unless we've a valid st_mode. > * tests/tail-2/retry.sh: Add a test case. > * NEWS: Men

Re: [PATCH] doc: improve the --help description of ls -N

2016-11-04 Thread Jim Meyering
On Thu, Nov 3, 2016 at 2:28 PM, Pádraig Brady wrote: > * src/ls.c (usage): The existing description was inaccurate > as -N does not directly impact whether control characters > are displayed or not. > --- > src/ls.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/ls

Re: quarter code for date

2016-11-02 Thread Jim Meyering
On Wed, Nov 2, 2016 at 10:36 AM, Pádraig Brady wrote: > On 06/10/16 12:53, Pádraig Brady wrote: >> On 06/10/16 11:11, john woods wrote: >>> date +%YW%V gives week and year; it would be nice if date +%YQ%q could >>> return, eg 2016Q3 as having a quarters code in date would save AWKwardness >>> or s

Re: avoid new GCC-7-exposed warnings

2016-10-16 Thread Jim Meyering
On Sun, Oct 16, 2016 at 12:13 PM, Pádraig Brady wrote: > On 16/10/16 19:50, Jim Meyering wrote: ... >> Here's one more change I'll push today. It removes a few now-useless >> calls to "abort" after die, and by a similar token, removes some >> "

Re: avoid new GCC-7-exposed warnings

2016-10-16 Thread Jim Meyering
|| : > > will push later... Thanks. Here's one more change I'll push today. It removes a few now-useless calls to "abort" after die, and by a similar token, removes some "break;" statements after abort: From f8b8bbc1b97c9cb7a56aae79451bf87ab7307cd2 Mon Sep 17 00

Re: avoid new GCC-7-exposed warnings

2016-10-15 Thread Jim Meyering
On Sat, Oct 15, 2016 at 8:56 AM, Jim Meyering wrote: > On Sat, Oct 15, 2016 at 8:40 AM, Jim Meyering wrote: >> On Sat, Oct 15, 2016 at 2:55 AM, Pádraig Brady wrote: >>> On 15/10/16 05:47, Jim Meyering wrote: >>>> I tried to build the coreutils using very recent GCC

Re: avoid new GCC-7-exposed warnings

2016-10-15 Thread Jim Meyering
On Sat, Oct 15, 2016 at 8:40 AM, Jim Meyering wrote: > On Sat, Oct 15, 2016 at 2:55 AM, Pádraig Brady wrote: >> On 15/10/16 05:47, Jim Meyering wrote: >>> I tried to build the coreutils using very recent GCC 7, built from >>> latest git, and encountered a few new warni

Re: avoid new GCC-7-exposed warnings

2016-10-15 Thread Jim Meyering
On Sat, Oct 15, 2016 at 2:55 AM, Pádraig Brady wrote: > On 15/10/16 05:47, Jim Meyering wrote: >> I tried to build the coreutils using very recent GCC 7, built from >> latest git, and encountered a few new warnings (errors when configured >> with --enable-gcc-warnings), so w

avoid new GCC-7-exposed warnings

2016-10-14 Thread Jim Meyering
rom 35f28e3cdc0132ef87c5213e0c42b5b409d188d7 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 3 Oct 2016 09:00:48 -0700 Subject: [PATCH 1/3] gnulib: update to latest and adapt printf-quote.sh test * .gitignore: Add /lib/limits.h. * tests/misc/printf-quote.sh: Reflect that a single quote is now rendered as "'&quo

[PATCH] maint: pr: avoid new GCC 7 warning

2016-10-04 Thread Jim Meyering
Building with GCC 7, here's a fix for one of the new warnings: From 9403b93c15ec2ed8fdc7c993263260a91e6b4e8c Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 14 Sep 2016 11:48:33 -0700 Subject: [PATCH] maint: pr: avoid new GCC 7 warning * src/pr.c (main): Avoid this warning from GCC 7

Re: who.c vs gcc-7's improved buffer overrun check

2016-09-22 Thread Jim Meyering
On Thu, Sep 22, 2016 at 9:31 AM, Pádraig Brady wrote: > On 22/09/16 16:03, Jim Meyering wrote: >> I was intrigued to see my just-built-from-git gcc fail to compile who.c. >> >> It's probably too soon to accept a patch like this: in case gcc's >> static analysi

who.c vs gcc-7's improved buffer overrun check

2016-09-22 Thread Jim Meyering
I was intrigued to see my just-built-from-git gcc fail to compile who.c. It's probably too soon to accept a patch like this: in case gcc's static analysis is going to be improved enough that it can derive the invariant that the assert makes explicit. So, perhaps just for reference, for now, here'

Re: build fails due to 'lib/assert.h' on mac os x

2016-09-09 Thread Jim Meyering
On Fri, Sep 9, 2016 at 3:51 PM, Jim Meyering wrote: > On Fri, Sep 9, 2016 at 1:47 PM, Jim Meyering wrote: >> On Fri, Sep 9, 2016 at 1:29 PM, Jim Meyering wrote: >>> On Thu, Sep 8, 2016 at 7:33 PM, Assaf Gordon wrote: >>>> On 09/08/2016 04:40 PM, Jim Meyering wr

Re: build fails due to 'lib/assert.h' on mac os x

2016-09-09 Thread Jim Meyering
On Fri, Sep 9, 2016 at 1:47 PM, Jim Meyering wrote: > On Fri, Sep 9, 2016 at 1:29 PM, Jim Meyering wrote: >> On Thu, Sep 8, 2016 at 7:33 PM, Assaf Gordon wrote: >>> On 09/08/2016 04:40 PM, Jim Meyering wrote: >>>> >>>> On Wed, Sep 7,

Re: build fails due to 'lib/assert.h' on mac os x

2016-09-09 Thread Jim Meyering
On Fri, Sep 9, 2016 at 1:29 PM, Jim Meyering wrote: > On Thu, Sep 8, 2016 at 7:33 PM, Assaf Gordon wrote: >> On 09/08/2016 04:40 PM, Jim Meyering wrote: >>> >>> On Wed, Sep 7, 2016 at 10:17 PM, Assaf Gordon >>> wrote: >>>> >>>> $ make

Re: build fails due to 'lib/assert.h' on mac os x

2016-09-09 Thread Jim Meyering
On Thu, Sep 8, 2016 at 7:33 PM, Assaf Gordon wrote: > On 09/08/2016 04:40 PM, Jim Meyering wrote: >> >> On Wed, Sep 7, 2016 at 10:17 PM, Assaf Gordon >> wrote: >>> >>> $ make >>> [...] >>> make[2]: *** No rule to make target `lib/a

Re: build fails due to 'lib/assert.h' on mac os x

2016-09-08 Thread Jim Meyering
(GNU Autoconf) 2.69 > $ automake --version | head -n1 > automake (GNU automake) 1.14.1 Hi Assaf, Thanks for reporting that. I noticed the same failure on a Centos 7 system. I dug enough to find the probable cause+solution in the attached proposed patch: From 6f0c342317455f6f3d5cee243f9a6

Re: [PATCH] dircolors: recognize .zst and .tzst suffixes

2016-08-31 Thread Jim Meyering
On Wed, Aug 31, 2016 at 10:25 AM, Pádraig Brady wrote: > On 30/08/16 00:46, Jim Meyering wrote: >> The zstd compression tools are up and coming. This change teaches >> dircolors (and hence ls --color) about its suffixes. > > +1 > BTW, there is an updated just released ab

tr: two clean-up diffs

2016-08-29 Thread Jim Meyering
for consistency. Comments welcome: From 166fa24fc7fb632ea1187b01cf08ee743559da98 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 16 Sep 2015 20:07:42 -0700 Subject: [PATCH 1/2] tr: move decls "down" --- src/tr.c | 81 +--

[PATCH] gnulib: update to latest, to port to upcoming GCC 7

2016-08-29 Thread Jim Meyering
Without this gnulib update, I couldn't build coreutils with gcc-7-to-be. From b02a36d215105367ec31e5c1942c10e0d56db189 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 29 Aug 2016 21:11:36 -0700 Subject: [PATCH] gnulib: update to latest, to port to upcoming GCC 7 This fixes compil

[PATCH] dircolors: recognize .zst and .tzst suffixes

2016-08-29 Thread Jim Meyering
The zstd compression tools are up and coming. This change teaches dircolors (and hence ls --color) about its suffixes. From 3651aa44164855c7afba144fea80a6bdff817157 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 27 Jul 2016 09:30:02 -0700 Subject: [PATCH] dircolors: recognize .zst and

[PATCH] ptx: avoid new warning/error from upcoming gcc-7.x

2016-08-28 Thread Jim Meyering
60829 (experimental): src/ptx.c:1220:14: error: assuming signed overflow does not occur \ when simplifying conditional to constant [-Werror=strict-overflow] if (file_index > 0) From cb3922380d3763ebd1b9b5a513a3747ecbae3fae Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun

maint: skip a check when en_US.UTF-8 collation rules are broken

2016-07-25 Thread Jim Meyering
etlocale (LC_ALL, ""); int d = strcoll("J.b", "Ja"); printf ("%d\n", d); return 0; } $ gcc -Wall -W k.c && ./a.out -51 The "-51" comes from OS X's computation of '.' - 'a'. From f0f215b4f266bc38c5a9fc46725804b33

HACKING: suggest use of dnf, not yum

2016-06-23 Thread Jim Meyering
n of "dnf" before that of "yum". From 11e2e0fc95a9e75f170deec5fa038902826458e6 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 22 May 2016 11:59:24 -0700 Subject: [PATCH] maint: mention dnf, the yum(1) replacement * HACKING: Mention dnf rather than yum. * src/install.c (u

Re: [PATCH] yes: avoid redundant diagnostics on write error

2016-04-05 Thread Jim Meyering
On Tue, Apr 5, 2016 at 2:12 AM, Bernhard Voelker wrote: > On 04/04/2016 02:20 PM, Pádraig Brady wrote: >> * src/yes.c (main): For large inputs only write a single >> diagnostic for write errors. >> * tests/misc/yes.sh: Test when /dev/full is available. > > Nice catch! > > The patch per se LGTM ...

Re: Whats the reason to suppress short unicode characters in printf?

2016-04-04 Thread Jim Meyering
On Mon, Apr 4, 2016 at 7:43 PM, Mike Frysinger wrote: > the code as written has existed since it was first committed in Mar 2000: > http://git.savannah.gnu.org/cgit/coreutils.git/commit/?h=29d3ba4a7b42ed1b40b963b6047f2412ea4843b1 > although the Author says Jim, the ChangeLog file says Bruno Haible

Re: wc -c /proc /sys handling

2016-03-21 Thread Jim Meyering
On Mon, Mar 21, 2016 at 8:57 AM, Pádraig Brady wrote: > I was wondering if we should not penalize all normal files, > to handle the /proc and /sys approximate st_size edge case? > I.E. only do the seek to last block of file + read() when st_size % > PAGE_SIZE == 0 ? > > I did a quick check of /pro

patch-FYI: maint: remove gl/lib/reg*.c.diff; no longer needed

2016-03-15 Thread Jim Meyering
I'll push the attached shortly: From c18b3699e1b8c4ad2739761f2b9c306ff2303322 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 14 Mar 2016 08:59:56 -0700 Subject: [PATCH] maint: remove gl/lib/reg*.c.diff; no longer needed * gl/lib/regcomp.c.diff: Remove file, now that gnulib's

Re: ls output changes considered unacceptable

2016-02-17 Thread Jim Meyering
On Wed, Feb 17, 2016 at 8:46 AM, Mike Hodson wrote: >>On Tue, Feb 16, 2016 at 6:45 AM, Bernhard Voelker >>wrote: >>> On 02/16/2016 11:50 AM, Jason A. Donenfeld wrote: >>> [...] We don't want those single quotes. >> >> >> Who exactly is "we"? >> >> I can only speak for myself: I'm don't really ca

Re: suggested feautre: "date --debug" - print date parsing diagnostics

2016-01-21 Thread Jim Meyering
Same here. Thank you, Assaf! That will help avoid a lot of FAQs. On Jan 21, 2016 20:00, "Pádraig Brady" wrote: > On 21/01/16 06:17, Assaf Gordon wrote: > > Hello, > > > > What do you think about adding a "--debug" option to 'date' ? > > This will hopefully help users to diagnose incorrect usage w

Re: stty: problem if IXON enabled and DC3 char was received

2016-01-04 Thread Jim Meyering
On Mon, Jan 4, 2016 at 7:07 AM, Bernhard Voelker wrote: > On 01/04/2016 01:34 PM, Pádraig Brady wrote: >> >> --- a/NEWS >> +++ b/NEWS >> @@ -47,6 +47,9 @@ GNU coreutils NEWS >> -*- outline -*- >> is reusable by most shells, with non-printable characters escaped >> with the POSIX proposed $

Re: [PATCH] maint: remove form feed characters from sources

2015-12-13 Thread Jim Meyering
On Sun, Dec 13, 2015 at 6:41 PM, Pádraig Brady wrote: > On 14/12/15 01:57, Jim Meyering wrote: >> On Sun, Dec 13, 2015 at 12:21 PM, Pádraig Brady wrote: >>> maint: remove form feed characters from sources >>> >>> These are no longer useful and can impact viewi

Re: [PATCH] maint: remove form feed characters from sources

2015-12-13 Thread Jim Meyering
On Sun, Dec 13, 2015 at 12:21 PM, Pádraig Brady wrote: > maint: remove form feed characters from sources > > These are no longer useful and can impact viewing > patches in some mail programs for example. > > * src/cksum.c: Remove ^L characters. > * src/comm.c: Likewise. > * src/kill.c Likewise. >

Re: [PATCH] maint: fix incorrect spellings etc

2015-12-13 Thread Jim Meyering
Thanks for the fixes! Looks all fine, except maybe "Non-NULL" rather than "Non NULL"? The hyphen-using instances outnumber the space-using ones 30:2. And there are/were 4 instances of "nonnull".

Re: Coreutils-gotchas

2015-11-30 Thread Jim Meyering
On Mon, Nov 30, 2015 at 10:27 AM, Pádraig Brady wrote: > On 30/11/15 17:37, Eric Blake wrote: >> On 11/28/2015 11:34 PM, Assaf Gordon wrote: >>> On 11/29/2015 12:16 AM, Pádraig Brady wrote: >>> > I must collate some gotchas like this. Initial list started at: http://www.pixelbea

Re: [PATCH 2/2] build: support reproducible builds with consistant man pages

2015-11-27 Thread Jim Meyering
On Fri, Nov 27, 2015 at 5:49 AM, Pádraig Brady wrote: > Use a consistant date in the generated man pages > even if SOURCE_DATE_EPOCH is not set. > > * Makefile.am: Generate .timetamp in the tarball. > * man/local.mk: Pass .timestamp if available to help2man. > * man/dummy-man: Don't bother with th

Re: [platform-testers] new snapshot available: coreutils-8.23.237-eff51

2015-11-25 Thread Jim Meyering
On Wed, Nov 25, 2015 at 6:34 AM, Pádraig Brady wrote: > On 25/11/15 13:59, Jim Meyering wrote: >> On Wed, Nov 25, 2015 at 5:43 AM, Pádraig Brady wrote: >>> On 25/11/15 12:53, Joachim Schiele wrote: >>>> i've used this patch but then i hit this issue: &g

Re: [platform-testers] new snapshot available: coreutils-8.23.237-eff51

2015-11-25 Thread Jim Meyering
On Wed, Nov 25, 2015 at 5:43 AM, Pádraig Brady wrote: > On 25/11/15 12:53, Joachim Schiele wrote: >> i've used this patch but then i hit this issue: >> http://paste.ubuntu.com/13498376/ >> >> i don't have packaged makeinfo yet and i don't really care for the >> documentation at the moment. i didn'

<    1   2   3   4   5   6   7   8   9   10   >