Re: [PATCH 0/6] Patches to avoid use of make recursion in the 'src/' subdir

Stefano Lattarini wrote: > On 08/31/2012 03:57 PM, Jim Meyering wrote: >> Stefano Lattarini wrote: >> >>> On 08/31/2012 03:34 PM, Jim Meyering wrote: >>>> Stefano Lattarini wrote: >>>>> These should go on the top of my other pending seri

Re: [PATCH 0/6] Patches to avoid use of make recursion in the 'src/' subdir

Jim Meyering wrote: > Stefano Lattarini wrote: > >> On 08/31/2012 03:34 PM, Jim Meyering wrote: >>> Stefano Lattarini wrote: >>>> These should go on the top of my other pending series "[PATCH 0/7] Minor >>>> cleanup and refactoring": >>

Re: [PATCH 0/7] Minor cleanup and refactoring.

Stefano Lattarini wrote: > Found these when trying to convert 'src/' to a non-recursive setup. > I think they should be simple and uncontroversial enough to go into > the repository ASAP. Thanks. Pushed.

Re: [PATCH 0/6] Patches to avoid use of make recursion in the 'src/' subdir

Stefano Lattarini wrote: > These should go on the top of my other pending series "[PATCH 0/7] Minor > cleanup and refactoring": > > Thanks! Looking at these now. FYI, I pushed that other series an hour ago.

Re: [PATCH] scripts: add autotools-install, for those stuck with outdated tools

Stefano Lattarini wrote: > On 08/31/2012 10:58 AM, Jim Meyering wrote: >> FYI, this adds the autotools-install script, formerly at: >> >> http://people.redhat.com/meyering/autotools-install >> >> As the commit log says, it is a: >> >> New sc

Re: [PATCH] maint: make required gettext version consistent

Jim Meyering wrote: ... > No problem. This has made me realize that the recent > scripts/git-hooks/commit-msg change that was suppose to prevent > these is not working. I thought it would make "git am FILE" > fail whenever there is a Signed-off-by: line, but it does not.

Re: [PATCH] maint: make required gettext version consistent

Stefano Lattarini wrote: > On 08/31/2012 12:34 PM, Jim Meyering wrote: >> Jim Meyering wrote: >>> Stefano Lattarini wrote: >>>> * bootstrap.conf ($buildreq): Require gettext >= 0.18.1, consistently >>>> with the call to AM_GNU_GETTEXT_VERSION in c

Re: [PATCH] maint: make required gettext version consistent

Jim Meyering wrote: > Stefano Lattarini wrote: >> * bootstrap.conf ($buildreq): Require gettext >= 0.18.1, consistently >> with the call to AM_GNU_GETTEXT_VERSION in configure.ac. >> >> Signed-off-by: Stefano Lattarini >> --- >> bootstrap.conf |

Re: [PATCH] maint: make required gettext version consistent

Stefano Lattarini wrote: > * bootstrap.conf ($buildreq): Require gettext >= 0.18.1, consistently > with the call to AM_GNU_GETTEXT_VERSION in configure.ac. > > Signed-off-by: Stefano Lattarini > --- > bootstrap.conf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bootstra

Re: [PATCH 0/7] Minor cleanup and refactoring.

Stefano Lattarini wrote: > Found these when trying to convert 'src/' to a non-recursive setup. > I think they should be simple and uncontroversial enough to go into > the repository ASAP. > > Thanks, > Stefano > > -*-*-*- > > Stefano Lattarini (7): > build: move definition of 'all_programs' in

Re: [PATCH 7/7] maint: get rid of obsolete script 'cvsu'

Stefano Lattarini wrote: > It was useful only back when coreutils used CVS as its version > control system. > > * build-aux/cvsu: Delete. > * Makefile.am (EXTRA_DIST): Remove it. > > Signed-off-by: Stefano Lattarini > --- > Makefile.am| 1 - > build-aux/cvsu | 512 > --

Re: [PATCH] maint: fixup: don't distribute a non-existent file

Stefano Lattarini wrote: > On 08/31/2012 11:56 AM, Jim Meyering wrote: >> Stefano Lattarini wrote: >>> * tests/Makefile.am (EXTRA_DIST): Drop 'check.mk', which has been >>> removed (being merged into 'tests/Makefile.am') by recent ch

Re: [PATCH 3/7] build: require Automake >= 1.11.6

Bernhard Voelker wrote: > On 08/31/2012 10:16 AM, Jim Meyering wrote: >> wrote the commit log for you, too. >> Here's the result. I'll wait for your ACK: > > Thanks for wrapping that into a patch. > > I just noticed that there's still a stray > &

Re: [PATCH] maint: fixup: don't distribute a non-existent file

Stefano Lattarini wrote: > * tests/Makefile.am (EXTRA_DIST): Drop 'check.mk', which has been > removed (being merged into 'tests/Makefile.am') by recent changes. > > Signed-off-by: Stefano Lattarini > --- > tests/Makefile.am | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/Makefile.a

[PATCH] scripts: add autotools-install, for those stuck with outdated tools

rom c1495a1107871f451fd680d5c23b2c71af6e9971 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 31 Aug 2012 10:55:03 +0200 Subject: [PATCH] scripts: add autotools-install, for those stuck with outdated tools * scripts/autotools-install: New script, so you can always build from git-cloned sour

Re: [PATCH 3/7] build: require Automake >= 1.11.6

Erik Auerswald wrote: > On Fri, Aug 31, 2012 at 09:19:19AM +0200, Jim Meyering wrote: >> Bernhard Voelker wrote: >> > On 08/30/2012 02:13 PM, Stefano Lattarini wrote: >> >> Now that we use AM_TESTS_ENVIRONMENT, we should require at least >> >> Automake >

Re: [PATCH 3/7] build: require Automake >= 1.11.6

Bernhard Voelker wrote: ... > After finally getting autoconf+autmake working (and running bootstrap > etc in coreutils), a `make syntax-check` failed because of the Thanks for the quick work and sorry I forgot to run "make syntax-check" before pushing that. > renaming of the test scripts. > The a

Re: [PATCH 3/7] build: require Automake >= 1.11.6

Bernhard Voelker wrote: > On 08/30/2012 02:13 PM, Stefano Lattarini wrote: >> Now that we use AM_TESTS_ENVIRONMENT, we should require at least >> Automake >= 1.11.2; but since all the Automake version until 1.11.5 >> are vulnerable to CVE-2012-3386: >> >>

Re: [PATCH 4/7] tests: avoid use of '-T' in shebang line to enable perl taint mode

Stefano Lattarini wrote: > On 08/30/2012 04:21 PM, Jim Meyering wrote: >> Stefano Lattarini wrote: >>> * tests/rm/fail-eperm: Rename ... >>> * tests/rm/fail-eperm.xpl: ... like this >>> * tests/Makefile.am (TESTS): Adjust. >>> (TEST_EXTENSIONS): New,

Re: [PATCH 4/7] tests: avoid use of '-T' in shebang line to enable perl taint mode

Stefano Lattarini wrote: > * tests/rm/fail-eperm: Rename ... > * tests/rm/fail-eperm.xpl: ... like this > * tests/Makefile.am (TESTS): Adjust. > (TEST_EXTENSIONS): New, list '.xpl'. > (XPL_TEST_LOGS): New, run a perl test in tainted mode. > * tests/shell-or-perl: Simplify this script: we no longer

Re: [PATCH] build: enable the 'subdir-objects' Automake option globally

Stefano Lattarini wrote: > On 08/30/2012 04:06 PM, Jim Meyering wrote: >> >> Thanks. That looks fine. >> I adjusted log message wording to this (also removing S-o-b): >> > Thanks. One minor nit (against myself) ... > >> This is not strictly req

Re: [PATCH] build: enable the 'subdir-objects' Automake option globally

Stefano Lattarini wrote: > This is not strictly required now (it will be once we make more > parts of the coreutils build system non-recursive), but enabling > it early help to ensure that we don't unwittingly introduce any > incompatibility or subtle breakage that might get to bite us later. > > *

Re: [PATCH] scripts: git commit message hook: prohibit use of "Signed-off-by

Stefano Lattarini wrote: > On 08/30/2012 03:36 PM, Jim Meyering wrote: >> Stefano Lattarini wrote: >>> Jim Meyering wrote: >>>> >>>> I noticed a lot of Signed-off-by: lines in Stefano's series. >>>> This makes our no-S-o-b policy

Re: [PATCH] scripts: git commit message hook: prohibit use of "Signed-off-by

Stefano Lattarini wrote: ... > Or better again, those "Signed-off-by:" > lines that refer to the author or the committer? As far as I've seen here, the only Signed-off-by lines have always matched the name of the committer. If we decide there is something to be gained by allowing "Signed-off-by:

Re: [PATCH] scripts: git commit message hook: prohibit use of "Signed-off-by

Stefano Lattarini wrote: > Jim Meyering wrote: >> >> I noticed a lot of Signed-off-by: lines in Stefano's series. >> This makes our no-S-o-b policy more apparent: ... >> + $buf =~ /^ *Signed-off-by:/i >> +and return q(do not use "Signed-off-by:&quo

Re: [PATCH 00/22] Towards a non-recursive build system for coreutils?

Stefano Lattarini wrote: > On 08/30/2012 02:16 PM, Jim Meyering wrote: >> >> I've merged those into the appropriate change sets, removed all >> Signed-off-by: lines and made a few minor wording changes. >> Please review the differences. If you're happy

[PATCH] scripts: git commit message hook: prohibit use of "Signed-off-by:"

I noticed a lot of Signed-off-by: lines in Stefano's series. This makes our no-S-o-b policy more apparent: >From 4f76f9b42ad71df40f1f714f2ecfb1e4b6cd7078 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 30 Aug 2012 13:07:10 +0200 Subject: [PATCH] scripts: git commit message hook:

Re: [PATCH] tests: remove useless defn of REPLACE_GETCWD from TESTS_ENVIRONMENT

Stefano Lattarini wrote: > It's last use had been removed in commit v8.12-3-g3ed91fc of 2011-04-28, > "tests: remove useless test: misc/pwd-unreadable-parent". > > * tests/check.mk (TESTS_ENVIRONMENT): Adjust. > > Signed-off-by: Stefano Lattarini > --- > tests/check.mk | 1 - > 1 file changed, 1

Re: [PATCH 00/22] Towards a non-recursive build system for coreutils?

Stefano Lattarini wrote: > On 08/30/2012 01:14 AM, Jim Meyering wrote: >> Thanks for all the work. >> >> Would you please mail to me (or to the list) the concatenation of those >> patches Thanks again. I've begun looking at these changes, so here's some pr

Re: [PATCH] tests: misc/sort-exit-early: do not run as root.

Nick Alcock wrote: > This test requires an unwritable input and an unreadable output, > so will fail if the testsuite is being run as root, and should > not be run in this case. > --- > tests/misc/sort-exit-early | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/misc/sort-exit-early

Re: sort: new feature: use environment variable to set buffer size

Pádraig Brady wrote: > Thanks for the detailed rationale, however > the existing env variables are significant to more utils than sort(1). > I.E. they're generally system level settings, rather than command level. > Also sort -S is very portable, even though not standardised. > solaris' sort(1) has

Re: [PATCH 00/22] Towards a non-recursive build system for coreutils?

Stefano Lattarini wrote: > On 08/30/2012 01:14 AM, Jim Meyering wrote: >> >> Thanks for all the work. >> >> Would you please mail to me (or to the list) the concatenation of those >> patches >> > Sorry to be dense, but: what does "concatenation&quo

Re: [PATCH 00/22] Towards a non-recursive build system for coreutils?

Stefano Lattarini wrote: > [NOTE: I'm sending this to the main coreutils for lack of a dedicated >"coreutils-patch" list; I hope it's OK!] > > OK, these are the easy pieces actually, but we have to start somewhere. > This series consists of: > > - some preparatory refactorings; > - the

Re: [PATCH] df: allow translators to reorder "1K-blocks" header

Nguyễn Thái Ngọc Duy wrote: > * src/df.c (get_header): Mark "%s-%s" for translation. Give > translators some hint what it is for. Thank you! Pushed with minor tweaks.

Re: RFE: hash-type in sum utils

Eric Blake wrote: > On 08/22/2012 10:05 AM, Pádraig Brady wrote: >> On 08/22/2012 03:00 PM, Ondrej Oprala wrote: >>> Hi, I haven't heard from this thread since I posted the last patch, >>> are there still things to correct or should I consider it closed? >> >> The --tag description in the texinfo i

Re: [PATCH] tests: correct print_ver_ arguments

Bernhard Voelker wrote: > On 08/22/2012 12:41 PM, Jim Meyering wrote: >> Thanks! >> When there are two or more offending files, it would be nice >> to report all of them before failing. The above stops at the first. > > Yes, alright. Here comes the amended version. .

Re: RFE: hash-type in sum utils

Ondrej Oprala wrote: > Hi, I haven't heard from this thread since I posted the last patch, > are there still things to correct or should I consider it closed? There are still things to fix. For example, in your new test, +for i in 'a\b' 'a\' a$'\n'b a$'\t'b; do + :> "$i" + md5sum --tag "$

Re: [PATCH] tests: correct print_ver_ arguments

Bernhard Voelker wrote: > On 08/22/2012 09:57 AM, Jim Meyering wrote: >> Bernhard Voelker wrote: > >>> Subject: [PATCH] tests: correct print_ver_ arguments > >> Nice! > > Thanks. > >> What do you think about adding a syntax-check to run that script? &

Re: [PATCH] tests: correct print_ver_ arguments

Bernhard Voelker wrote: > I noticed (too late) that the new tests/du/bind-mount-dir-cycle > calls print_ver_ with rm as argument instead of du. > A little script found other wrong uses, too. ... > Subject: [PATCH] tests: correct print_ver_ arguments > > Some tests have been derived from other tests

Re: du bogus warning with bind mounts

[Re: http://bugs.gnu.org/11844 du: continue processing after bind-mount induced dir-cycle ] Ondrej Oprala wrote: > Sure, that looks great. Thanks for the help. I added this to the log: * THANKS.in: Update. This implements the proposal in http://bugs.gnu.org/11844. Originally reporte

bug#9780: sort -u throws out non-duplicates

Paul Eggert wrote: > On 08/17/2012 01:31 PM, Jim Meyering wrote: >> So we definitely have a *second* bug here. > > Yes, I noticed. It definitely counts as a double-ouch. > I'm glad the bug report prompted us to read this code > more carefully. > > My latest pat

bug#10926: [PATCH] timer-time: fix linking order with pthreads/rt

Pádraig Brady wrote: > On 08/18/2012 10:57 PM, Mike Frysinger wrote: >> When statically linking pthreads with rt, the current order is: >> -lpthread -lrt >> >> But when statically linking, the -lpthread will be discarded as it >> isn't used. It needs to come after the -lrt. >> >> * m4/timer_t

Re: du bogus warning with bind mounts

Jim Meyering wrote: > Jim Meyering wrote: >> Ondrej Oprala wrote: >>>>From d8eab7abdf19b668065ff8be3700c9966eefdc39 Mon Sep 17 00:00:00 2001 >>> From: Ondrej Oprala >>> Date: Thu, 9 Aug 2012 17:34:09 +0200 ... >>From 491914627db04fe789bfdbf796f9be21198

coreutils-8.19 released (fixes sort -u data loss bugs)

changes to this release: Bernhard Voelker (1) Jim Meyering (9) Krzysztof Goj (1) Paul Eggert (2) Special thanks to Rasmus Borup Hansen for reporting the sort -u problem along with a reproducer, and to Paul Eggert for spotting the second bug and for his minimal patch that fixed both bugs

Re: new snapshot available: coreutils-8.18.10-46444

Jim Meyering wrote: > sort -u data loss... who would have guessed? > This is not your typical coreutils bug. > Actually, there were *two* sort -u bugs. > How many more are lurking? > > Anyhow, here's a snapshot. > Please give this a try, and report any problems. > I wi

[PATCH] tests: avoid split/filter test failure on very low-mem system

I saw this test fail when run via make -j2 on a low-memory arm-based system, but not when run in isolation. >From e44943a25e4a225568b51a411f18ba61134d3eb3 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 19 Aug 2012 17:34:04 +0200 Subject: [PATCH] tests: avoid split/filter test failure

new snapshot available: coreutils-8.18.10-46444

df: fail when the mount list is required but cannot be read Jim Meyering (7): maint: post-release administrivia maint: fix comment grammar to placate make syntax-check maint: correct a stale comment in sort.c tests: reverse args in Coreutils.pm-invoked diff, for consis

Re: du bogus warning with bind mounts

Jim Meyering wrote: > Ondrej Oprala wrote: >>>From d8eab7abdf19b668065ff8be3700c9966eefdc39 Mon Sep 17 00:00:00 2001 >> From: Ondrej Oprala >> Date: Thu, 9 Aug 2012 17:34:09 +0200 >> Subject: [PATCH] du: Fix an issue with bogus warnings on bind-mounted >> d

Re: du bogus warning with bind mounts

Ondrej Oprala wrote: >>From d8eab7abdf19b668065ff8be3700c9966eefdc39 Mon Sep 17 00:00:00 2001 > From: Ondrej Oprala > Date: Thu, 9 Aug 2012 17:34:09 +0200 > Subject: [PATCH] du: Fix an issue with bogus warnings on bind-mounted > directories > > * NEWS: Mention the fix. > * src/du.c: Include "moun

Re: du bogus warning with bind mounts

Ondrej Oprala wrote: > Oops, I seem to have forgotten to add the test > to the last patch I sent, sorry about the trouble, here > it is again with the test added. Oh. I see you've already sent it. Nevermind.

Re: du bogus warning with bind mounts

Ondrej Oprala wrote: > Hi, here's the amended patch. ... > Subject: [PATCH] du: Fix an issue with bogus warnings on bind-mounted > directories > > * NEWS: Mention the fix. > * src/du.c: Include "mountlist.h". > (di_mnt): New global set. > (fill_mount_table): New function. > (hash_ins): Add H

[PATCH 2/3] maint: correct a stale comment in sort.c

From: Jim Meyering * src/sort.c (fillbuf): Fix comment typo. x2nrealloc no longer doubles the size of its input buffer. --- src/sort.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sort.c b/src/sort.c index 85d7869..d362dc5 100644 --- a/src/sort.c +++ b/src/sort.c

[PATCH 1/3] maint: fix comment grammar to placate make syntax-check

From: Jim Meyering * src/remove.c (rm_fts): s/can not/cannot/ --- src/remove.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remove.c b/src/remove.c index 61ba5f3..c4972ac 100644 --- a/src/remove.c +++ b/src/remove.c @@ -419,7 +419,7 @@ rm_fts (FTS *fts, FTSENT *ent

fix a few nits

Here are three tiny changes: [PATCH 1/3] maint: fix comment grammar to placate make syntax-check [PATCH 2/3] maint: correct a stale comment in sort.c [PATCH 3/3] tests: reverse args in Coreutils.pm-invoked diff, for consistency src/remove.c |2 +- src/sort.c |2 +- tests/Co

[PATCH 3/3] tests: reverse args in Coreutils.pm-invoked diff, for consistency

From: Jim Meyering * tests/Coreutils.pm (_compare_files): Reverse diff arguments so that we invoke diff -c $expected $actual, which is consistent with how init.sh-using tests invoke "compare exp out". --- tests/Coreutils.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Re: Various tests give illusory results

Ondrej Oprala wrote: > here's the new patch...I hope it's all alright now. > And sorry about not mentioning Bernhard in the first place, > it just didn't occur to me. ... > Subject: [PATCH] tests: Add error checking for root-only tests running > setuidgid > > * NEWS: Mention the test improvement.

Re: [PATCH] rm: new option (-d) to remove empty directories

Krzysztof Goj wrote: >> Please add a NEWS entry, a description of the new option >> in coreutils.texi and adjust for the issues below >> [...] > > Thanks for the review. I've updated the patch, it's attached. Thanks for contributing. I adjusted the wording and punctuation in the commit log and NEW

Re: Various tests give illusory results

Ondrej Oprala wrote: ... > Subject: [PATCH] tests: Add error checking for root-only tests running > setuidgid > > * NEWS: Mention the fix. > * tests/init.cfg: Modify the require_root_ function to check > for setuidgid calls and proper permissions. > --- > NEWS | 6 ++ > tests/init.

Re: [PATCH] df: fail when the mount list cannot be read but is needed [was: new snapshot available: coreutils-8.17.70-1bacb4]

Bernhard Voelker wrote: > On 08/14/2012 10:51 AM, Jim Meyering wrote: >> Here is the patch that I expect to squash in. >> Most are nits, but there was an exploitable bit >> of (debugging?) code in the new test. >> >> diff --git a/NEWS b/NEWS >> index 0f63ddf

Re: [PATCH] df: fail when the mount list cannot be read but is needed [was: new snapshot available: coreutils-8.17.70-1bacb4]

Bernhard Voelker wrote: > On 08/09/2012 01:53 PM, Bernhard Voelker wrote: >> Here's a proposed patch. > > Oops, sorry, one of the cases in the new test failed. > I fixed it: > > -LD_PRELOAD=./k.so df --total || fail=1 > +LD_PRELOAD=./k.so df --total && fail=1 > > Additionally, as this patch didn't

Re: [PATCH] rm: new option (-d) to remove empty directories

thread in archive for > those who want more context: > > http://lists.gnu.org/archive/html/coreutils/2012-01/msg00111.html > > I've rebased my patch against current master and fixed the tests as > Jim Meyering have suggested. New patch is attached, it can also be > viewed

coreutils-8.18 released [stable]

"the beginning") and relatively obscure bugs. See the NEWS below for a brief summary. Thanks to everyone who has contributed! The following people contributed changes to this release: Andrew D Warshall (1) Bernhard Voelker (4) Bruno Haible (1) Erik Auerswald (1) Jim Meyering

Re: du bogus warning with bind mounts

Ondrej Oprala wrote: > I've redone the patch to use mountlist instead of mntent, added the > !remote && !dummy > condition and created a test for it. Great! Thanks. Some of this feedback is nit-picking, but there are more important changes, too. ... > Subject: [PATCH] du: Fix an issue with bog

Re: du bogus warning with bind mounts

hash_ins (di_mnt, buf->st_ino, buf->st_dev); > +} Also, please heed my advice inspired by Paul's comment (next in that thread) that stat may hang on non-local mounts: http://marc.info/?l=coreutils-bug&m=134130469407031&w=2 Paul Eggert wrote: > O

Re: du bogus warning with bind mounts

Ondrej Oprala wrote: > Hi, I've changed the du util a bit to reflect > the proposed solution here > http://marc.info/?l=coreutils-bug&m=134124896022426&w=2 . Thanks for working on this! > I'm not sure about the XDEV checking though. Shouldn't the matching > st_dev numbers be enough to know both f

Re: new snapshot available: coreutils-8.17.70-1bacb4

Pádraig Brady wrote: > On 08/08/2012 05:07 PM, Jim Meyering wrote: >> Bernhard Voelker wrote: >> >>> On 08/08/2012 05:43 PM, Pádraig Brady wrote: >>> >>>> +require_mount_list_() >>>> +{ >>>> + df >/dev/null

Re: new snapshot available: coreutils-8.17.70-1bacb4

Bernhard Voelker wrote: > On 08/08/2012 05:43 PM, Pádraig Brady wrote: > >> +require_mount_list_() >> +{ >> + df >/dev/null 2>&1 || >> +skip_ "Unable to read the list of mounted file systems." >> +} >> + > > Hmm, I think this is not enough: df can also fail due to other reasons, > e.g. when a

Re: new snapshot available: coreutils-8.17.70-1bacb4

Pádraig Brady wrote: > On 08/08/2012 03:57 PM, Jim Meyering wrote: >> Here's a preview of what coreutils-8.18 should look like. >> >> I noticed one spurious test failure reported by the Nixos Hydra autobuilder: >> >> http://hydra.nixos.org/build/2924158 >

new snapshot available: coreutils-8.17.70-1bacb4

doc: document multiplier for dd number options like count=N df: warn if soon-to-be-removed --megabyte option is used df: fix exit code and error messages with --total Bruno Haible (1): doc: clarify meaning of '-parodd' in stty help Erik Auerswald (1): doc

Re: cp preserves mode with --no-preserve=mode

Bernhard Voelker wrote: > On 08/07/2012 12:59 PM, Ondrej Oprala wrote: >> Hi, >> here's the new patch. Everything should be in order now. > As the new variable "explicit_no_preserve" is only used for > the mode, I find its name is a bit confusing (because it's > too general). Good point. Ondřej

Re: cp preserves mode with --no-preserve=mode

Pádraig Brady wrote: > On 08/06/2012 12:29 PM, Ondrej Oprala wrote: >> Hi, I'd like to propose a fix for a bug mentioned in the redhat bugzilla: >> https://bugzilla.redhat.com/show_bug.cgi?id=755508 >> The patch adds another boolean instead of a proposed tristate, thus not >> upsetting any existing

Re: cp preserves mode with --no-preserve=mode

Ondrej Oprala wrote: > Hi, I'd like to propose a fix for a bug mentioned in the redhat bugzilla: > https://bugzilla.redhat.com/show_bug.cgi?id=755508 > The patch adds another boolean instead of a proposed tristate, thus not > upsetting any existing code. Hi Ondřej, Thanks for working on this. You

[PATCH] tests: printf-surprise: avoid unwarranted failure on FreeBSD 9.0

The printf-surprise test failed on FreeBSD 9.0 not because of a printf problem per se, but because the cost of running printf there has just surpassed our semi-arbitrary ulimit of 10,000KiB. Here's the fix: >From c3b777e07d175713745a162d60acd11af427e159 Mon Sep 17 00:00:00 2001 From: Jim

Re: coreutils-8.15.74-be17e3 build failure on FreeBSD 9.0 x86

Nelson H. F. Beebe wrote: > My normal builds of coreutils-8.15.74-be17e3 failed on > FreeBSD 9.0 x86 like this: ... > That got further, then died with > > CCLD timeout > timeout.o: In function `settimeout': > /local/build/cc/coreutils-8.15.74-be17e3/src/timeout.c:118: undefi

Re: [PATCH] df: fix exit code and ensure printing "unprocessed" msg when totaling

Pádraig Brady wrote: > Pushed with Jim's improvement. > http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commit;h=3b8139e I see you adjusted the test and fixed this for me: - if (exit_status == 0 && ! file_systems_processed) + if (exit_status == EXIT_SUCCESS && ! file_systems_processed) Tha

Re: [PATCH] df: fix exit code and ensure printing "unprocessed" msg when totaling

Pádraig Brady wrote: > On 08/04/2012 12:11 AM, Bernhard Voelker wrote: ... >> Subject: [PATCH] df: fix exit code and ensure printing "unprocessed" msg when >> totaling >> >> When the combination of the file system options with given files or >> devices does not lead to output, "df --total" would e

Re: [PATCH] truncate: don't leak a file descriptor with --ref=PIPE

Pádraig Brady wrote: > On 08/04/2012 11:26 AM, Jim Meyering wrote: >> Pádraig Brady wrote: >>> On 08/04/2012 10:06 AM, Jim Meyering wrote: >> ... >>>> Subject: [PATCH] truncate: don't leak a file descriptor with --ref=PIPE >>>> >>>

Re: [PATCH] truncate: don't leak a file descriptor with --ref=PIPE

Pádraig Brady wrote: > On 08/04/2012 10:06 AM, Jim Meyering wrote: ... >> Subject: [PATCH] truncate: don't leak a file descriptor with --ref=PIPE >> >> * src/truncate.c (main): For a user who makes the mistake of >> using a non-seekable file as a reference for the d

Re: [PATCH] tests: avoid FP ulimit failure with valgrind-wrapped tools

Jim Meyering wrote: > All ulimit-requiring tests would be skipped > when running against valgrind-wrapped tools. > This adjusts the heuristic to avoid that: > > Subject: [PATCH] tests: avoid FP ulimit failure with valgrind-wrapped tools > > * tests/init.cfg (require_ulimit_)

Re: [PATCH] split: plug a nominal leak

Pádraig Brady wrote: > On 08/03/2012 01:53 PM, Jim Meyering wrote: >> I ran "make check" on valgrind-wrapped tools (took most of a day on a >> 6/12-core system) and saw split at the top of the list of "definitely lost >> buffer" leaks. So far, the only

[PATCH] truncate: don't leak a file descriptor with --ref=PIPE

FYI, >From 0ee727e612ae202e5b47e39062f6604d65a76074 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 4 Aug 2012 11:02:40 +0200 Subject: [PATCH] truncate: don't leak a file descriptor with --ref=PIPE * src/truncate.c (main): For a user who makes the mistake of using a non-seekable

[PATCH] tail: do not let failed lseek cause immediate exit

it is to trigger an lseek failure on a known-open-and-valid read-only file descriptor, maybe it doesn't deserve one. WDYT? >From a714f9a350a3b69aec03ee2a0c74b627d8138542 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 25 Jul 2012 18:26:35 +0200 Subject: [PATCH] tail: do not let

[PATCH] tests: avoid FP ulimit failure with valgrind-wrapped tools

All ulimit-requiring tests would be skipped when running against valgrind-wrapped tools. This adjusts the heuristic to avoid that: >From 5367b398b0dc203e84e4210c647f4b03ed4dcfe2 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 2 Aug 2012 19:12:18 +0200 Subject: [PATCH] tests: avoid

[PATCH] split: plug a nominal leak

tract us further: >From 32f7dd1ad64165cdde0c8d90997c2a6445965c00 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 2 Aug 2012 19:31:36 +0200 Subject: [PATCH 1/2] split: free a lines/round-robin chunk processing buffer * src/split.c (lines_rr): Plug a harmless leak. --- src/split.c | 1 +

Re: [PATCH] tail: avoid rare error-path FD leak

Pádraig Brady wrote: > On 08/02/2012 03:52 PM, Jim Meyering wrote: >> FYI, >> >> Subject: [PATCH] tail: avoid rare error-path FD leak >> >> * src/tail.c (tail_forever): Close FD to avoid leak after a >> failed fstat. ... > static analysis or eagle eyes? &

[PATCH] tail: avoid rare error-path FD leak

FYI, >From 81806035310c5c16b1b11c88709bf066305ed160 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 27 Jul 2012 23:42:05 +0200 Subject: [PATCH] tail: avoid rare error-path FD leak * src/tail.c (tail_forever): Close FD to avoid leak after a failed fstat. --- src/tail.c | 1 + 1 f

Re: coreutils-8.18: ready for release?

Jim Meyering wrote: > Now that util-linux has made a v2.22-rc release with improved "su"[1], > I'd like to make a coreutils release (which removes su altogether). > > There's enough new code in md5sum --tag that I will defer > adding that feature until after 8.

Re: sort -V and accents

Pierre-Jean wrote: > Jim Meyering wrote: > >> Pierre-Jean wrote: > >> > I'm trying to sort a file containing accents and numbers, >> > but can't find a way to do this correctly: > > >> The trick is to specify sorting with "-f" fo

coreutils-8.18: ready for release?

Now that util-linux has made a v2.22-rc release with improved "su"[1], I'd like to make a coreutils release (which removes su altogether). There's enough new code in md5sum --tag that I will defer adding that feature until after 8.18. I've just remembered that I have one more minor tail fix, and

Re: RFE: hash-type in sum utils

Ondrej Oprala wrote: > Here's the patch. Thanks. I've adjusted the NEWS patch so that it only inserts the new 3-line entry (rather than also removing many others), and adjusted the wording slightly: diff --git a/NEWS b/NEWS index f1255ea..51ebc63 100644 --- a/NEWS +++ b/NEWS @@ -41,6 +41,10 @@ GN

Re: sort -V and accents

Pierre-Jean wrote: > I'm trying to sort a file containing accents and numbers, > but can't find a way to do this correctly: > > - Without -V option, accents are correctly sorted, but not > numbers. > - With -V option, numbers are correctly sorted, but not > accents. > > Here is an example: > >

Re: RFE: hash-type in sum utils

Ondrej Oprala wrote: > Ok, I've made all the changes(though I had to change print_filename > contents around a bit, it wouldn't > print out the file name properly unless the name consisted of '\n' and > \' chars only), added a NEWS entry > and a simple test to md5sum-bsd. Syntax-check was also fine

Re: RFE: hash-type in sum utils

Ondrej Oprala wrote: > Alright, I've redone it so now the hashes create and expect GNU escaping > in both the BSD and GNU output format. > I left the --tag format indication of text files to be a space before > the algo. name > so far, but I can change that if needed. ... > +static const char *con

Re: Bug#682969: timeout 20 /usr/sbin/ntpd -g -q gives wrong return code

Pádraig Brady wrote: > On 07/27/2012 05:56 PM, Jim Meyering wrote: ... >> When I try to trigger such misbehavior, timeout seems to work fine >> on a system (Fedora 17) with a working timer_settime function: >> >> $ timeout 2 date --set=$(LC_ALL=C date -d 10\

Re: Bug#682969: timeout 20 /usr/sbin/ntpd -g -q gives wrong return code

Goswin von Brederlow wrote: > Package: coreutils > Version: 8.13-3.2 > Severity: normal > File: /usr/bin/timeout > > I'm trying to set the time during boot. Unfortunately ntpd hangs forever > if the timeserver is unavailable. So I added a timeout to it so the > system still continues to boot withou

[PATCH] tail: avoid misleading diagnostic upon fstat failure

. Not worth trying to write a test, IMHO. >From a6e8e3a3e116f2cdaa452eb66032d912092d0026 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 25 Jul 2012 18:35:36 +0200 Subject: [PATCH] tail: avoid misleading diagnostic upon fstat failure * src/tail.c (check_fspec): Save fstat-induced errno

Re: removing coreutils' final strncpy uses

Jim Meyering wrote: > ohav chochmah wrote: >> Why not reuse memccpy (in glibc)? as in 'memccpy(to, from, '\0', size)'. >> Not only for sake of reusing, but memccpy is highly optimized for >> ia64, and may be optimized for other arches in the future. > &

[PATCH 1/2] maint: rm: remove unused static-inlined functions

saved_errno; - return is_dir; -} - /* Return true if FILENAME is a non-directory. Otherwise, including the case in which lstat fails, return false. *ST is FILENAME's tstatus. -- 1.7.11.2.194.g7bdb748 >From f173180a96cf497682274436781febcf4c86f974 Mon Sep 17 00:00:00 2001 From: J

Re: ls files that were modified on a certain date

Enda wrote: > How do I list files that were modified on (or since) a certain date? One simple way is to create a time stamp file with the specified date, and then to use find's "-newer FILE" predicate: touch -d '1999-01-01 12:00:01' stamp find dir ... -type f -newer stamp

Re: rename: move command from util-linux to coreutils

Erik Auerswald wrote: > On 07/17/2012 05:10 PM, Sami Kerola wrote: >> On Mon, Jul 9, 2012 at 3:27 PM, Jim Meyering wrote: >> [...] >>> A few things should be changed regardless. >>> For consistency with other GNU tools: >>> >>>s/--test/--dr

<    1   2   3   4   5   6   7   8   9   10   >