id.c comments [was: [PATCH] doc: update for ISO/IEC 80000-13]

2011-11-15 Thread Eric Blake
On 11/15/2011 11:25 AM, Bob Proulx wrote: >>> Perhaps it may be easier to read as: >>> >>> On GNU/Hurd hosts, identification functions (getuid, getgid, etc.) can >>> fail and return -1. >> >> I prefer that, too. Thanks. >> Would you care to adjust it? > > Perhaps the latin abbrevation can be remo

Re: [PATCH] doc: update for ISO/IEC 80000-13

2011-11-15 Thread Bob Proulx
Jim Meyering wrote: > Eric Blake wrote: > > Also, I tend to see "etc." used primarily in the context of a list, when > > at least two items have already been given (so that it is more obvious > > what similar items have been omitted from the list). It's hard to see > > what similar functions are i

Re: [PATCH] doc: update for ISO/IEC 80000-13

2011-11-15 Thread Jim Meyering
Eric Blake wrote: > On 11/15/2011 10:25 AM, Bjartur Thorlacius wrote: >> On Tue, 15 Nov 2011 16:28:35 -, Paul Eggert wrote: >>> >>> + /* On GNU/Hurd hosts, getuid etc. can fail and return -1. >>> + However, on GNU/Linux hosts, uid_t is an unsigned value and >>> + getuid e

Re: [PATCH] doc: update for ISO/IEC 80000-13

2011-11-15 Thread Bob Proulx
Bjartur Thorlacius wrote: > Paul Eggert wrote: > >+ /* On GNU/Hurd hosts, getuid etc. can fail and return -1. > >+ However, on GNU/Linux hosts, uid_t is an unsigned value and > >+ getuid etc. can return the positive value (uid_t) -1. To > >+ handle both cases correctly

Re: [PATCH] doc: update for ISO/IEC 80000-13

2011-11-15 Thread Eric Blake
On 11/15/2011 10:25 AM, Bjartur Thorlacius wrote: > On Tue, 15 Nov 2011 16:28:35 -, Paul Eggert wrote: >> >> + /* On GNU/Hurd hosts, getuid etc. can fail and return -1. >> + However, on GNU/Linux hosts, uid_t is an unsigned value and >> + getuid etc. can return the positiv

Re: [PATCH] doc: update for ISO/IEC 80000-13

2011-11-15 Thread Bjartur Thorlacius
On Tue, 15 Nov 2011 16:28:35 -, Paul Eggert wrote: + /* On GNU/Hurd hosts, getuid etc. can fail and return -1. + However, on GNU/Linux hosts, uid_t is an unsigned value and + getuid etc. can return the positive value (uid_t) -1. To + handle both cases correctly

Re: [PATCH] doc: update for ISO/IEC 80000-13

2011-11-15 Thread Paul Eggert
On 11/15/11 08:36, Jim Meyering wrote: > Undoing it seems best. OK, done.

Re: [PATCH] doc: update for ISO/IEC 80000-13

2011-11-15 Thread Jim Meyering
Paul Eggert wrote: > I checked in the following, intending only to update the > documentation for SI prefixes etc., but now I see that by mistake > I also committed the patch to id.c that was still under discussion. > Sorry about that. If you would like me to undo the change to src/id.c > please l

[PATCH] doc: update for ISO/IEC 80000-13

2011-11-15 Thread Paul Eggert
I checked in the following, intending only to update the documentation for SI prefixes etc., but now I see that by mistake I also committed the patch to id.c that was still under discussion. Sorry about that. If you would like me to undo the change to src/id.c please let me know -- I am tempted to