Re: make check-expensive [was: [PATCH] rm, du, chmod, chown, chgrp: use much less memory for large directories]

2011-09-19 Thread Jim Meyering
Bernhard Voelker wrote: > On 08/24/2011 12:24 PM, Jim Meyering wrote: >> If you would find some testing-related make shortcut to be useful, >> please propose a patch, preferably without modifying all tests ;-) > > From 4c994ab75a3d0c2eda5aa9246388dccf5058f250 Mon Sep 17 00:00:00 2001 > From: Bernha

Re: make check-expensive [was: [PATCH] rm, du, chmod, chown, chgrp: use much less memory for large directories]

2011-08-24 Thread Bernhard Voelker
On 08/24/2011 12:24 PM, Jim Meyering wrote: If you would find some testing-related make shortcut to be useful, please propose a patch, preferably without modifying all tests ;-) From 4c994ab75a3d0c2eda5aa9246388dccf5058f250 Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Wed, 24 Aug 2011

Re: make check-expensive [was: [PATCH] rm, du, chmod, chown, chgrp: use much less memory for large directories]

2011-08-24 Thread Jim Meyering
Bernhard Voelker wrote: > On 08/24/2011 11:42 AM, Jim Meyering wrote: >> Bernhard Voelker wrote: >> >>> On 08/24/2011 10:49 AM, Jim Meyering wrote: Voelker, Bernhard wrote: > BTW: Wouldn't this test deserve a proper make target, e.g. > "make check-expensive"? Yes, good idea.

Re: make check-expensive [was: [PATCH] rm, du, chmod, chown, chgrp: use much less memory for large directories]

2011-08-24 Thread Bernhard Voelker
On 08/24/2011 11:42 AM, Jim Meyering wrote: Bernhard Voelker wrote: On 08/24/2011 10:49 AM, Jim Meyering wrote: Voelker, Bernhard wrote: BTW: Wouldn't this test deserve a proper make target, e.g. "make check-expensive"? Yes, good idea. That would make it easier to run just those test. Howe

Re: make check-expensive [was: [PATCH] rm, du, chmod, chown, chgrp: use much less memory for large directories]

2011-08-24 Thread Jim Meyering
Bernhard Voelker wrote: > On 08/24/2011 10:49 AM, Jim Meyering wrote: >> Voelker, Bernhard wrote: >>> BTW: Wouldn't this test deserve a proper make target, e.g. >>> "make check-expensive"? >> >> Yes, good idea. >> That would make it easier to run just those test. >> >> However, hard-coding the lis

make check-expensive [was: [PATCH] rm, du, chmod, chown, chgrp: use much less memory for large directories]

2011-08-24 Thread Bernhard Voelker
On 08/24/2011 10:49 AM, Jim Meyering wrote: Voelker, Bernhard wrote: BTW: Wouldn't this test deserve a proper make target, e.g. "make check-expensive"? Yes, good idea. That would make it easier to run just those test. However, hard-coding the list of expensive and very-expensive tests would r

Re: [PATCH] rm, du, chmod, chown, chgrp: use much less memory for large directories

2011-08-24 Thread Jim Meyering
Voelker, Bernhard wrote: > Jim Meyering wrote: > >> Voelker, Bernhard wrote: >> >> > Jim Meyering wrote: >> > >> > +++ b/tests/rm/4-million-entry-dir >> > ... >> > +# Put 4M files in a directory. >> > +mkdir d && cd d || framework_failure_ >> > +seq 400|xargs touch || framework_failure_ >> > +

RE: [PATCH] rm, du, chmod, chown, chgrp: use much less memory for large directories

2011-08-23 Thread Voelker, Bernhard
Jim Meyering wrote: > Voelker, Bernhard wrote: > > > Jim Meyering wrote: > > > > +++ b/tests/rm/4-million-entry-dir > > ... > > +# Put 4M files in a directory. > > +mkdir d && cd d || framework_failure_ > > +seq 400|xargs touch || framework_failure_ > > + > > +cd .. > > + > > +# Restricted to

Re: [PATCH] rm, du, chmod, chown, chgrp: use much less memory for large directories

2011-08-23 Thread Jim Meyering
Voelker, Bernhard wrote: > Jim Meyering wrote: > > +++ b/tests/rm/4-million-entry-dir > ... > +# Put 4M files in a directory. > +mkdir d && cd d || framework_failure_ > +seq 400|xargs touch || framework_failure_ > + > +cd .. > + > +# Restricted to 50MB, rm from coreutils-8.12 would fail with a

RE: [PATCH] rm, du, chmod, chown, chgrp: use much less memory for large directories

2011-08-23 Thread Voelker, Bernhard
Jim Meyering wrote: +++ b/tests/rm/4-million-entry-dir ... +# Put 4M files in a directory. +mkdir d && cd d || framework_failure_ +seq 400|xargs touch || framework_failure_ + +cd .. + +# Restricted to 50MB, rm from coreutils-8.12 would fail with a +# diagnostic like "rm: fts_read failed: Canno

Re: [PATCH] rm, du, chmod, chown, chgrp: use much less memory for large directories

2011-08-19 Thread Jim Meyering
Erik Auerswald wrote: > there is a typo in the NEWS entry: > > On Fri, Aug 19, 2011 at 06:24:46PM +0200, Jim Meyering wrote: >> [...] >> + fts-using tools (rm, du, chmod, chgrp, chown, chcon) no longer use memory >> + proportional to the number of entries in each directory they process. >> + Bef

Re: [PATCH] rm, du, chmod, chown, chgrp: use much less memory for large directories

2011-08-19 Thread Erik Auerswald
Hi, there is a typo in the NEWS entry: On Fri, Aug 19, 2011 at 06:24:46PM +0200, Jim Meyering wrote: > [...] > + fts-using tools (rm, du, chmod, chgrp, chown, chcon) no longer use memory > + proportional to the number of entries in each directory they process. > + Before, rm -rf 4-million-entr

[PATCH] rm, du, chmod, chown, chgrp: use much less memory for large directories

2011-08-19 Thread Jim Meyering
rm, du, chmod, chown, chgrp: use much less memory for large directories For details, see the gnulib commit, http://git.sv.gnu.org/cgit/gnulib.git/commit/?id=47cb657e * tests/rm/4-million-entry-dir: New test. * tests/Makefile.am (TESTS): Add it. * NEWS (Bug fixes): Mention it. * gnulib: Update to