Re: [PATCH] scripts: git commit message hook: prohibit use of "Signed-off-by

2012-08-30 Thread Jim Meyering
Stefano Lattarini wrote: > On 08/30/2012 03:36 PM, Jim Meyering wrote: >> Stefano Lattarini wrote: >>> Jim Meyering wrote: I noticed a lot of Signed-off-by: lines in Stefano's series. This makes our no-S-o-b policy more apparent: >> ... + $buf =~ /^ *Signed-off-by:/i +

Re: [PATCH] scripts: git commit message hook: prohibit use of "Signed-off-by

2012-08-30 Thread Stefano Lattarini
On 08/30/2012 03:36 PM, Jim Meyering wrote: > Stefano Lattarini wrote: >> Jim Meyering wrote: >>> >>> I noticed a lot of Signed-off-by: lines in Stefano's series. >>> This makes our no-S-o-b policy more apparent: > ... >>> + $buf =~ /^ *Signed-off-by:/i >>> +and return q(do not use "Signed-off

Re: [PATCH] scripts: git commit message hook: prohibit use of "Signed-off-by

2012-08-30 Thread Jim Meyering
Stefano Lattarini wrote: ... > Or better again, those "Signed-off-by:" > lines that refer to the author or the committer? As far as I've seen here, the only Signed-off-by lines have always matched the name of the committer. If we decide there is something to be gained by allowing "Signed-off-by:

Re: [PATCH] scripts: git commit message hook: prohibit use of "Signed-off-by

2012-08-30 Thread Jim Meyering
Stefano Lattarini wrote: > Jim Meyering wrote: >> >> I noticed a lot of Signed-off-by: lines in Stefano's series. >> This makes our no-S-o-b policy more apparent: ... >> + $buf =~ /^ *Signed-off-by:/i >> +and return q(do not use "Signed-off-by:"); >> + >>return ''; >> } >> > Sigh, this wi

Re: [PATCH] scripts: git commit message hook: prohibit use of "Signed-off-by

2012-08-30 Thread Stefano Lattarini
00 > Subject: [PATCH] scripts: git commit message hook: prohibit use of > "Signed-off-by:" > > * scripts/git-hooks/commit-msg: Reject a commit log message that > contains "Signed-off-by:". > --- > scripts/git-hooks/commit-msg | 3 +++ > 1 file changed

[PATCH] scripts: git commit message hook: prohibit use of "Signed-off-by:"

2012-08-30 Thread Jim Meyering
I noticed a lot of Signed-off-by: lines in Stefano's series. This makes our no-S-o-b policy more apparent: >From 4f76f9b42ad71df40f1f714f2ecfb1e4b6cd7078 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 30 Aug 2012 13:07:10 +0200 Subject: [PATCH] scripts: git commit message hook: