Re: [PATCH] tests: fix FP in ls/stat-free-color.sh

2021-04-23 Thread Bernhard Voelker
On 4/23/21 11:21 AM, Pádraig Brady wrote: > Perfect, thank you. Thanks for the review - pushed at: https://git.sv.gnu.org/cgit/coreutils.git/commit/?id=b7091093bb Have a nice day, Berny

Re: [PATCH] tests: fix FP in ls/stat-free-color.sh

2021-04-23 Thread Pádraig Brady
On 22/04/2021 19:19, Bernhard Voelker wrote: On 4/21/21 3:32 PM, Pádraig Brady wrote: On 20/04/2021 23:15, Bernhard Voelker wrote: This FP was seen on latest openSUSE - logfile attached. The patch fixes it. Okay to push? Jim also noticed that on Fedora 34. Oh so it's stating stdout. Could

Re: [PATCH] tests: fix FP in ls/stat-free-color.sh

2021-04-22 Thread Bernhard Voelker
But adding -a for the reference invocation is also good. Updated patch attached. OK? Thanks & have a nice day, Berny >From b7091093bb6505c33279f9bc940b2e94763a6e5d Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Wed, 21 Apr 2021 00:12:00 +0200 Subject: [PATCH] tests: fix FP in ls/st

Re: [PATCH] tests: fix FP in ls/stat-free-color.sh

2021-04-21 Thread Pádraig Brady
On 20/04/2021 23:15, Bernhard Voelker wrote: This FP was seen on latest openSUSE - logfile attached. The patch fixes it. Okay to push? Jim also noticed that on Fedora 34. Oh so it's stating stdout. Could you change the "1" in your commit summary to STDOUT_FILENO as that makes the system

[PATCH] tests: fix FP in ls/stat-free-color.sh

2021-04-20 Thread Bernhard Voelker
This FP was seen on latest openSUSE - logfile attached. The patch fixes it. Okay to push? Have a nice day, Berny >From c7c328c26a73504006f97d38b85b3178382acc0e Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Wed, 21 Apr 2021 00:12:00 +0200 Subject: [PATCH] tests: fix FP in ls/stat-f