Re: [coreutils] [PATCH] csplit: avoid buffer overrun when writing more than 999 files

2010-11-23 Thread Pádraig Brady
On 10/11/10 13:49, Pádraig Brady wrote: > On 10/11/10 13:25, Jim Meyering wrote: >> Here's a patch. >> >> The included test is a little unusual. >> Unlike most such tests, this one does not fail without the fix. >> However, running it against a valgrind-wrapped does expose the bug. >> >> Any sugges

Re: [coreutils] [PATCH] csplit: avoid buffer overrun when writing more than 999 files

2010-11-10 Thread Pádraig Brady
On 10/11/10 13:25, Jim Meyering wrote: > Here's a patch. > > The included test is a little unusual. > Unlike most such tests, this one does not fail without the fix. > However, running it against a valgrind-wrapped does expose the bug. > > Any suggestions for a better way (even O/S- or kernel-spe

[coreutils] [PATCH] csplit: avoid buffer overrun when writing more than 999 files

2010-11-10 Thread Jim Meyering
Here's a patch. The included test is a little unusual. Unlike most such tests, this one does not fail without the fix. However, running it against a valgrind-wrapped does expose the bug. Any suggestions for a better way (even O/S- or kernel-specific) to test this would be most welcome. While I'm