Re: [coreutils] [PATCH] sort: fix some --compress reaper bugs

2010-12-14 Thread Pádraig Brady
On 14/12/10 18:20, Paul Eggert wrote: > On 14/12/10 09:55, Jim Meyering wrote: >> It'd be a shame to make everyone sleep even one second for NFS. > > Well, it is marked as an _expensive_ test. :-) > > On 12/14/10 02:07, Pádraig Brady wrote: >> If the subprocesses were reparented to the shell, >>

Re: [coreutils] [PATCH] sort: fix some --compress reaper bugs

2010-12-14 Thread Jim Meyering
Paul Eggert wrote: > On 14/12/10 09:55, Jim Meyering wrote: >> It'd be a shame to make everyone sleep even one second for NFS. > > Well, it is marked as an _expensive_ test. :-) > > On 12/14/10 02:07, Pádraig Brady wrote: >> If the subprocesses were reparented to the shell, >> then one could just

Re: [coreutils] [PATCH] sort: fix some --compress reaper bugs

2010-12-14 Thread Paul Eggert
Come to think of it the bug fix should probably be in NEWS, so I also pushed this. >From 6600f34d0985865df72004229cec3874d5125c94 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 14 Dec 2010 10:21:49 -0800 Subject: [PATCH] sort: document --compress reaper fixes * NEWS: Document the --compre

Re: [coreutils] [PATCH] sort: fix some --compress reaper bugs

2010-12-14 Thread Paul Eggert
On 14/12/10 09:55, Jim Meyering wrote: > It'd be a shame to make everyone sleep even one second for NFS. Well, it is marked as an _expensive_ test. :-) On 12/14/10 02:07, Pádraig Brady wrote: > If the subprocesses were reparented to the shell, > then one could just `wait`. I don't know how to d

Re: [coreutils] [PATCH] sort: fix some --compress reaper bugs

2010-12-14 Thread Pádraig Brady
On 14/12/10 09:55, Jim Meyering wrote: > Paul Eggert wrote: >> +# Give compression subprocesses time to react when 'sort' exits. >> +# Otherwise, under NFS, when 'sort' unlinks the temp files and they >> +# are renamed to .nfs instead of being removed, the parent cleanup >> +# of this director

Re: [coreutils] [PATCH] sort: fix some --compress reaper bugs

2010-12-14 Thread Jim Meyering
Paul Eggert wrote: > I found and fixed some bugs and simplified some code > while trying (and so far, failing) to fix the hang reported at the end of > . > I installed the following, and plan to look into that hang some more. >

[coreutils] [PATCH] sort: fix some --compress reaper bugs

2010-12-13 Thread Paul Eggert
I found and fixed some bugs and simplified some code while trying (and so far, failing) to fix the hang reported at the end of . I installed the following, and plan to look into that hang some more. * src/sort.c (uintptr): New