Re: [PATCH V2] Add support for cksum --algorithm [sm3]

2021-09-17 Thread Eric Blake
On Tue, Sep 14, 2021 at 01:29:41PM +0100, Pádraig Brady wrote: > Now the tagged format doesn't support encoding --binary or --text mode, > but that got me investigating whether cksum should support these at all. > My conclusion is that it should not, and just use binary everywhere. > I.e. cksum

Re: [PATCH V2] Add support for cksum --algorithm [sm3]

2021-09-14 Thread Jim Meyering
On Tue, Sep 14, 2021 at 5:36 AM Pádraig Brady wrote: > On 12/09/2021 23:01, Pádraig Brady wrote: > > On 12/09/2021 19:13, Pádraig Brady wrote: > >> This patch set refactors all digest implementations > >> to their own modules, all interfaced through digest.c. > >> All file operations and

Re: [PATCH V2] Add support for cksum --algorithm [sm3]

2021-09-14 Thread Pádraig Brady
On 12/09/2021 23:01, Pádraig Brady wrote: On 12/09/2021 19:13, Pádraig Brady wrote: This patch set refactors all digest implementations to their own modules, all interfaced through digest.c. All file operations and diagnostics are done in digest.c. All digests are made available through `cksum

Re: [PATCH V2] Add support for cksum --algorithm [sm3]

2021-09-12 Thread Pádraig Brady
On 12/09/2021 19:13, Pádraig Brady wrote: This patch set refactors all digest implementations to their own modules, all interfaced through digest.c. All file operations and diagnostics are done in digest.c. All digests are made available through `cksum -a`. Also we add support for SM3 through

[PATCH V2] Add support for cksum --algorithm [sm3]

2021-09-12 Thread Pádraig Brady
This patch set refactors all digest implementations to their own modules, all interfaced through digest.c. All file operations and diagnostics are done in digest.c. All digests are made available through `cksum -a`. Also we add support for SM3 through `cksum -a sm3` only. V2 changes: - Various

Re: Add support for cksum --algorithm [sm3]

2021-09-09 Thread Bernhard Voelker
On 9/9/21 17:01, Pádraig Brady wrote: > If one updated getopt/argmatch to support something like: > >prog=$(cksum --?algo=md5 && echo 'cksum -a md5' || echo 'md5sum') > > That would be a bit more elegant, but less widely supported. > > Anyway all this is a general issue, > that cksum shouldn't

Re: Add support for cksum --algorithm [sm3]

2021-09-09 Thread Pádraig Brady
On 09/09/2021 14:23, Michael Stone wrote: On Thu, Sep 09, 2021 at 01:20:56PM +0100, Pádraig Brady wrote: On 09/09/2021 00:39, Michael Stone wrote: On Tue, Sep 07, 2021 at 04:45:23PM +0100, Pádraig Brady wrote: This patch set refactors all digest implementations to their own modules, all

Re: Add support for cksum --algorithm [sm3]

2021-09-09 Thread Michael Stone
On Thu, Sep 09, 2021 at 01:20:56PM +0100, Pádraig Brady wrote: On 09/09/2021 00:39, Michael Stone wrote: On Tue, Sep 07, 2021 at 04:45:23PM +0100, Pádraig Brady wrote: This patch set refactors all digest implementations to their own modules, all interfaced through digest.c. All file operations

Re: Add support for cksum --algorithm [sm3]

2021-09-09 Thread Pádraig Brady
On 09/09/2021 00:39, Michael Stone wrote: On Tue, Sep 07, 2021 at 04:45:23PM +0100, Pádraig Brady wrote: This patch set refactors all digest implementations to their own modules, all interfaced through digest.c. All file operations and diagnostics are done in digest.c. All digests are made

Re: Add support for cksum --algorithm [sm3]

2021-09-08 Thread Michael Stone
On Tue, Sep 07, 2021 at 04:45:23PM +0100, Pádraig Brady wrote: This patch set refactors all digest implementations to their own modules, all interfaced through digest.c. All file operations and diagnostics are done in digest.c. All digests are made available through `cksum -a`. Also we add

Re: Add support for cksum --algorithm [sm3]

2021-09-08 Thread Jim Meyering
On Tue, Sep 7, 2021 at 5:47 PM Pádraig Brady wrote: > This patch set refactors all digest implementations > to their own modules, all interfaced through digest.c. > All file operations and diagnostics are done in digest.c. > All digests are made available through `cksum -a`. > Also we add support

Add support for cksum --algorithm [sm3]

2021-09-07 Thread Pádraig Brady
This patch set refactors all digest implementations to their own modules, all interfaced through digest.c. All file operations and diagnostics are done in digest.c. All digests are made available through `cksum -a`. Also we add support for SM3 through `cksum -a sm3` only.