Re: Lint-related patches for coreutils

2022-02-01 Thread Pádraig Brady
On 01/02/2022 06:20, Paul Eggert wrote: On 1/31/22 13:48, Pádraig Brady wrote: src/expr.c: In function 'single_binary_main_expr': error: function might be candidate for attribute 'noreturn' OK, thanks, running in single-binary found some other issues too, plus one actual-albeit-minor memory le

Re: Lint-related patches for coreutils

2022-01-31 Thread Paul Eggert
On 1/31/22 13:48, Pádraig Brady wrote: src/expr.c: In function 'single_binary_main_expr': error: function might be candidate for attribute 'noreturn' OK, thanks, running in single-binary found some other issues too, plus one actual-albeit-minor memory leak in df that wasn't found with a norma

Re: Lint-related patches for coreutils

2022-01-31 Thread Paul Eggert
On 1/31/22 13:48, Pádraig Brady wrote: src/expr.c: In function 'single_binary_main_expr': error: function might be candidate for attribute 'noreturn'   [-Werror=suggest-attribute=noreturn] note: in definition of macro 'main' Ouch. A simple fix is to disable that warning for single-binary buil

Re: Lint-related patches for coreutils

2022-01-31 Thread Pádraig Brady
On 31/01/2022 21:48, Pádraig Brady wrote: On 31/01/2022 20:16, Paul Eggert wrote: I went through a lint pass for Coreutils and installed the attached patches. `make syntax-check` does often find issues, and is worth running before each push I just pushed the following fix up: diff --git a/sr

Re: Lint-related patches for coreutils

2022-01-31 Thread Pádraig Brady
On 31/01/2022 20:16, Paul Eggert wrote: I went through a lint pass for Coreutils and installed the attached patches. These fix only one or two real (albeit unlikely and/or technical) bugs. Most of them remove "#ifdef lint"s or "IF_LINT"s that should no longer be needed with modern GCC and runtime

Lint-related patches for coreutils

2022-01-31 Thread Paul Eggert
I went through a lint pass for Coreutils and installed the attached patches. These fix only one or two real (albeit unlikely and/or technical) bugs. Most of them remove "#ifdef lint"s or "IF_LINT"s that should no longer be needed with modern GCC and runtimes, the idea being to lessen the differ