Re: bug#6554: [PATCH] split: Additional suffix for split (bug#6554)

2012-02-19 Thread Pádraig Brady
On 02/19/2012 06:30 PM, Jérémy Compostella wrote: >> On 02/19/2012 12:54 PM, Jérémy Compostella wrote: >> > Pádraig, >> > >> > I replaced --suffix with --additional-suffix and made some cleaning. >> > >> > Feel free to comment the attached patch. >> >> Logic is perfect again. > Thanks :) > >> I a

Re: bug#6554: [PATCH] split: Additional suffix for split (bug#6554)

2012-02-19 Thread Jérémy Compostella
> On 02/19/2012 12:54 PM, Jérémy Compostella wrote: > > Pádraig, > > > > I replaced --suffix with --additional-suffix and made some cleaning. > > > > Feel free to comment the attached patch. > > Logic is perfect again. Thanks :) > I adjusted the help output a little like: > > - -a, --suffix-lengt

Re: bug#6554: [PATCH] split: Additional suffix for split (bug#6554)

2012-02-19 Thread Pádraig Brady
On 02/19/2012 12:54 PM, Jérémy Compostella wrote: > Pádraig, > > I replaced --suffix with --additional-suffix and made some cleaning. > > Feel free to comment the attached patch. Logic is perfect again. I adjusted the help output a little like: - -a, --suffix-length=N use suffixes of length

Re: bug#6554: [PATCH] split: Additional suffix for split (bug#6554)

2012-02-19 Thread Jérémy Compostella
Pádraig, I replaced --suffix with --additional-suffix and made some cleaning. Feel free to comment the attached patch. Cheers, Jérémy From bd80ac876c64fa0fac409b24311d30bd43d34dbd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Compostella?= Date: Sun, 19 Feb 2012 13:52:47 +0100 Su

Re: bug#6554: [PATCH] split: Additional suffix for split (bug#6554)

2012-02-18 Thread Pádraig Brady
On 02/18/2012 02:51 PM, Jérémy Compostella wrote: >> That's a good point. --additional-suffix is better. >> >> Note csplit has a more general --suffix-format option >> (which can be shortened to --suffix). >> So one can do: --suffix="%02d.txt". >> However that's only possible, because csplit >> su

Re: bug#6554: [PATCH] split: Additional suffix for split (bug#6554)

2012-02-18 Thread Jérémy Compostella
> That's a good point. --additional-suffix is better. > > Note csplit has a more general --suffix-format option > (which can be shortened to --suffix). > So one can do: --suffix="%02d.txt". > However that's only possible, because csplit > supports only numeric suffixes. > > However, this is startin

Re: bug#6554: [PATCH] split: Additional suffix for split (bug#6554)

2012-02-18 Thread Pádraig Brady
On 02/18/2012 12:52 PM, Jérémy Compostella wrote: > All, > > I'm continuing with this feature implementation. Getting advantage on my > newly acquired experience on this project I made some changes in my > implementation. > > Now I have a concern about the option name "--suffix". I think the > --

Re: bug#6554: [PATCH] split: Additional suffix for split (bug#6554)

2012-02-18 Thread Jérémy Compostella
All, I'm continuing with this feature implementation. Getting advantage on my newly acquired experience on this project I made some changes in my implementation. Now I have a concern about the option name "--suffix". I think the --suffix-length, --numeric-suffixes and the new --suffix are confusi

Re: bug#6554: [PATCH] split: Additional suffix for split (bug#6554)

2012-02-06 Thread Jérémy Compostella
Pádraig, all, I took into account general comments on my commits. I attached the improved patch for feature. Improvements are: - Add by file description, - I put back accents on my name (Jérémy instead of Jeremy), - I referenced from who this feature was requested. Cheers, Jérémy --- >From 81e12

Re: bug#6554: [PATCH] split: Additional suffix for split (bug#6554)

2012-01-29 Thread Jérémy Compostella
On 01/28/2012 00:00 AM, Pádraig Brady wrote: > On 01/28/2012 11:57 PM, Jérémy Compostella wrote: [...] > >> I should note that --suffix is incompatible > >> with a variable length generated suffix. > >> I.E. one that would allow for arbitrary sized input: > >> http://lists.gnu.org/archive/html/bug-

Re: bug#6554: [PATCH] split: Additional suffix for split (bug#6554)

2012-01-28 Thread Pádraig Brady
On 01/28/2012 11:57 PM, Jérémy Compostella wrote: > Pádraig Brady wrotes: >> Thanks a lot for working on this. > >> Could you give a real world example where >> you find this useful, just for the record. > It's useful in some cases where the chunk files type is known. As for > example, when I spl

Re: bug#6554: [PATCH] split: Additional suffix for split (bug#6554)

2012-01-28 Thread Jérémy Compostella
Pádraig Brady wrotes: > Thanks a lot for working on this. > Could you give a real world example where > you find this useful, just for the record. It's useful in some cases where the chunk files type is known. As for example, when I split a file which is a concatenation of several bitmap files of

Re: bug#6554: [PATCH] split: Additional suffix for split (bug#6554)

2012-01-28 Thread Pádraig Brady
On 01/27/2012 05:28 PM, Jérémy Compostella wrote: > Eric, Peng, others, > >> On 06/15/2010 09:23 PM, Peng Yu wrote: >>> I need to add an additional common suffix to the files splited by >>> split. Right now, I have to use mv to do so. But I feel it is >>> convenient to have an option to add the su