On 02/17/2012 05:56 PM, Jérémy Compostella wrote:
> I attached the new patch. I tried to make it as simple as possible but
> feel free to comment.
Thanks!
I just grouped the operations in next_file_name() a little for clarity,
tweaked a couple of strings, and pushed.
cheers,
Pádraig.
> Thanks for continuing with this.
> One general thing that might both improve
> and simplify the implementation, is to
> not to convert from string to int at all.
>
> I.E. when processing the arg, just validate like:
> if (strlen (optarg) != strspn (optarg, suffix_alphabet))
> error()
> else
>
On 02/16/2012 09:30 PM, Jérémy Compostella wrote:
> Pádraig, all,
>
> I rebased my branch for this feature and make the syntax-check
> success. I attached the new patch which I hope will satisfy you.
>
> Feel free to comment it, I will take into account whatever you want.
Thanks for continuing w
Pádraig, all,
I rebased my branch for this feature and make the syntax-check
success. I attached the new patch which I hope will satisfy you.
Feel free to comment it, I will take into account whatever you want.
Cheers,
Jérémy
From 9e90f6f26ab85fac2b1599804e31b78aaac42370 Mon Sep 17 00:00:00 200
Pádraig, all,
I took into account general comments on my commits. I attached the
improved patch for feature. Improvements are:
- Add by file description,
- I put back accents on my name (Jérémy instead of Jeremy),
- I referenced from who this feature was requested.
I added a new dedicated tests s
