bug#59901: Valgrind Memory Error

2022-12-10 Thread Pádraig Brady
tag 59901 notabug close 59901 stop On 08/12/2022 03:44, Ridwan Shariffdeen wrote: Hi, Running valgrind on src/split with the following command reports a memory error. I have attached the valgrind output (i.e. Use of uninitialised value) I couldn't repro this here, and `src/split` above

Re: [PATCH] tee: Add --pipe-check to allow instantly detecting closed outputs

2022-12-10 Thread Carl Edquist
On Fri, 9 Dec 2022, Carl Edquist wrote: On Fri, 9 Dec 2022, Arsen Arsenović wrote: ... Also, i suspect that the pipe_check option can be disabled if the _input_ is a regular file (or block device), since (i think) these always show up as ready for reading. (This check would only need to be

Re: [PATCH] tee: Add --pipe-check to allow instantly detecting closed outputs

2022-12-10 Thread Carl Edquist
On Fri, 9 Dec 2022, Carl Edquist wrote: A quick note, this check only needs to be done a total of once per output, it shouldn't be done inside iopoll(), which would result in an additional redundant fstat() per read(). Could this be handled by get_next_out? Sure, either in that function

Re: [PATCH] tee: Add --pipe-check to allow instantly detecting closed outputs

2022-12-10 Thread Carl Edquist via GNU coreutils General Discussion
On Fri, 9 Dec 2022, Carl Edquist wrote: On Fri, 9 Dec 2022, Arsen Arsenović wrote: Originally i had imagined (or hoped) that this broken-pipe detection could also be used for sockets (that was how the issue came up for me), but it seems the semantics for sockets are different than for