Re: [PATCH] maint: remove form feed characters from sources

2015-12-13 Thread Jim Meyering
On Sun, Dec 13, 2015 at 12:21 PM, Pádraig Brady wrote: > maint: remove form feed characters from sources > > These are no longer useful and can impact viewing > patches in some mail programs for example. > > * src/cksum.c: Remove ^L characters. > * src/comm.c: Likewise. > * src/kill.c Likewise. >

Re: [PATCH] maint: remove form feed characters from sources

2015-12-13 Thread Jim Meyering
On Sun, Dec 13, 2015 at 6:41 PM, Pádraig Brady wrote: > On 14/12/15 01:57, Jim Meyering wrote: >> On Sun, Dec 13, 2015 at 12:21 PM, Pádraig Brady wrote: >>> maint: remove form feed characters from sources >>> >>> These are no longer useful and can impact viewi

Re: stty: problem if IXON enabled and DC3 char was received

2016-01-04 Thread Jim Meyering
On Mon, Jan 4, 2016 at 7:07 AM, Bernhard Voelker wrote: > On 01/04/2016 01:34 PM, Pádraig Brady wrote: >> >> --- a/NEWS >> +++ b/NEWS >> @@ -47,6 +47,9 @@ GNU coreutils NEWS >> -*- outline -*- >> is reusable by most shells, with non-printable characters escaped >> with the POSIX proposed $

Re: suggested feautre: "date --debug" - print date parsing diagnostics

2016-01-21 Thread Jim Meyering
Same here. Thank you, Assaf! That will help avoid a lot of FAQs. On Jan 21, 2016 20:00, "Pádraig Brady" wrote: > On 21/01/16 06:17, Assaf Gordon wrote: > > Hello, > > > > What do you think about adding a "--debug" option to 'date' ? > > This will hopefully help users to diagnose incorrect usage w

Re: ls output changes considered unacceptable

2016-02-17 Thread Jim Meyering
On Wed, Feb 17, 2016 at 8:46 AM, Mike Hodson wrote: >>On Tue, Feb 16, 2016 at 6:45 AM, Bernhard Voelker >>wrote: >>> On 02/16/2016 11:50 AM, Jason A. Donenfeld wrote: >>> [...] We don't want those single quotes. >> >> >> Who exactly is "we"? >> >> I can only speak for myself: I'm don't really ca

patch-FYI: maint: remove gl/lib/reg*.c.diff; no longer needed

2016-03-15 Thread Jim Meyering
I'll push the attached shortly: From c18b3699e1b8c4ad2739761f2b9c306ff2303322 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 14 Mar 2016 08:59:56 -0700 Subject: [PATCH] maint: remove gl/lib/reg*.c.diff; no longer needed * gl/lib/regcomp.c.diff: Remove file, now that gnulib's

Re: wc -c /proc /sys handling

2016-03-21 Thread Jim Meyering
On Mon, Mar 21, 2016 at 8:57 AM, Pádraig Brady wrote: > I was wondering if we should not penalize all normal files, > to handle the /proc and /sys approximate st_size edge case? > I.E. only do the seek to last block of file + read() when st_size % > PAGE_SIZE == 0 ? > > I did a quick check of /pro

Re: Whats the reason to suppress short unicode characters in printf?

2016-04-04 Thread Jim Meyering
On Mon, Apr 4, 2016 at 7:43 PM, Mike Frysinger wrote: > the code as written has existed since it was first committed in Mar 2000: > http://git.savannah.gnu.org/cgit/coreutils.git/commit/?h=29d3ba4a7b42ed1b40b963b6047f2412ea4843b1 > although the Author says Jim, the ChangeLog file says Bruno Haible

Re: [PATCH] yes: avoid redundant diagnostics on write error

2016-04-05 Thread Jim Meyering
On Tue, Apr 5, 2016 at 2:12 AM, Bernhard Voelker wrote: > On 04/04/2016 02:20 PM, Pádraig Brady wrote: >> * src/yes.c (main): For large inputs only write a single >> diagnostic for write errors. >> * tests/misc/yes.sh: Test when /dev/full is available. > > Nice catch! > > The patch per se LGTM ...

HACKING: suggest use of dnf, not yum

2016-06-23 Thread Jim Meyering
n of "dnf" before that of "yum". From 11e2e0fc95a9e75f170deec5fa038902826458e6 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 22 May 2016 11:59:24 -0700 Subject: [PATCH] maint: mention dnf, the yum(1) replacement * HACKING: Mention dnf rather than yum. * src/install.c (u

maint: skip a check when en_US.UTF-8 collation rules are broken

2016-07-25 Thread Jim Meyering
etlocale (LC_ALL, ""); int d = strcoll("J.b", "Ja"); printf ("%d\n", d); return 0; } $ gcc -Wall -W k.c && ./a.out -51 The "-51" comes from OS X's computation of '.' - 'a'. From f0f215b4f266bc38c5a9fc46725804b33

[PATCH] ptx: avoid new warning/error from upcoming gcc-7.x

2016-08-28 Thread Jim Meyering
60829 (experimental): src/ptx.c:1220:14: error: assuming signed overflow does not occur \ when simplifying conditional to constant [-Werror=strict-overflow] if (file_index > 0) From cb3922380d3763ebd1b9b5a513a3747ecbae3fae Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun

[PATCH] dircolors: recognize .zst and .tzst suffixes

2016-08-29 Thread Jim Meyering
The zstd compression tools are up and coming. This change teaches dircolors (and hence ls --color) about its suffixes. From 3651aa44164855c7afba144fea80a6bdff817157 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 27 Jul 2016 09:30:02 -0700 Subject: [PATCH] dircolors: recognize .zst and

[PATCH] gnulib: update to latest, to port to upcoming GCC 7

2016-08-29 Thread Jim Meyering
Without this gnulib update, I couldn't build coreutils with gcc-7-to-be. From b02a36d215105367ec31e5c1942c10e0d56db189 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 29 Aug 2016 21:11:36 -0700 Subject: [PATCH] gnulib: update to latest, to port to upcoming GCC 7 This fixes compil

tr: two clean-up diffs

2016-08-29 Thread Jim Meyering
for consistency. Comments welcome: From 166fa24fc7fb632ea1187b01cf08ee743559da98 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 16 Sep 2015 20:07:42 -0700 Subject: [PATCH 1/2] tr: move decls "down" --- src/tr.c | 81 +--

Re: [PATCH] dircolors: recognize .zst and .tzst suffixes

2016-08-31 Thread Jim Meyering
On Wed, Aug 31, 2016 at 10:25 AM, Pádraig Brady wrote: > On 30/08/16 00:46, Jim Meyering wrote: >> The zstd compression tools are up and coming. This change teaches >> dircolors (and hence ls --color) about its suffixes. > > +1 > BTW, there is an updated just released ab

Re: build fails due to 'lib/assert.h' on mac os x

2016-09-08 Thread Jim Meyering
(GNU Autoconf) 2.69 > $ automake --version | head -n1 > automake (GNU automake) 1.14.1 Hi Assaf, Thanks for reporting that. I noticed the same failure on a Centos 7 system. I dug enough to find the probable cause+solution in the attached proposed patch: From 6f0c342317455f6f3d5cee243f9a6

Re: build fails due to 'lib/assert.h' on mac os x

2016-09-09 Thread Jim Meyering
On Thu, Sep 8, 2016 at 7:33 PM, Assaf Gordon wrote: > On 09/08/2016 04:40 PM, Jim Meyering wrote: >> >> On Wed, Sep 7, 2016 at 10:17 PM, Assaf Gordon >> wrote: >>> >>> $ make >>> [...] >>> make[2]: *** No rule to make target `lib/a

Re: build fails due to 'lib/assert.h' on mac os x

2016-09-09 Thread Jim Meyering
On Fri, Sep 9, 2016 at 1:29 PM, Jim Meyering wrote: > On Thu, Sep 8, 2016 at 7:33 PM, Assaf Gordon wrote: >> On 09/08/2016 04:40 PM, Jim Meyering wrote: >>> >>> On Wed, Sep 7, 2016 at 10:17 PM, Assaf Gordon >>> wrote: >>>> >>>> $ make

Re: build fails due to 'lib/assert.h' on mac os x

2016-09-09 Thread Jim Meyering
On Fri, Sep 9, 2016 at 1:47 PM, Jim Meyering wrote: > On Fri, Sep 9, 2016 at 1:29 PM, Jim Meyering wrote: >> On Thu, Sep 8, 2016 at 7:33 PM, Assaf Gordon wrote: >>> On 09/08/2016 04:40 PM, Jim Meyering wrote: >>>> >>>> On Wed, Sep 7,

Re: build fails due to 'lib/assert.h' on mac os x

2016-09-09 Thread Jim Meyering
On Fri, Sep 9, 2016 at 3:51 PM, Jim Meyering wrote: > On Fri, Sep 9, 2016 at 1:47 PM, Jim Meyering wrote: >> On Fri, Sep 9, 2016 at 1:29 PM, Jim Meyering wrote: >>> On Thu, Sep 8, 2016 at 7:33 PM, Assaf Gordon wrote: >>>> On 09/08/2016 04:40 PM, Jim Meyering wr

who.c vs gcc-7's improved buffer overrun check

2016-09-22 Thread Jim Meyering
I was intrigued to see my just-built-from-git gcc fail to compile who.c. It's probably too soon to accept a patch like this: in case gcc's static analysis is going to be improved enough that it can derive the invariant that the assert makes explicit. So, perhaps just for reference, for now, here'

Re: who.c vs gcc-7's improved buffer overrun check

2016-09-22 Thread Jim Meyering
On Thu, Sep 22, 2016 at 9:31 AM, Pádraig Brady wrote: > On 22/09/16 16:03, Jim Meyering wrote: >> I was intrigued to see my just-built-from-git gcc fail to compile who.c. >> >> It's probably too soon to accept a patch like this: in case gcc's >> static analysi

[PATCH] maint: pr: avoid new GCC 7 warning

2016-10-04 Thread Jim Meyering
Building with GCC 7, here's a fix for one of the new warnings: From 9403b93c15ec2ed8fdc7c993263260a91e6b4e8c Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 14 Sep 2016 11:48:33 -0700 Subject: [PATCH] maint: pr: avoid new GCC 7 warning * src/pr.c (main): Avoid this warning from GCC 7

avoid new GCC-7-exposed warnings

2016-10-14 Thread Jim Meyering
rom 35f28e3cdc0132ef87c5213e0c42b5b409d188d7 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 3 Oct 2016 09:00:48 -0700 Subject: [PATCH 1/3] gnulib: update to latest and adapt printf-quote.sh test * .gitignore: Add /lib/limits.h. * tests/misc/printf-quote.sh: Reflect that a single quote is now rendered as "'&quo

Re: avoid new GCC-7-exposed warnings

2016-10-15 Thread Jim Meyering
On Sat, Oct 15, 2016 at 2:55 AM, Pádraig Brady wrote: > On 15/10/16 05:47, Jim Meyering wrote: >> I tried to build the coreutils using very recent GCC 7, built from >> latest git, and encountered a few new warnings (errors when configured >> with --enable-gcc-warnings), so w

Re: avoid new GCC-7-exposed warnings

2016-10-15 Thread Jim Meyering
On Sat, Oct 15, 2016 at 8:40 AM, Jim Meyering wrote: > On Sat, Oct 15, 2016 at 2:55 AM, Pádraig Brady wrote: >> On 15/10/16 05:47, Jim Meyering wrote: >>> I tried to build the coreutils using very recent GCC 7, built from >>> latest git, and encountered a few new warni

Re: avoid new GCC-7-exposed warnings

2016-10-15 Thread Jim Meyering
On Sat, Oct 15, 2016 at 8:56 AM, Jim Meyering wrote: > On Sat, Oct 15, 2016 at 8:40 AM, Jim Meyering wrote: >> On Sat, Oct 15, 2016 at 2:55 AM, Pádraig Brady wrote: >>> On 15/10/16 05:47, Jim Meyering wrote: >>>> I tried to build the coreutils using very recent GCC

Re: avoid new GCC-7-exposed warnings

2016-10-16 Thread Jim Meyering
|| : > > will push later... Thanks. Here's one more change I'll push today. It removes a few now-useless calls to "abort" after die, and by a similar token, removes some "break;" statements after abort: From f8b8bbc1b97c9cb7a56aae79451bf87ab7307cd2 Mon Sep 17 00

Re: avoid new GCC-7-exposed warnings

2016-10-16 Thread Jim Meyering
On Sun, Oct 16, 2016 at 12:13 PM, Pádraig Brady wrote: > On 16/10/16 19:50, Jim Meyering wrote: ... >> Here's one more change I'll push today. It removes a few now-useless >> calls to "abort" after die, and by a similar token, removes some >> "

Re: quarter code for date

2016-11-02 Thread Jim Meyering
On Wed, Nov 2, 2016 at 10:36 AM, Pádraig Brady wrote: > On 06/10/16 12:53, Pádraig Brady wrote: >> On 06/10/16 11:11, john woods wrote: >>> date +%YW%V gives week and year; it would be nice if date +%YQ%q could >>> return, eg 2016Q3 as having a quarters code in date would save AWKwardness >>> or s

Re: [PATCH] doc: improve the --help description of ls -N

2016-11-04 Thread Jim Meyering
On Thu, Nov 3, 2016 at 2:28 PM, Pádraig Brady wrote: > * src/ls.c (usage): The existing description was inaccurate > as -N does not directly impact whether control characters > are displayed or not. > --- > src/ls.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/ls

Re: [PATCH] tail: ensure -f --retry 'missing' handles truncation

2016-11-09 Thread Jim Meyering
On Wed, Nov 9, 2016 at 9:57 AM, Pádraig Brady wrote: > * src/tail.c (tail_forever): The BLOCKING optimization is only > enabled for non regular files (which can't be truncated), so ensure > we don't enable that unless we've a valid st_mode. > * tests/tail-2/retry.sh: Add a test case. > * NEWS: Men

Re: [PATCH] tail: only retry file open if --retry specifed

2016-11-10 Thread Jim Meyering
On Wed, Nov 9, 2016 at 11:40 AM, Pádraig Brady wrote: > * src/tail.c (tail_file): On failure to open a file, > set ignore=true when --retry is not specified. > * tests/tail-2/assert-2.sh: Adjust to the new behavior. > * tests/tail-2/retry.sh: Add a test case. > * NEWS: Document the fix. > --- > N

[PATCH] tests: use "returns_" rather than explicit comparison with "$?"

2016-11-12 Thread Jim Meyering
ers "$?". Here's an example of what most of these changes look like: -ls -l --time-style=XX > out 2> err -test $? = 2 || fail=1 +returns_ 2 ls -l --time-style=XX > out 2> err || fail=1 From 2371c4d84f577a8720b2ba244453cb94619a099f Mon Sep 17 00:00:00 2001 From: Jim

Re: using ASCII names to avoid overhead

2016-11-13 Thread Jim Meyering
On Sun, Nov 13, 2016 at 7:14 AM, Pádraig Brady wrote: > On 13/11/16 14:14, Pádraig Brady wrote: >> On 13/11/16 12:42, Torbjörn Granlund wrote: >>> Pádraig Brady writes: >>> >>> I was just looking at the overhead of proper_name_utf8() vs proper_name() >>> in coreutils, and noticed that using t

Re: [PATCH] tests: use "returns_" rather than explicit comparison with "$?"

2016-11-13 Thread Jim Meyering
On Sun, Nov 13, 2016 at 9:24 AM, Bernhard Voelker wrote: > On 11/13/2016 03:38 AM, Jim Meyering wrote: >> I noticed many tests that compare directly with "$?". However, we now >> have the "returns_" function (from init.sh) that can be used to make >> the

Re: [PATCH] tests: use "returns_" rather than explicit comparison with "$?"

2016-11-13 Thread Jim Meyering
On Sun, Nov 13, 2016 at 11:05 AM, Jim Meyering wrote: > On Sun, Nov 13, 2016 at 9:24 AM, Bernhard Voelker > wrote: >> On 11/13/2016 03:38 AM, Jim Meyering wrote: >>> I noticed many tests that compare directly with "$?". However, we now >>> have the "

Re: [PATCH] tests: fix false failure on OS X

2016-11-15 Thread Jim Meyering
Typo in log message: s/definfed/defined/. Otherwise looks fine. Thanks!

maint: avoid "make distcheck" failure due to excess .deps directories

2016-11-21 Thread Jim Meyering
uot;make distcheck" pass: From 5bf01120f0a76a37b0c0ea54880e1aba9747d382 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 14 Sep 2016 14:16:40 -0700 Subject: [PATCH] maint: avoid "make distcheck" failure due to excess .deps directories * Makefile.am (my-distcheck): Remove all .deps directories befor

Re: maint: avoid "make distcheck" failure due to excess .deps directories

2016-11-22 Thread Jim Meyering
On Tue, Nov 22, 2016 at 4:43 AM, Pádraig Brady wrote: > On 22/11/16 05:28, Jim Meyering wrote: >> * Makefile.am (my-distcheck): Remove all .deps directories before >> recursive diff search for left-behind files. Otherwise, with >> automake master (v1.15-165-g5fac9a3), "

[PATCH] build: avoid racy failure of "make -jN install"

2016-11-22 Thread Jim Meyering
man page installation could cause "make install" failure. Here's a fix: From f7d169431ab70ee50713891b5d7b7e2c301c65bc Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 22 Nov 2016 21:33:58 -0800 Subject: [PATCH] build: avoid racy failure of "make -jN install" Insta

Re: [PATCH] build: avoid racy failure of "make -jN install"

2016-11-23 Thread Jim Meyering
On Wed, Nov 23, 2016 at 3:18 AM, Eric Blake wrote: > On 11/23/2016 04:54 AM, Pádraig Brady wrote: >> On 23/11/16 05:36, Jim Meyering wrote: >>> diff --git a/src/local.mk b/src/local.mk >>> index 9e36ad9..37f625c 100644 >>> --- a/src/local.mk >>> ++

Re: [PATCH] tail: fix determination of remoteness without inotify

2016-11-23 Thread Jim Meyering
On Wed, Nov 23, 2016 at 11:18 AM, Pádraig Brady wrote: > In recent commit v8.25-93-g7fc7206 we used the f-remote flag > which wasn't set in all cases. This was detected with > ASAN giving this error when reading f->remote; > runtime error: load of value 190, > which is not a valid value for t

Re: wc -c /proc /sys handling

2016-12-22 Thread Jim Meyering
On Thu, Dec 22, 2016 at 7:25 AM, Pádraig Brady wrote: > On 21/03/16 18:42, Jim Meyering wrote: >> On Mon, Mar 21, 2016 at 8:57 AM, Pádraig Brady wrote: >>> I was wondering if we should not penalize all normal files, >>> to handle the /proc and /sys approximate st_size

Re: [PATCH] maint: RFC: add lzip tarballs

2017-01-11 Thread Jim Meyering
On Wed, Jan 11, 2017 at 3:21 PM, Eric Blake wrote: > Coreutils picked 'dist-xz' back in 2008 (see commit b52a8860), > and automake didn't support 'dist-lzip' until 2011 (but forgot > to mention it in NEWS). Our choice of .xz has thus been mostly > one of inertia. > > But these days, there are str

[PATCH] maint: tweak xz options to compress the release tarball even more

2017-01-11 Thread Jim Meyering
Recent discussion reminded me of this languishing patch. The only reason to be wary is that it increases the decompression-time memory requirement to 48MiB (from 32MiB). At least one very-small-system user complained back when I compressed some release tarball using -9: their system did not have s

Re: [PATCH] maint: tweak xz options to compress the release tarball even more

2017-01-13 Thread Jim Meyering
On Wed, Jan 11, 2017 at 6:31 PM, Antonio Diaz Diaz wrote: > Jim Meyering wrote: >> >> -export XZ_OPT = -8e >> +export XZ_OPT = --lzma2=preset=9e,dict=48MiB,pb=0 > > > Isn't this going to impact the use of pristine-tar? > https://packages.debian.org/sid/p

[PATCH] maint: update README-hacking now that vc-dwim accepts --init

2017-01-14 Thread Jim Meyering
I've released vc-dwim-1.8: https://savannah.gnu.org/forum/forum.php?forum_id=8776 And that renders part of README-release obsolete, so I propose to modernize it with this: >From 6bb0b403363316b8958f4686141561ee20d088ad Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 14 Jan 20

Re: strengthening ARRAY_CARDINALITY

2017-01-19 Thread Jim Meyering
On Thu, Jan 19, 2017 at 5:06 PM, Mike Frysinger wrote: > On 19 Jan 2017 22:20, Pádraig Brady wrote: >> On 19/01/17 21:52, Eric Blake wrote: >> > On the qemu list, it was pointed out that code that uses >> > ARRAY_CARDINALITY() might still compile even after it has been >> > refactored to use a poi

Re: strengthening ARRAY_CARDINALITY

2017-01-20 Thread Jim Meyering
On Fri, Jan 20, 2017 at 5:57 AM, Eric Blake wrote: > On 01/19/2017 09:43 PM, Mike Frysinger wrote: > > gnulib module + extra checks + name change to ARRAY_SIZE sound good! > For a convenience feature, ARRAY_CARDINALITY is not a convenient name. yeah, "cardinality" sounds more

Re: Notes on testing coreutils

2017-01-23 Thread Jim Meyering
On Mon, Jan 23, 2017 at 9:04 AM, Pádraig Brady wrote: > FYI I summarized some notes on testing coreutils at > https://news.ycombinator.com/item?id=13463620 Very nice write-up. Going through it now. One nit: "LDP_RELOAD"

Re: [PATCH] build: Properly expand cu_install_program viariable when cross-compiling

2017-01-25 Thread Jim Meyering
On Wed, Jan 25, 2017 at 8:56 AM, Eric Blake wrote: > I made those tweaks and pushed. Thank you.

[coreutils] savannah bug-tracker email forwarding change

2010-03-26 Thread Jim Meyering
Heads up: Until today, if you opened or changed a bug on savannah, email about that would be sent to bug-coreutils. However, now that bug-coreutils is routed to the new bug tracker at http://debbugs.gnu.org/coreutils, that created a bit of a mess, so as a temporary measure, I've routed savannah bu

[coreutils] FYI: disabled posting to bug and patch trackers

2010-03-27 Thread Jim Meyering
FYI, I've just disabled posting and comment-adding to the bug- and patch-trackers. Admins can still do that, but no one else. We've always made it clear that problem reports should go to bug-coreut...@gnu.org. Now, each message to that list is added to the new http://debbugs.gnu.org/coreutils tr

Re: [coreutils] Feature: Introduce fiemap copy to cp(1) and mv(1) v2

2010-04-09 Thread Jim Meyering
jeff.liu wrote: > Hello All, > > Please ignore the previous patchsets, there is an issue I just fixed. Please summarize incremental changes (patch and/or text) so we don't have to guess or generate them ourselves and inspect. > The revised version were shown as following: > >>From b3fc14ca851c671

bug#5914: feature request and non-bug patches submit policy

2010-04-09 Thread Jim Meyering
jeff.liu wrote: > Hi Jim, > > I'd like to know if I should still submit new feature patches to here or > coreut...@gnu.org. > > A few months ago, I found the heads up for the new coreutils@gnu.org mail > list, and it mentioned > only the bugs report/fix should be send to this list. Otherwise, fo

Re: [coreutils] Feature: Introduce fiemap copy to cp(1) and mv(1) v2

2010-04-09 Thread Jim Meyering
jeff.liu wrote: > Please ignore the previous patchsets, there is an issue I just fixed. ... > Subject: [PATCH 1/2] Add fiemap.h for fiemap ioctl(2) support. While reading through HACKING, bear in mind some implied requirements for new features. You should: - document it in NEWS - document it

bug#5915: [coreutils] Feature: Introduce fiemap copy to cp(1) and mv(1) v2

2010-04-09 Thread Jim Meyering
jeff.liu wrote: > [...explanation...] Thanks. ... >> Run "make syntax-check", or even "make distcheck" ... > Sorry to make this stupidly mistake again, I will do double check for furture > patches submition. It's not a big deal. Notice that you can probably tell your editor not to do that a

[coreutils] coreutils-8.5 released [stable]

2010-04-23 Thread Jim Meyering
This is to announce coreutils-8.5, a bug-fix-only "stable" release. This is a good time for a release. It's been over three months, during which we've seen a few bug fixes. In addition, a few features are nearly ready, and it is good to get a stable release out before adding those to the mix. Her

Re: [coreutils] Re: bug#5987: ready for 8.5?

2010-04-28 Thread Jim Meyering
Pádraig Brady wrote: > On 24/04/10 21:37, Bob Proulx wrote: >> Jim Meyering wrote: >>> With today's sort fix, in spite of it being for the >>> obsolete option format, I'm inclined to release coreutils-8.5. >>> >>> Do any of you know of pend

[coreutils] [PATCH 1/2] build: remove now-useless configure-time header checks

2010-04-29 Thread Jim Meyering
[I'll try to send FYI patches like this to the non bug- list, so as to avoid creating a ticket ] >From 518a8664a27d19a31e177fb26c775709d7bdc726 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 29 Apr 2010 11:32:37 +0200 Subject: [PATCH 1/2] build: remove now-useless configure-tim

[coreutils] [PATCH] build: update gnulib submodule to latest; bootstrap, too

2010-04-30 Thread Jim Meyering
FYI, >From 5e9a7ae46b58ec8c59157b4e16c3773b1e72802b Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 30 Apr 2010 18:27:19 +0200 Subject: [PATCH] build: update gnulib submodule to latest; bootstrap, too --- bootstrap | 10 +- gnulib|2 +- 2 files changed, 6 inserti

[coreutils] [PATCH] doc: factor hard-coded project-specific bits from README-release, ...

2010-05-03 Thread Jim Meyering
FYI, This makes the release procedure slightly more automated: >From 9e42ecceff823a9f966b798bda5b33463d199277 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 3 May 2010 22:00:30 +0200 Subject: [PATCH] doc: factor hard-coded project-specific bits from README-release, ... using the

[coreutils] [PATCH] tests: improve the always_defined_macros check

2010-05-09 Thread Jim Meyering
FYI, >From cab21195422804046a7f2b18de2282a46a2e8f39 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 9 May 2010 12:08:21 +0200 Subject: [PATCH] tests: improve the always_defined_macros check * cfg.mk (sc_always_defined_macros): Adjust its helpers not to depend on the existence of ./

[coreutils] [PATCH 1/4] tests: improve the always_defined_macros check

2010-05-09 Thread Jim Meyering
FYI, >From cab21195422804046a7f2b18de2282a46a2e8f39 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 9 May 2010 12:08:21 +0200 Subject: [PATCH 1/4] tests: improve the always_defined_macros check * cfg.mk (sc_always_defined_macros): Adjust its helpers not to depend on the existence

[coreutils] Re: gettext: update to 0.18

2010-05-10 Thread Jim Meyering
rsion 0.17 but the autoconf macros are from gettext version 0.18 Not surprisingly, installing gettext-0.18 and regenerating po/Makefile.in.in solves the problem. I've just pushed the following, in order to make that apparent earlier in the build process: >From 0c22e841565492279dbeb63b

[coreutils] [PATCH] build: avoid a new -Wformat-induced warning

2010-05-17 Thread Jim Meyering
785816e6 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 17 May 2010 09:09:28 +0200 Subject: [PATCH] build: avoid a new -Wformat-induced warning * src/sort.c (mark_key): Add a cast-to-int of a printf field width, to placate -Wformat. --- src/sort.c |2 +- 1 files changed, 1 insertions(+),

[coreutils] [PATCH] tests: update init.sh from gnulib

2010-05-17 Thread Jim Meyering
FYI, >From 1173dcd632b08a1b1d2323d2f35e233e2808698e Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 17 May 2010 09:12:22 +0200 Subject: [PATCH] tests: update init.sh from gnulib * tests/init.sh: Update from gnulib. --- tests/init.sh |

[coreutils] [PATCH] maint: fix the fs-magic-compare rule

2010-05-17 Thread Jim Meyering
8e785b80e7fcf Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 17 May 2010 16:10:24 +0200 Subject: [PATCH] maint: fix the fs-magic-compare rule * src/Makefile.am (fs-def): Sort definitions. This is required by fs-magic-compare's use of join. --- src/Makefile.am |2 +- 1 files cha

[coreutils] [PATCH] maint: remove unneeded double quotes on RHS of shell assignments

2010-05-25 Thread Jim Meyering
FYI, minor stylistic preference... >From 55db9a39a818e82324e1304e5d886aa2cf137092 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 25 May 2010 12:32:03 +0200 Subject: [PATCH] maint: remove unneeded double quotes on RHS of shell assignments Run this command: git grep -l '

[coreutils] 3 maint patches

2010-05-27 Thread Jim Meyering
FYI, commit d4201905ab4ed20ec3a5e2aea528835552e84a1d Author: Jim Meyering Date: Wed May 26 11:33:53 2010 +0200 tests: update help-version to work with parted, too * tests/misc/help-version: Add init code for GNU Parted. commit 5d59808a65dc05c2777afb4b78128ca9db1ea78f Author: Jim

[coreutils] considering uncrustify for automatic indentation: prepare

2010-05-31 Thread Jim Meyering
[PATCH 1/4] stat: use gnulib's alignof module [PATCH 2/4] maint: correct indentation of case_GETOPT_* macro uses [PATCH 3/4] maint: replace each "for (;;)" with "while (true)" [PATCH 4/4] maint: make spacing around "=" consistent, even in IF_LINT I've been considering using uncrustify to a

[coreutils] [PATCH 1/4] stat: use gnulib's alignof module

2010-05-31 Thread Jim Meyering
From: Jim Meyering * src/stat.c (alignof): Remove definition. Instead, include "alignof.h", and sort the #include directives. And get its definition from the gnulib module by that name: * bootstrap.conf (gnulib_modules): Add alignof. --- bootstrap.conf |1 + src/stat.c |7

[coreutils] [PATCH 2/4] maint: correct indentation of case_GETOPT_* macro uses

2010-05-31 Thread Jim Meyering
From: Jim Meyering * src/base64.c (main): Correct indentation of syntactically questionable case_GETOPT_HELP_CHAR and case_GETOPT_VERSION_CHAR macros. * src/who.c (main): Likewise. --- src/base64.c |4 ++-- src/who.c|4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[coreutils] [PATCH 4/4] maint: make spacing around "=" consistent, even in IF_LINT

2010-05-31 Thread Jim Meyering
From: Jim Meyering E.g., - size_t desired_width IF_LINT (= 0); + size_t desired_width IF_LINT ( = 0); Use this command: g grep -l IF_LINT | grep '\.[ch]$' \ | xargs perl -pi -e 's/(IF_LINT \()= /$1 = /' --- src/chmod.c|4 ++-- src/copy.c |2 +- s

[coreutils] [PATCH 3/4] maint: replace each "for (; ; )" with "while (true)"

2010-05-31 Thread Jim Meyering
From: Jim Meyering Run this command: git ls-files | grep '\.[ch]$' \ | xargs perl -pi -e 's/for \(;;\)/while (true)/g' ...except for randint.c, which does not include stdbool.h. In that case, use "while (1)". * gl/lib/randint.c (randint_genmax): Use "w

Re: [coreutils] considering uncrustify for automatic indentation: prepare

2010-05-31 Thread Jim Meyering
Pádraig Brady wrote: > On 31/05/10 10:12, Jim Meyering wrote: >> [PATCH 1/4] stat: use gnulib's alignof module >> [PATCH 2/4] maint: correct indentation of case_GETOPT_* macro uses >> [PATCH 3/4] maint: replace each "for (;;)" with "while (true)&quo

[coreutils] [PATCH 1/2] sort: avoid unnecessary use of sprintf

2010-06-08 Thread Jim Meyering
this. >From f1d5b696858482c58ecc203387c77f048643c19d Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 6 Jun 2010 18:51:42 +0200 Subject: [PATCH 1/2] sort: avoid unnecessary use of sprintf sprintf is relatively heavy-weight. * src/sort.c (key_warnings): Use umaxtostr and stpcpy rather than

Re: [coreutils] [PATCH 1/2] sort: avoid unnecessary use of sprintf

2010-06-08 Thread Jim Meyering
Pádraig Brady wrote: > On 08/06/10 10:42, Jim Meyering wrote: >> This first patch removes uses of sprintf in favor of >> umaxtostr and stpcpy. > > A little less standard, and we don't really care > about performance in --debug, but fair enough. It was partly on

[coreutils] [PATCH] ls: avoid buffer overrun

2010-06-10 Thread Jim Meyering
--- - 2010-06-10 11:45:05.018351899 -0400 +++ exp 2010-06-10 11:45:05.0 -0400 @@ -1,3 +1,2 @@ -d: total 0 ?? ? ?? s >From 4a6aac042d74defff2f224b1e538c280c02bb5a8 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 10 Jun 2010 17:49:30 +0200 Subject: [PATCH]

[coreutils] FYI, just updated to latest gnulib

2010-06-11 Thread Jim Meyering
I've just pushed these two: >From 155c8148ae06dcbbdfb85837e4aebe0080b71d2a Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 10 Jun 2010 23:33:17 +0200 Subject: [PATCH 1/2] build: don't let a large sparse temporary file cause "make dist" to fail * bootstrap.c

Re: [coreutils] Project web page mailing list information updated.

2010-06-12 Thread Jim Meyering
Bob Proulx wrote: > Peng Yu pointed out that the mailing list information on the project > web page didn't mention this mailing list! > > I just updated the mailing information there. > > http://www.gnu.org/software/coreutils/ Thanks, Bob and Peng. > I didn't mention coreutils-patches at all.

[coreutils] [Bug 591969] Re: dd: cryptic error message when bs=

2010-06-14 Thread Jim Meyering
nterproductive or error-inducing." While I deliberately do not mention the actual limits above, note that they're about half of the numbers you listed: ~1GiB and ~8EiB I went ahead and wrote the patch: >From d8e0d2d0efba4fa9c5bc1c29bf7e0028dd292237 Mon Sep 17 00:00:00 2001 From

[coreutils] Re: Bug#586581: coreutils: comm - Slight formatting error in manual page

2010-06-20 Thread Jim Meyering
file1 file2 Print lines in file1 not in file2, and vice versa. > > The last two lines should probably read: > >comm -3 file1 file2 > Print lines in file1 not in file2, and vice versa. Thank you. I'll fix it like this: >From 1419af82433027b03c2d49f7a401be

[coreutils] [PATCH] stat: remove support for deprecated --context (-Z) option

2010-06-22 Thread Jim Meyering
FYI, >From 13f323786c0317347b448ae365fec95856dc0b8d Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 22 Jun 2010 11:41:22 +0200 Subject: [PATCH] stat: remove support for deprecated --context (-Z) option * src/stat.c (main): Remove support for the --context (-Z) option. In upstr

[coreutils] Re: Bug#353100: -B

2010-06-28 Thread Jim Meyering
nfo's wording should be copy/pasted to the > manpage. Thanks. This should help: >From 78efadd3e19f5f9dac70340785afaaf8e478aec6 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 28 Jun 2010 13:48:38 +0200 Subject: [PATCH] doc: df, du, ls: improve --blocksize description in --help

[coreutils] Re: [PATCH]: ls: do not show long iso time format for en_* locales

2010-06-30 Thread Jim Meyering
Pádraig Brady wrote: > On 30/09/09 10:54, Pádraig Brady wrote: ... > I'm going to apply the attached to be consistent > with coreutils releases since 8.1 which > inadvertently shipped an en.po file, thus getting > the shorter POSIX format. > > Note Fedora 13 has got the inadvertent format change >

bug#6543: tests: begin migrating from test-lib.sh to init.sh

2010-06-30 Thread Jim Meyering
the newer init.sh, not test-lib.sh. Also, this test script uses test-lib.sh's expensive_ test. Factoring the many helper functions into init.cfg makes it so both frameworks use the same functions, and I can now use fail_ there. >From cfee734a4c975c708744c6aab1f99aa0262b Mon Sep 17 00:00:0

[coreutils] [PATCH] build: update gnulib submodule to latest; update bootstrap, too

2010-07-01 Thread Jim Meyering
FYI, >From d27d6d371f3f7ede14b6bde79ddd45307d30fa47 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 1 Jul 2010 23:43:55 +0200 Subject: [PATCH] build: update gnulib submodule to latest; update bootstrap, too * gnulib: Update to latest, for hash.c improvement. * bootstrap: Update f

[coreutils] [PATCH] heap_alloc: avoid integer overflow

2010-07-14 Thread Jim Meyering
FYI, >From c5e350ec5625d7346c2a088fe478060358200c14 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 14 Jul 2010 11:05:50 -0500 Subject: [PATCH] heap_alloc: avoid integer overflow * gl/lib/heap.c (heap_alloc): Use xnmalloc rather than xmalloc, to avoid pathological overflow. --- gl/

Re: [coreutils] [PATCH] fadvise: new module providing a simpler interface to posix_fadvise

2010-07-15 Thread Jim Meyering
Pádraig Brady wrote: > I'm going to start adding posix_fadvise() hints to various utils, > but first I decided to clean up the interface a bit in a new module, > and adjust the existing posix_fadvise() users to use it. > > The main reason for the separate module is one doesn't > need ifdefs in each

bug#6600: [PATCH] sort: add --threads option to parallelize internal sort.

2010-07-15 Thread Jim Meyering
Pádraig Brady wrote: > On 15/07/10 01:07, Pádraig Brady wrote: >> On 13/07/10 01:59, Pádraig Brady wrote: >>> I've finally applied the patch. >>> http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commit;h=9face836 >>> >>> I made a few comment tweaks and added >>> some dependencies for the heap

Re: [coreutils] stdbuf util prevents easy static building of coreutils

2010-07-19 Thread Jim Meyering
Mike Frysinger wrote: > the semi-recent addition of the stdbuf util (and more importantly the > libstdbuf.so library) prevents easy static compilation of coreutils. > previously, i would do: > LDFLAGS=-static ./configure > > now though on a gcc system i get: > CCLD libstdbuf.so > /usr/lib

Re: [coreutils] [PATCH] fadvise: new module providing a simpler interface to posix_fadvise

2010-07-20 Thread Jim Meyering
Pádraig Brady wrote: > To get the same benefits noticed with `sort` > http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commit;h=dae35bac > I'm applying the same hint to all appropriate utils in the attached. ... > Linux does quite well without this hint, and is getting better: > http://art

[coreutils] [PATCH] sort: avoid gcc warning: explicitly ignore strtold result

2010-08-10 Thread Jim Meyering
e95a01421b45f1743713e88175448 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 10 Aug 2010 08:11:15 -0700 Subject: [PATCH] sort: avoid gcc warning: explicitly ignore strtold result * src/sort.c: Include "ignore-value.h". (debug_key): Use ignore_value. --- src/sort.c |3 ++- 1

Re: [coreutils] feature request: make chown/chmod/chgrp --verbose/--changes additionally show original property

2010-08-18 Thread Jim Meyering
William Plusnick wrote: > On Mon, Aug 2, 2010 at 6:32 AM, marcel partap wrote: > > Dear coreutil hackers, > as anyone doing *n*x housework regularly, i also am using these tools on a > regular basis, in scripts and manually. What i often miss (especially when > invoking actions rec

bug#6897: date -d '1991-04-14 +1 day' fails

2010-08-23 Thread Jim Meyering
Alan Curry wrote: ... > There might be less occurrences of this misunderstanding if we could teach > date that -d 4/14/1991 is not actually a request for 4/14/1991 00:00:00, but > "any time that existed during the day 4/14/1991", or perhaps a more specific > "the first second of 4/14/1991". Use th

[coreutils] fix a few nits

2010-09-04 Thread Jim Meyering
FYI, [PATCH 1/3] tac: suppress technically unneeded "free" [PATCH 2/3] build: use gettext-h, not gettext [PATCH 3/3] build: update gnulib submodule to latest >From fc9d948d7e6ff916b3ddb3ed371a6f8aa7f2c624 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 28 Aug

Re: [coreutils] Coreutils Solaris extensions

2010-09-10 Thread Jim Meyering
John Sonnenschein wrote: > We are considering extending some of the utilities in GNU Coreutils to > provide support for some of the newer Solaris features. We would like > to discuss if you'd consider accepting these additions upstream. If > that is possible, we'd like to get your guidance on abo

<    1   2   3   4   5   6   7   8   9   10   >